From mboxrd@z Thu Jan  1 00:00:00 1970
From: John Fastabend <john.fastabend@gmail.com>
Subject: Re: [Intel-wired-lan] [bpf-next V4 PATCH 03/14] i40e: setup
 xdp_rxq_info
Date: Thu, 4 Jan 2018 20:17:05 -0800
Message-ID: <aeac85ab-4b22-4cda-1f1c-5c3493454448@gmail.com>
References: <151497504273.18176.10177133999720101758.stgit@firesoul>
 <151497512387.18176.16261505821783867005.stgit@firesoul>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Paul Menzel <pmenzel@molgen.mpg.de>, netdev@vger.kernel.org,
        dsahern@gmail.com, intel-wired-lan@lists.osuosl.org,
        gospo@broadcom.com, bjorn.topel@intel.com,
        michael.chan@broadcom.com
To: Jesper Dangaard Brouer <brouer@redhat.com>,
        Daniel Borkmann <borkmann@iogearbox.net>,
        Alexei Starovoitov <alexei.starovoitov@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f67.google.com ([209.85.160.67]:45249 "EHLO
        mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751417AbeAEER0 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 4 Jan 2018 23:17:26 -0500
Received: by mail-pl0-f67.google.com with SMTP id o2so2387415plk.12
        for <netdev@vger.kernel.org>; Thu, 04 Jan 2018 20:17:26 -0800 (PST)
In-Reply-To: <151497512387.18176.16261505821783867005.stgit@firesoul>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 01/03/2018 02:25 AM, Jesper Dangaard Brouer wrote:
> The i40e driver has a special "FDIR" RX-ring (I40E_VSI_FDIR) which is
> a sideband channel for configuring/updating the flow director tables.
> This (i40e_vsi_)type does not invoke XDP-ebpf code.
> 
> As suggested by Björn (V2): Instead of marking this I40E_VSI_FDIR RX-ring
> a special case, reverse the logic and only select RX-rings of type
> I40E_VSI_MAIN to register xdp_rxq_info's for.
> 
> Driver hook points for xdp_rxq_info:
>  * reg  : i40e_setup_rx_descriptors (via i40e_vsi_setup_rx_resources)
>  * unreg: i40e_free_rx_resources    (via i40e_vsi_free_rx_resources)
> 
> Tested on actual hardware with samples/bpf program.
> 
> V2: Fixed bug in i40e_set_ringparam (memset zero) + match on I40E_VSI_MAIN.
> V4: Update patch desc that got out-of-sync with code.
> 
> Cc: intel-wired-lan@lists.osuosl.org
> Cc: Björn Töpel <bjorn.topel@intel.com>
> Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Cc: Paul Menzel <pmenzel@molgen.mpg.de>
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---


Same here. LGTM.

Acked-by: John Fastabend <john.fastabend@gmail.com>