From: Heiner Kallweit <hkallweit1@gmail.com>
To: Marek Vasut <marex@denx.de>, netdev@vger.kernel.org
Cc: Andrew Lunn <andrew@lunn.ch>, Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH net-next] net: ks8851: Connect and start/stop the internal PHY
Date: Mon, 11 Jan 2021 14:50:42 +0100 [thread overview]
Message-ID: <aeb906d3-be61-c3cd-4ec0-88e66f384369@gmail.com> (raw)
In-Reply-To: <8c46baf2-28c9-190a-090c-c2980842b78e@denx.de>
On 11.01.2021 14:38, Marek Vasut wrote:
> On 1/11/21 2:26 PM, Heiner Kallweit wrote:
> [...]
>
>> LGTM. When having a brief look at the driver I stumbled across two things:
>>
>> 1. Do MAC/PHY support any pause mode? Then a call to
>> phy_support_(a)sym_pause() would be missing.
>
> https://ww1.microchip.com/downloads/en/DeviceDoc/KSZ8851-16MLL-Single-Port-Ethernet-MAC-Controller-with-8-Bit-or-16-Bit-Non-PCI-Interface-DS00002357B.pdf
> page 64
>
> https://www.mouser.com/datasheet/2/268/ksz8851-16mll_ds-776208.pdf
> page 65
>
> The later is more complete.
>
> Apparently it does support pause.
>
>> 2. Don't have the datasheet, but IRQ_LCI seems to be the link change
>> interrupt. So far it's ignored by the driver. You could configure
>> it and use phy_mac_interrupt() to operate the internal PHY in
>> interrupt mode.
>
> That's only for link state change, shouldn't the PHY interrupt trigger on other things as well ?
No, it's sufficient if the interrupt can signal link state change.
In r8169 I have exactly that case.
next prev parent reply other threads:[~2021-01-11 13:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 12:53 [PATCH net-next] net: ks8851: Connect and start/stop the internal PHY Marek Vasut
2021-01-11 13:26 ` Heiner Kallweit
2021-01-11 13:38 ` Marek Vasut
2021-01-11 13:50 ` Heiner Kallweit [this message]
2021-01-11 14:10 ` Marek Vasut
2021-01-11 14:43 ` Heiner Kallweit
2021-01-12 22:28 ` Marek Vasut
2021-01-11 14:47 ` Andrew Lunn
2021-01-12 22:28 ` Marek Vasut
2021-01-14 13:54 ` Andrew Lunn
2021-01-15 12:45 ` Marek Vasut
2021-01-15 14:55 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeb906d3-be61-c3cd-4ec0-88e66f384369@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew@lunn.ch \
--cc=lukas@wunner.de \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).