From: Magnus Damm <magnus.damm@gmail.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH] ipconfig schedule fix
Date: Wed, 24 Nov 2004 01:02:33 +0100 [thread overview]
Message-ID: <aec7e5c3041123160259df1594@mail.gmail.com> (raw)
In-Reply-To: <20041123154513.0c950033.davem@davemloft.net>
On Tue, 23 Nov 2004 15:45:13 -0800, David S. Miller <davem@davemloft.net> wrote:
> On Wed, 24 Nov 2004 00:42:17 +0100
>
>
> Magnus Damm <magnus.damm@gmail.com> wrote:
>
> > On Tue, 23 Nov 2004 15:18:55 -0800, David S. Miller <davem@davemloft.net> wrote:
> > > On Tue, 23 Nov 2004 23:50:35 +0100
> > >
> > >
> > > Magnus Damm <magnus.damm@gmail.com> wrote:
> > >
> > > > This simple patch makes the DHCP/BOOTP/RARP code sleep with
> > > > schedule_timeout() instead of hogging the cpu with cpu_relax() in a
> > > > loop. This comes handy when a guest kernel is booted inside QEMU.
> > > > Without the patch, the host operating system will consume cpu time
> > > > busy waiting.
> > >
> > > There are two similar loops involving CONF_PRE_OPEN and CONF_POST_OPEN,
> > > you may wish to hit those while you're at it.
> >
> > Huh? You mean _removing_ the timeouts involving CONF_PRE/POST_OPEN? I
> > thought my patch converted all busy waits into schedule_timeout()...
> > What am I missing?
>
> No, not removing them, but transforming them likewise into
> schedule_timeout() calls.
Yeah, but isn't the patch already doing that? I tried to find more
occurances of CONF_PRE/POST_OPEN in the
linux-2.6.10-rc2-mm3/net/ipv4/ipconfig.c but I think the patch covers
all of them. Please point out what I am missing, maybe it is getting
too late for me know...
/ magnus
prev parent reply other threads:[~2004-11-24 0:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-23 22:50 [PATCH] ipconfig schedule fix Magnus Damm
2004-11-23 23:18 ` David S. Miller
2004-11-23 23:42 ` Magnus Damm
2004-11-23 23:45 ` David S. Miller
2004-11-24 0:02 ` Magnus Damm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aec7e5c3041123160259df1594@mail.gmail.com \
--to=magnus.damm@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).