From: "Magnus Damm" <magnus.damm@gmail.com>
To: "Stephen Hemminger" <shemminger@vyatta.com>
Cc: "David Miller" <davem@davemloft.net>,
"Ben Dooks" <ben-linux@fluff.org>,
"Paul Mundt" <lethal@linux-sh.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 3/3] ne-h8300: convert to net_device_ops
Date: Wed, 14 Jan 2009 15:37:24 +0900 [thread overview]
Message-ID: <aec7e5c30901132237t6e810763i140b76ff8623dc63@mail.gmail.com> (raw)
In-Reply-To: <20081203201028.533294548@vyatta.com>
On Thu, Dec 4, 2008 at 5:10 AM, Stephen Hemminger <shemminger@vyatta.com> wrote:
> Another device using 8390 library that needs converting.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
> --- a/drivers/net/Makefile 2008-12-03 12:04:17.000000000 -0800
> +++ b/drivers/net/Makefile 2008-12-03 12:07:25.000000000 -0800
> @@ -124,7 +124,7 @@ obj-$(CONFIG_NE3210) += ne3210.o 8390.o
> obj-$(CONFIG_SB1250_MAC) += sb1250-mac.o
> obj-$(CONFIG_B44) += b44.o
> obj-$(CONFIG_FORCEDETH) += forcedeth.o
> -obj-$(CONFIG_NE_H8300) += ne-h8300.o
> +obj-$(CONFIG_NE_H8300) += ne-h8300.o 8390.o
Are you sure this will work? The ne-h8300 driver includes "lib8390.c"
in the main source with special configuration parameters such as
EI_SHIFT, but with this patch 8390.o contains another lib8390 instance
with a different configuration that gets tied into the net_device_ops.
I have no hardware and I may misunderstand the code, but please double
check.
I came across this when trying to fix another problem with ax88796.
Basically, another lib8390 patch (link below) forgets the case with
all drivers that include "lib8390.c" which in the ax88796 case results
in a missing start_xmit callback.
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9a4a84294b0d60b8c287131478f743ba2bc68949
Paul, Ben, I have a fix for ax88796 that I'll post in a little while.
Cheers,
/ magnus
prev parent reply other threads:[~2009-01-14 6:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-03 20:10 [PATCH 0/3] More embedded 8390 netdevice ops conversions Stephen Hemminger
2008-12-03 20:10 ` [PATCH 1/3] zorro8390: convert to net_device_ops Stephen Hemminger
2008-12-04 6:09 ` David Miller
2008-12-03 20:10 ` [PATCH 2/3] hydra: " Stephen Hemminger
2008-12-04 6:10 ` David Miller
2008-12-03 20:10 ` [PATCH 3/3] ne-h8300: " Stephen Hemminger
2008-12-04 6:10 ` David Miller
2009-01-14 6:37 ` Magnus Damm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aec7e5c30901132237t6e810763i140b76ff8623dc63@mail.gmail.com \
--to=magnus.damm@gmail.com \
--cc=ben-linux@fluff.org \
--cc=davem@davemloft.net \
--cc=lethal@linux-sh.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).