From: Edward Cree <ecree.xilinx@gmail.com>
To: Alex Austin <alex.austin@amd.com>, netdev@vger.kernel.org
Cc: andrew+netdev@lunn.ch, bhutchings@solarflare.com,
davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
linux-kernel@vger.kernel.org, linux-net-drivers@amd.com,
pabeni@redhat.com, richardcochran@gmail.com,
smhodgson@solarflare.com, alucero@amd.com,
pieter.jansen-van-vuuren@amd.com,
Alejandro Lucero <alucerop@amd.com>
Subject: Re: [PATCH net 1/2] sfc: ptp: serialize host and MC synchronization transactions
Date: Mon, 12 Oct 2026 22:48:00 +0100 [thread overview]
Message-ID: <aecdab1f-9af6-4a07-938d-753ff9fc9938@gmail.com> (raw)
In-Reply-To: <20261009183240.1898762-2-alex.austin@amd.com>
On 09/10/2026 19:32, Alex Austin wrote:
> Protect the DMA handshake and result processing against concurrent
> synchronization callers. Serialize clock adjustments with the same mutex
> so they cannot change the PHC during a capture.
>
> Fixes: 7c236c43b838 ("sfc: Add support for IEEE-1588 PTP")
> Signed-off-by: Alex Austin <alex.austin@amd.com>
> Reviewed-by: Alejandro Lucero <alucerop@amd.com>
> Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>
...
> static int efx_phc_settime(struct ptp_clock_info *ptp,
> const struct timespec64 *e_ts)
> {
> - /* Get the current NIC time, efx_phc_gettime.
> - * Subtract from the desired time to get the offset
> - * call efx_phc_adjtime with the offset
> - */
Not immediately clear why this comment is getting disappeared; it appears
to still be accurate. Is it just thought superfluous?
-ed
next prev parent reply other threads:[~2026-10-12 21:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 18:32 [PATCH net 0/2] sfc: fix PTP synchronization races Alex Austin
2026-10-09 18:32 ` [PATCH net 1/2] sfc: ptp: serialize host and MC synchronization transactions Alex Austin
2026-10-10 19:10 ` netdev-bot+sashiko
2026-10-12 14:46 ` Austin, Alex (DCCG)
2026-10-12 21:48 ` Edward Cree [this message]
2026-10-09 18:32 ` [PATCH net 2/2] sfc: ptp: avoid racing PPS timestamp updates Alex Austin
2026-10-10 19:10 ` netdev-bot+sashiko
2026-10-09 18:35 ` [PATCH net 0/2] sfc: fix PTP synchronization races netdev-bot+sinfo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aecdab1f-9af6-4a07-938d-753ff9fc9938@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=alex.austin@amd.com \
--cc=alucero@amd.com \
--cc=alucerop@amd.com \
--cc=andrew+netdev@lunn.ch \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pieter.jansen-van-vuuren@amd.com \
--cc=richardcochran@gmail.com \
--cc=smhodgson@solarflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox