From: David Woodhouse <dwmw2@infradead.org>
To: Thomas Gleixner <tglx@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Cc: Miroslav Lichvar <mlichvar@redhat.com>,
John Stultz <jstultz@google.com>,
Stephen Boyd <sboyd@kernel.org>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
Frederic Weisbecker <frederic@kernel.org>,
thomas.weissschuh@linutronix.de,
Arthur Kiyanovski <akiyano@amazon.com>,
Rodolfo Giometti <giometti@enneenne.com>,
Vincent Donnefort <vdonnefort@google.com>,
Marc Zyngier <maz@kernel.org>,
Oliver Upton <oliver.upton@linux.dev>,
kvmarm@lists.linux.dev, Oliver Upton <oupton@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
netdev@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Miri Korenblit <miriam.rachel.korenblit@intel.com>,
Johannes Berg <johannes.berg@intel.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Peter Hilber <peter.hilber@oss.qualcomm.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
virtualization@lists.linux.dev, linux-wireless@vger.kernel.org,
linux-sound@vger.kernel.org,
Vadim Fedorenko <vadim.fedorenko@linux.dev>
Subject: Re: [patch V2 18/25] timekeeping: Prepare for cross timestamps on arbitrary clock IDs
Date: Mon, 22 Jun 2026 13:34:15 +0100 [thread overview]
Message-ID: <aeda79e82028a628cf2ccc40cdc91ec911570ef6.camel@infradead.org> (raw)
In-Reply-To: <87se6eltod.ffs@fw13>
[-- Attachment #1: Type: text/plain, Size: 861 bytes --]
On Mon, 2026-06-22 at 13:07 +0200, Thomas Gleixner wrote:
> On Mon, Jun 22 2026 at 09:55, David Woodhouse wrote:
> > We ended up with ktime_get_snapshot_id() also supporting CLOCK_BOOTTIME
> > and CLOCK_MONOTONIC_RAW, but not get_device_system_crosststamp().
> > Should we make that consistent?
>
> Maybe. The BOOTTIME support is only there for that ARM64 hyper trace muck,
> but has no other relevance.
>
> MONORAW is there for the PTP EXTENDED IOCTL, but with PRECISE the
> snapshot already contains the raw value and you'd have to prevent the
> historical adjustment part for RAW. So I don't see the actual value, but
> I don't have a strong opinion either.
Yeah, I'm not sure I see the need for it; it's just the consistency
thing that slightly bothered me once I had them both in my sights doing
the snapshot_ntp_error() thing in both.
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5069 bytes --]
next prev parent reply other threads:[~2026-06-22 12:34 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 19:59 [patch V2 00/25] timekeeping/ptp: Expand snapshot functionality Thomas Gleixner
2026-05-29 19:59 ` [patch V2 01/25] timekeeping: Provide ktime_get_snapshot_id() Thomas Gleixner
2026-05-29 19:59 ` [patch V2 02/25] timekeeping: Use system_time_snapshot::systime/monoraw instead of ::real/raw Thomas Gleixner
2026-05-29 19:59 ` [patch V2 03/25] pps: generators: Use ktime_get_real_ts64() instead of ktime_get_snapshot() Thomas Gleixner
2026-05-30 11:04 ` Rodolfo Giometti
2026-05-29 20:00 ` [patch V2 04/25] pps: Convert to ktime_get_snapshot_id() Thomas Gleixner
2026-05-30 11:08 ` Rodolfo Giometti
2026-06-02 9:31 ` Thomas Gleixner
2026-06-02 10:56 ` David Woodhouse
2026-05-29 20:00 ` [patch V2 05/25] KVM: arm64: Use ktime_get_snapshot_id() to retrieve CLOCK_BOOTTIME Thomas Gleixner
2026-05-29 20:00 ` [patch V2 06/25] KVM: arm64: Use ktime_get_snapshot_id() to snapshot CLOCK_REALTIME Thomas Gleixner
2026-05-29 20:00 ` [patch V2 07/25] ptp: ptp_vmclock: Convert to ktime_get_snapshot_id() Thomas Gleixner
2026-05-29 20:00 ` [patch V2 08/25] timekeeping: Remove system_time_snapshot::real/boot/raw Thomas Gleixner
2026-05-29 20:00 ` [patch V2 09/25] timekeeping: Add CLOCK_AUX support for ktime_get_snapshot_id() Thomas Gleixner
2026-05-29 20:00 ` [patch V2 10/25] timekeeping: Add system_counterval_t to struct system_device_crosststamp Thomas Gleixner
2026-05-29 20:00 ` [patch V2 11/25] timekeeping: Add CLOCK ID to system_device_crosststamp Thomas Gleixner
2026-05-29 20:00 ` [patch V2 12/25] wifi: iwlwifi: Adopt PTP cross timestamps to core changes Thomas Gleixner
2026-05-29 20:00 ` [patch V2 13/25] ice/ptp: Use provided clock ID for history snapshot Thomas Gleixner
2026-05-29 20:00 ` [patch V2 14/25] igc: " Thomas Gleixner
2026-05-29 20:00 ` [patch V2 15/25] net/mlx5: " Thomas Gleixner
2026-05-29 20:00 ` [patch V2 16/25] virtio_rtc: " Thomas Gleixner
2026-06-02 14:44 ` Peter Hilber
2026-05-29 20:00 ` [patch V2 17/25] timekeeping: Remove ktime_get_snapshot() Thomas Gleixner
2026-05-29 20:01 ` [patch V2 18/25] timekeeping: Prepare for cross timestamps on arbitrary clock IDs Thomas Gleixner
2026-06-22 8:55 ` David Woodhouse
2026-06-22 11:07 ` Thomas Gleixner
2026-06-22 12:34 ` David Woodhouse [this message]
2026-05-29 20:01 ` [patch V2 19/25] ptp: Use system_device_crosststamp::sys_systime Thomas Gleixner
2026-05-29 20:01 ` [patch V2 20/25] wifi: iwlwifi: " Thomas Gleixner
2026-05-29 20:01 ` [patch V2 21/25] ALSA: hda/common: " Thomas Gleixner
2026-06-02 17:46 ` Takashi Iwai
2026-05-29 20:01 ` [patch V2 22/25] timekeeping: Remove system_device_crosststamp::sys_realtime Thomas Gleixner
2026-05-29 20:01 ` [patch V2 23/25] timekeeping: Add support for AUX clock cross timestamping Thomas Gleixner
2026-05-29 20:01 ` [patch V2 24/25] ptp: Switch to ktime_get_snapshot_id() for pre/post timestamps Thomas Gleixner
2026-05-29 20:01 ` [patch V2 25/25] timekeeping: Add clocksource read_snapshot() method and hw_cycles to snapshot Thomas Gleixner
2026-05-29 20:33 ` [patch V2 00/25] timekeeping/ptp: Expand snapshot functionality Jacob Keller
2026-06-01 10:59 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeda79e82028a628cf2ccc40cdc91ec911570ef6.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=akiyano@amazon.com \
--cc=anna-maria@linutronix.de \
--cc=anthony.l.nguyen@intel.com \
--cc=frederic@kernel.org \
--cc=giometti@enneenne.com \
--cc=jacob.e.keller@intel.com \
--cc=johannes.berg@intel.com \
--cc=jstultz@google.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=maz@kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
--cc=mlichvar@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oliver.upton@linux.dev \
--cc=oupton@kernel.org \
--cc=peter.hilber@oss.qualcomm.com \
--cc=richardcochran@gmail.com \
--cc=saeedm@nvidia.com \
--cc=sboyd@kernel.org \
--cc=tglx@kernel.org \
--cc=thomas.weissschuh@linutronix.de \
--cc=tiwai@suse.com \
--cc=vadim.fedorenko@linux.dev \
--cc=vdonnefort@google.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox