From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8DED2D7DD7; Tue, 21 Apr 2026 12:39:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776775182; cv=none; b=NxQuqWLQdaYM87MLuqn7CIEioB46QJTbSiFaFMzL43gvHzfUw8CVJQd1NB/L0E2RxNwlYHHM9IS+C8Lpd2gptPurEjK/eLV5/VZJBfokpi0JEg1zyyqur45kPrk7VdMckNarPqLIkMAgYi4UP2KlN/wnfvem+idZwUgKBSBjQ70= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776775182; c=relaxed/simple; bh=d3LihHP7jY6TIKD4Yg1TnkCSvBzmJZqKnzSzxjz4rX4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZRO0yMksnvTGDdGDWT8quZOM9YaoyztJqsaSvtdkJKaVSzWPqsF6hr9NqkOxgd3VhbraeAIP1oT7O6vpXQRdm08waRKt4QNPgjw4f3Zqyf9jxAekJNwFHVtbzSblzCBFTzm+ZUxufv4K3wStviDecTBavFXjM+cs05MjzizoXY8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AC47sF47; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AC47sF47" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E6C5C2BCB0; Tue, 21 Apr 2026 12:39:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776775182; bh=d3LihHP7jY6TIKD4Yg1TnkCSvBzmJZqKnzSzxjz4rX4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AC47sF47/pg9LF5Famx9RwxaAsUSkc+GRKHFx6grRezUGY/+q49RSMHWa8s8mvp71 iV5kOWd9MirxtkoM8cQJ310VtMy2sDQEnLmTVdkDuNajY8YcRYOuqx6W8HdzG64U+v +xx3QqjuuhZKo9hbu0lfqw292GeIchac8KdbRW2OLFijC0U9AtQU7CZhL9e+rwcc5D 7tbZAqrQ/XXJHvuIE3ppqcyQK+nppFfrFjlr7RHh9Px+jaeEHeXn/jgwnv46LmUYhp suW3no8GSoLtZqJplCiDnftqdXMQOe5itE0MclJOH8GNx320OkIuWKdCYKFTNImg1Y Tah51pQQ+V+uQ== Date: Tue, 21 Apr 2026 18:09:24 +0530 From: Sumit Garg To: elder@kernel.org Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, robin.clark@oss.qualcomm.com, sean@poorly.run, akhilpo@oss.qualcomm.com, lumag@kernel.org, abhinav.kumar@linux.dev, jesszhan0024@gmail.com, marijn.suijten@somainline.org, airlied@gmail.com, simona@ffwll.ch, vikash.garodia@oss.qualcomm.com, dikshita.agarwal@oss.qualcomm.com, bod@kernel.org, mchehab@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jjohnson@kernel.org, mathieu.poirier@linaro.org, trilokkumar.soni@oss.qualcomm.com, mukesh.ojha@oss.qualcomm.com, pavan.kondeti@oss.qualcomm.com, jorge.ramirez@oss.qualcomm.com, tonyh@qti.qualcomm.com, vignesh.viswanathan@oss.qualcomm.com, srinivas.kandagatla@oss.qualcomm.com, amirreza.zarrabi@oss.qualcomm.com, jens.wiklander@linaro.org, op-tee@lists.trustedfirmware.org, apurupa@qti.qualcomm.com, skare@qti.qualcomm.com, harshal.dev@oss.qualcomm.com, linux-kernel@vger.kernel.org, Sumit Garg , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-remoteproc@vger.kernel.org Subject: Re: [PATCH v3 12/15] net: ipa: Switch to generic PAS TZ APIs Message-ID: References: <20260327131043.627120-1-sumit.garg@kernel.org> <20260327131043.627120-13-sumit.garg@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260327131043.627120-13-sumit.garg@kernel.org> Hey Alex, On Fri, Mar 27, 2026 at 06:40:40PM +0530, Sumit Garg wrote: > From: Sumit Garg > > Switch ipa client driver over to generic PAS TZ APIs. Generic PAS TZ > service allows to support multiple TZ implementation backends like QTEE > based SCM PAS service, OP-TEE based PAS service and any further future TZ > backend service. > > Signed-off-by: Sumit Garg > --- > drivers/net/ipa/Kconfig | 2 +- > drivers/net/ipa/ipa_main.c | 13 ++++++++----- > 2 files changed, 9 insertions(+), 6 deletions(-) > Can I get an ack from you on this change? I expect this complete patch-set to land via Qcom SoC tree. -Sumit > diff --git a/drivers/net/ipa/Kconfig b/drivers/net/ipa/Kconfig > index 01d219d3760c..a9aff1b7977d 100644 > --- a/drivers/net/ipa/Kconfig > +++ b/drivers/net/ipa/Kconfig > @@ -6,7 +6,7 @@ config QCOM_IPA > depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST) > depends on QCOM_AOSS_QMP || QCOM_AOSS_QMP=n > select QCOM_MDT_LOADER > - select QCOM_SCM > + select QCOM_PAS > select QCOM_QMI_HELPERS > help > Choose Y or M here to include support for the Qualcomm > diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c > index edead9c48d1f..8feb8493d5b5 100644 > --- a/drivers/net/ipa/ipa_main.c > +++ b/drivers/net/ipa/ipa_main.c > @@ -14,7 +14,7 @@ > #include > #include > > -#include > +#include > #include > > #include "ipa.h" > @@ -624,10 +624,13 @@ static int ipa_firmware_load(struct device *dev) > } > > ret = qcom_mdt_load(dev, fw, path, IPA_PAS_ID, virt, phys, size, NULL); > - if (ret) > + if (ret) { > dev_err(dev, "error %d loading \"%s\"\n", ret, path); > - else if ((ret = qcom_scm_pas_auth_and_reset(IPA_PAS_ID))) > - dev_err(dev, "error %d authenticating \"%s\"\n", ret, path); > + } else { > + ret = qcom_pas_auth_and_reset(IPA_PAS_ID); > + if (ret) > + dev_err(dev, "error %d authenticating \"%s\"\n", ret, path); > + } > > memunmap(virt); > out_release_firmware: > @@ -754,7 +757,7 @@ static enum ipa_firmware_loader ipa_firmware_loader(struct device *dev) > return IPA_LOADER_INVALID; > out_self: > /* We need Trust Zone to load firmware; make sure it's available */ > - if (qcom_scm_is_available()) > + if (qcom_pas_is_available()) > return IPA_LOADER_SELF; > > return IPA_LOADER_DEFER; > -- > 2.51.0 > >