From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f68.google.com ([209.85.160.68]:40179 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752186AbeCXP2E (ORCPT ); Sat, 24 Mar 2018 11:28:04 -0400 Received: by mail-pl0-f68.google.com with SMTP id x4-v6so9226329pln.7 for ; Sat, 24 Mar 2018 08:28:04 -0700 (PDT) Subject: Re: [PATCH RFC v2 net-next 00/21] net/ipv6: Separate data structures for FIB and data path To: Ido Schimmel Cc: netdev@vger.kernel.org, davem@davemloft.net, roopa@cumulusnetworks.com, eric.dumazet@gmail.com, weiwan@google.com, kafai@fb.com, yoshfuji@linux-ipv6.org References: <20180319033622.16693-1-dsahern@gmail.com> <20180324150516.GA8940@splinter> From: David Ahern Message-ID: Date: Sat, 24 Mar 2018 09:28:01 -0600 MIME-Version: 1.0 In-Reply-To: <20180324150516.GA8940@splinter> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 3/24/18 9:05 AM, Ido Schimmel wrote: > On Sun, Mar 18, 2018 at 08:36:01PM -0700, David Ahern wrote: >> This set is the first of many changes to improve the scalability of the >> IPv6 code. Follow on changes include: >> - consolidating duplicate fib6_info references like IPv4 does with >> duplicate fib_info > > Before that you need to further break fib6_info into fib6_info and > fib6_alias, or I misunderstood you? > I was only listing the high level intent - to consolidate duplication. I have not looked into that step yet, but I suspect that split can be done in the same patch set as consolidating duplicate fib6_info. As you know, my preference is to move to nexthop objects (makes fib6_nh optional). I have IPv4 done; IPv6 requires this patch set. To get there the patch sequence is: 1. separate data structures for fib and dst paths (this set), 2. cleanup set on top of this one (separate set only because this one is at 21 patches), and 3. nexthop API.