From: David Ahern <dsahern@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, shuah@kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] selftests: net: replace sleeps in fcnal-test with waits
Date: Sat, 6 Sep 2025 20:11:20 -0600 [thread overview]
Message-ID: <aee4ba5c-c944-4392-a6c7-6323af9274d8@gmail.com> (raw)
In-Reply-To: <20250907012116.3315344-1-kuba@kernel.org>
On 9/6/25 7:21 PM, Jakub Kicinski wrote:
> fcnal-test.sh already includes lib.sh, use relevant helpers
> instead of sleeping. The first chunk is replacing sleep after
> killing background commands. All remaining ones replace
> sleep after starting nettest as a server with wait_local_port_listen.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> tools/testing/selftests/net/fcnal-test.sh | 430 +++++++++++-----------
> 1 file changed, 215 insertions(+), 215 deletions(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
prev parent reply other threads:[~2025-09-07 2:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-07 1:21 [PATCH net-next 1/2] selftests: net: replace sleeps in fcnal-test with waits Jakub Kicinski
2025-09-07 1:21 ` [PATCH net-next 2/2] selftests: net: run groups from fcnal-test in parallel Jakub Kicinski
2025-09-07 2:11 ` David Ahern
2025-09-07 2:11 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aee4ba5c-c944-4392-a6c7-6323af9274d8@gmail.com \
--to=dsahern@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).