From: Jacob Keller <jacob.e.keller@intel.com>
To: Rosen Penev <rosenp@gmail.com>, <netdev@vger.kernel.org>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <linux@armlinux.org.uk>,
<linux-kernel@vger.kernel.org>, <o.rempel@pengutronix.de>,
<p.zabel@pengutronix.de>
Subject: Re: [PATCHv4 net-next] net: ag71xx: get reset control using devm api
Date: Wed, 28 Aug 2024 14:09:34 -0700 [thread overview]
Message-ID: <aeef6dd8-694c-4056-b6df-b1e660daedad@intel.com> (raw)
In-Reply-To: <20240826192904.100181-1-rosenp@gmail.com>
On 8/26/2024 12:28 PM, Rosen Penev wrote:
> Currently, the of variant is missing reset_control_put in error paths.
> The devm variant does not require it.
>
> Allows removing mdio_reset from the struct as it is not used outside the
> function.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
next prev parent reply other threads:[~2024-08-28 21:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 19:28 [PATCHv4 net-next] net: ag71xx: get reset control using devm api Rosen Penev
2024-08-28 21:09 ` Jacob Keller [this message]
2024-08-29 4:49 ` Oleksij Rempel
2024-08-29 5:56 ` Rosen Penev
-- strict thread matches above, loose matches on Subject: below --
2024-08-26 21:21 Rosen Penev
2024-08-27 23:12 ` Jakub Kicinski
2024-08-27 23:36 ` Rosen Penev
2024-08-29 22:20 ` Luiz Angelo Daros de Luca
2024-08-30 3:54 ` Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeef6dd8-694c-4056-b6df-b1e660daedad@intel.com \
--to=jacob.e.keller@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).