From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB7FE611E; Wed, 22 Apr 2026 06:31:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776839488; cv=none; b=gOgztwyxRimW5ThvCxksf6qir5yruj2FJFcoQYiyKzpjVdcF6uHCbKdAFYyCKuiTsqpTrb+ou2vmgdSWmA6d1DRAWGbKmIJC2rKfziqx+2tbHTlGYSW9sIr2TiKRF/XU+8rIurldodlMmZKnUU2n7zcLq/i8Ld27lU9THi+p7+g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776839488; c=relaxed/simple; bh=/JT1rsE/fdDROiyJO102hPNDshNNfAOJHHfQze3eg7Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ka2BDknzoYu08Dchuci+7pHeJL3fQvQUH/ZBoIrBvO5Te2Xx9EH96Z3AbJ2UQHpurpxWCpzzeXUVOS2FulD/BWNC0VUgeNcxzcxy2TeQDaj5rLIla73VIIWPHWNlJAKYX7O97c/BugsnmcyELJl5UeAxOnOo1w7bjERUOhVzYbs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=AYnh6nBA; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="AYnh6nBA" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9KHfvF8nokltrExzeaFD2wVzc+NQpqCVu7IQeK1vLBU=; b=AYnh6nBAIEtRV/3Za0zvlwkc1e IizRdKc/IXPcB160FeEwYDKxNKGMlRRi69e+5aJmRrHQOKHERhKkys3t/zNnjgVNmMKBPDGX7zrPV xNMKq/cEOVF4FpEEH/IQDcO4ZykMN5gooB2TIso4lYXYLydSpwwOutjk685D+WLCytF4yt792GpIo nesjXd7MLcaX9s9KyPZ6XaT2ndG8SHI3QT1iIU4xZ/GFMbyd1FXhoITNNmY+HDd6zH043Ito4BJqO TPYi6BV5j9MQXm87kIA2Mse/1zhYRqrhySzrlQKqBhg4FXVRlnxhv6tk7qHf8Aim0jCA312NF8WWN 6XKMnj5Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1wFR7P-00000009fKY-064M; Wed, 22 Apr 2026 06:31:27 +0000 Date: Tue, 21 Apr 2026 23:31:26 -0700 From: Christoph Hellwig To: Stefan Metzmacher Cc: linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, Linus Torvalds , Steve French , Tom Talpey , Long Li , Namjae Jeon , linux-rdma@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] smb: smbdirect: move fs/smb/common/smbdirect/ to fs/smb/smbdirect/ Message-ID: References: <20260419192018.3046449-1-metze@samba.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260419192018.3046449-1-metze@samba.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html > diff --git a/fs/smb/Makefile b/fs/smb/Makefile > index 9a1bf59a1a65..353b1c2eefc4 100644 > --- a/fs/smb/Makefile > +++ b/fs/smb/Makefile > @@ -1,5 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > > obj-$(CONFIG_SMBFS) += common/ > +obj-$(CONFIG_SMBDIRECT) += smbdirect/ Why is this not in net/smbdirect/ or driver/infiniband/ulp/smdirect? As far as I can tell there is zero file system logic in this code. > -#include "../common/smbdirect/smbdirect_public.h" > +#include "../smbdirect/public.h" And all these relative includes suggest you really want a include/linux/smdirect/ instead. While we're at it: __SMBDIRECT_EXPORT_SYMBOL__ is really odd. One thing is the __ pre- and postfix that make it look weird. The other is that EXPORT_SYMBOL_FOR_MODULES is for very specific symbols that really should not exported. What this warrants instead is a normal EXPORT_SYMBOL_NS_GPL.