From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50F4B33C19E for ; Fri, 24 Apr 2026 08:32:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777019546; cv=none; b=gVMBsGSDm4AFxXURcEvno+CvG9g/bdaHtpgahIH1HsOh+LJduMn7H+7qo0W1dmB11V1iYJHXZpIsKbURg4GccSrEjlD9rJ3IE6GIKM3SKdXXvIrPnQCQ66YVLoJtBVWRgMUHa8P4piNgC5e/pZ+6D31ZZ5/zOArgOVA3mQzEP/g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777019546; c=relaxed/simple; bh=pJkzSL/k+5TGVlKtzz3sl7/5vEzJQCMbHMekVJ4welw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FLiE3N3ezePJ5MuwF+OqTSgFsr5mLA1C5AY+FUSLxZej/3nJteYXxGnE0SHlj1jGvXHSb0KRYtFx4IodIj5Htb/u3soN8rJ/srynwk9y7ksXRnCZmreJsWDg7nts/dE4b3SMIWA0spGHmnpK4odYuZKV0Obiqwq+lH9IHV3K1JI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=cijdMRBm; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cijdMRBm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777019542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VJsfL0ZYr6ksiH6VKINKLh9cflWXlJdEnCTwwmMW534=; b=cijdMRBmY62jxMxlWJ39bAtadDmv7b7OsxT7WwuruEvf9Cz+tt0ZDzx6CVBOwE/MYEe7/h TxuztRWkf7s6r/ekx5sU0h7tVnQbN74dspnNA02iNEcbBosPX67xpSysnlJ7ljdY3wgKpL SMjOjn6vWMF4OP5Kprkbl6UPJYoWuMM= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-192-ewUZX9sePIKYDg19RBQe5A-1; Fri, 24 Apr 2026 04:32:19 -0400 X-MC-Unique: ewUZX9sePIKYDg19RBQe5A-1 X-Mimecast-MFC-AGG-ID: ewUZX9sePIKYDg19RBQe5A_1777019538 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EB87E1800578; Fri, 24 Apr 2026 08:32:17 +0000 (UTC) Received: from calimero.vinschen.de (unknown [10.44.32.45]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 68CDB19560AB; Fri, 24 Apr 2026 08:32:17 +0000 (UTC) Received: by calimero.vinschen.de (Postfix, from userid 500) id C0469A80BFD; Fri, 24 Apr 2026 10:32:14 +0200 (CEST) Date: Fri, 24 Apr 2026 10:32:14 +0200 From: Corinna Vinschen To: Simon Horman Cc: intel-wired-lan@osuosl.org, stable@vger.kernel.org, Jose Ignacio Tornos Martinez , netdev@vger.kernel.org, Corinna Vinschen Subject: Re: [Intel-wired-lan] [PATCH net] iavf: iavf_virtchnl_completion: drop duplicate ether_addr_equal() test Message-ID: Mail-Followup-To: Simon Horman , intel-wired-lan@osuosl.org, stable@vger.kernel.org, Jose Ignacio Tornos Martinez , netdev@vger.kernel.org References: <20260421111236.875379-1-vinschen@redhat.com> <20260423185530.GI900403@horms.kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260423185530.GI900403@horms.kernel.org> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 On Apr 23 19:55, Simon Horman wrote: > On Tue, Apr 21, 2026 at 01:12:36PM +0200, Corinna Vinschen wrote: > > This is just a simple cleanup fix. Commit 35a2443d0910f ("iavf: Add > > waiting for response from PF in set mac") introduced a duplicate > > ether_addr_equal() check, so the current code tests the new MAC twice > > against the former MAC. > > > > Remove the outer ether_addr_equal() test, remnant of commit c5c922b3e09b > > ("iavf: fix MAC address setting for VFs when filter is rejected") > > > > Signed-off-by: Corinna Vinschen > > Fixes: 35a2443d0910f ("iavf: Add waiting for response from PF in set mac") > > Reviewed-by: Aleksandr Loktionov > > --- > > Added CC: stable@vger.kernel.org > > Hi, > > This feels more like a cleanup for net-next (without a Fixes tag) > than a fix for net. I'm missing where the bug is here. Yeah, it's not a bug, the "Fixes" tag was just supposed to point out the patch introducing the duplicate test. Shall I create a v3 or is it ok as is and just goes to net-next instead of net? Thanks, Corinna