From: Florian Fainelli <f.fainelli@gmail.com>
To: Woojung.Huh@microchip.com, zach.brown@ni.com,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net] phy: fix error case of phy_led_triggers_(un)register
Date: Wed, 23 Nov 2016 15:02:20 -0800 [thread overview]
Message-ID: <af015fe1-d27a-97e0-29c1-5d423af0e9a4@gmail.com> (raw)
In-Reply-To: <9235D6609DB808459E95D78E17F2E43D40969D0E@CHN-SV-EXMX02.mchp-main.com>
Le 23/11/2016 à 13:39, Woojung.Huh@microchip.com a écrit :
> From: Woojung Huh <woojung.huh@microchip.com>
>
> When phy_init_hw() fails at phy_attach_direct();
> - phy_detach() calls phy_led_triggers_unregister() without
> previous call of phy_led_triggers_register().
> - still call phy_led_triggers_register() and cause memory leak.
>
> Signed-off-by: Woojung Huh <woojung.huh@microchip.com>
Since you probably have to resubmit this, can you also add a Fixes tag:
Fixes: 2e0bc452f472 ("net: phy: leds: add support for led triggers on
phy link state change")
Thanks!
--
Florian
prev parent reply other threads:[~2016-11-23 23:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 21:39 [PATCH net] phy: fix error case of phy_led_triggers_(un)register Woojung.Huh
2016-11-23 21:55 ` Sergei Shtylyov
2016-11-23 22:15 ` Andrew Lunn
2016-11-23 23:02 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af015fe1-d27a-97e0-29c1-5d423af0e9a4@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Woojung.Huh@microchip.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=zach.brown@ni.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox