From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65970212550 for ; Thu, 14 May 2026 12:55:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778763355; cv=none; b=rE3fYk/9GztsqXfKj7wntZwdhD6YpfCLCsqbjy8vRtP57IZAWM4nH5Uhg9KKoBJXiSuWGoSaf/ZDi0FcfHWbX50HaAOYXUT/V1SkKJa6/svVcdhHY2dBWZlum67oi8C7b/KH4PUx9HC/Vl/KX+zT/vAEZj7+fkphQNrAW6BGN9Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778763355; c=relaxed/simple; bh=7MO+viv0Drmea5H6MB7PQANdLGtoGY5gKTupsWDC7T8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=J2DNkKFewY1kkBxsgaAnHVSZ4EgCNNLUqouPtb7DFt+9t6qTXw4iVvsmmOQ8D+xlud05ACPbT7rnWn8ns2aKPPUZ0GubKdip9iZWK1xwgBIz3aLUN7h4hIM885UX4mvkYtgKYMtUqk71OHAktILP1QNp06jgK8AZSuJQOGVsyQw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=bcHCl4ex; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=LQQVWzrv; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=bcHCl4ex; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=LQQVWzrv; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="bcHCl4ex"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="LQQVWzrv"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="bcHCl4ex"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="LQQVWzrv" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 69BB75E602; Thu, 14 May 2026 12:55:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778763352; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VfVFNZb3El+hrHtQNU1Y6JLVk6/Ck4WJss/xNizlNlA=; b=bcHCl4exCtlfVlNRp78GBAHMYl5f+jeLIAndkssvHhgd2axPxnM7jDmAIPHuhgie58z+n+ X+Hl9zLfzdJBEWBWCnlenUyedl2bXxfDI/qz5qJMKlWC8NZ91JAJEJueP8KoiV4zsLmHTt dEgnmmLNVsgaZAM+aT3tB1xAiTshtRE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778763352; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VfVFNZb3El+hrHtQNU1Y6JLVk6/Ck4WJss/xNizlNlA=; b=LQQVWzrv6+wK5YepUb4BkPvQy3GAq1AweRsNmGbw0zzTYgUj0vADYTjuK+nQUU1iEJRvYi 4RVXNTLrzqwTRcBg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=bcHCl4ex; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=LQQVWzrv DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1778763352; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VfVFNZb3El+hrHtQNU1Y6JLVk6/Ck4WJss/xNizlNlA=; b=bcHCl4exCtlfVlNRp78GBAHMYl5f+jeLIAndkssvHhgd2axPxnM7jDmAIPHuhgie58z+n+ X+Hl9zLfzdJBEWBWCnlenUyedl2bXxfDI/qz5qJMKlWC8NZ91JAJEJueP8KoiV4zsLmHTt dEgnmmLNVsgaZAM+aT3tB1xAiTshtRE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1778763352; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VfVFNZb3El+hrHtQNU1Y6JLVk6/Ck4WJss/xNizlNlA=; b=LQQVWzrv6+wK5YepUb4BkPvQy3GAq1AweRsNmGbw0zzTYgUj0vADYTjuK+nQUU1iEJRvYi 4RVXNTLrzqwTRcBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id F3F4F593A9; Thu, 14 May 2026 12:55:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 80lWOFfGBWo+UAAAD6G6ig (envelope-from ); Thu, 14 May 2026 12:55:51 +0000 Message-ID: Date: Thu, 14 May 2026 14:55:43 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v6 2/2] net: hsr: reject unresolved interlink ifindex To: luka.gejak@linux.dev, netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, fmaurer@redhat.com References: <20260513182657.20346-1-luka.gejak@linux.dev> <20260513182657.20346-3-luka.gejak@linux.dev> Content-Language: en-US From: Fernando Fernandez Mancera In-Reply-To: <20260513182657.20346-3-luka.gejak@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Level: X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCPT_COUNT_SEVEN(0.00)[7]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email,suse.de:mid,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,linux.dev:email]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: 69BB75E602 X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spam-Flag: NO X-Spam-Score: -4.51 On 5/13/26 8:26 PM, luka.gejak@linux.dev wrote: > From: Luka Gejak > > In hsr_newlink(), a provided but invalid IFLA_HSR_INTERLINK attribute > was silently ignored if __dev_get_by_index() returned NULL. This leads > to incorrect RedBox topology creation without notifying the user. > > Fix this by returning -EINVAL and an extack message when the > interlink attribute is present but cannot be resolved. > > Assisted-by: Gemini:Gemini-3.1-flash > Reviewed-by: Felix Maurer > Signed-off-by: Luka Gejak Reviewed-by: Fernando Fernandez Mancera Thanks!