From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C4452F8E9C for ; Fri, 8 May 2026 14:57:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.196 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778252224; cv=none; b=g9mCHa4sDpCXAhx5s+6yzgFfkVz9OxYbv6EgIUyIDVe74mOdCduAgXHyBCu+GhFWaJejKUXUkOsblfxn7WtDaCZXB0nnuaVVAhq/wefvCjNNtH8xAEdIf7R9cLmdNuaXrb3iRUXL2yexW/suyEudK22X5s/DBGA0Z6SKgRG5AfE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778252224; c=relaxed/simple; bh=4/aVJnWaXKkXi45aVG/ghAkKHKmtNlgv64ubRDm3pNY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fZfWf97Vlwb2aSAcdYZkx+XyuhrPq/+ZKdXuCewl8gOj8GkDqHDwF6wJ7Dj+gep3pbjcQTNaWD1J5s90uPbagKRs5hoXOvr2zNUary+OyKGv0TKYhgzQv0rTMZiGFu2jJ4Zsivq05CI+jFVtIUe+YkgaqFyD82d9Zt5zNfreSkw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A3bMKqn/; arc=none smtp.client-ip=209.85.210.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A3bMKqn/" Received: by mail-pf1-f196.google.com with SMTP id d2e1a72fcca58-83537a80ab6so1351123b3a.1 for ; Fri, 08 May 2026 07:57:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778252222; x=1778857022; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MKeh4P5RRX9HdRzyfTHqYV6PxblA4dDzAyEahLUA+Ik=; b=A3bMKqn/Gk8Irboq+VjkYR/RT3AMkP+uqrEWN1i6QzdfkjeKQeFGPEHxQOcNgVVCfb 3BHfxwMeebOqbTkfNMbfaMt3dOOPBVmScJUowDz5LrgnEGB8ZWSB0vIJPKwqzkUk+Xek bOrlfoBKysN3MkFH5GCsFBGcnSxFY1DeVT+6QWI8MmY4PAhaWQRyJY1F8lIguVJv1BYn iwUUi2jv4WoQmeH8e5HLfsPdIEzbhIzTBE+wQrRzt+RT4vM3myf2jEOZSsZ7+pkrET1x 8aa0PJk9TPozZc9utIvBCoaExaFcJieMoMI/sY4H1CgAacVTRrL9XW0vdmBUeAfVOzco /pww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778252222; x=1778857022; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MKeh4P5RRX9HdRzyfTHqYV6PxblA4dDzAyEahLUA+Ik=; b=c2Z7Z9jsqsRTwFjVs/LR+gpV0tqgjJMCd+OaaKIv5Qt7BMisUAp663v9cecarLDMs2 bYzpgUT7edYig8EdT8y7spFLd9LUjeDikE9SPWZiRHHA15KXu3cUud4CwssLlit3gOQ3 r68lwhJ1e1wyt80BlUniLa24bMVX5ukZ8atuTVY+vVCCvRjs46maEzy6FMIemPNPKWBx vu0a/5jC83NUx87O7NKrV+PB6k2Np0x9V8Y7zB8r7stR3zKFHsIPnTGtE7t2Fl2Yg67Y Rb0yds+IKdt14nYyoUotMTEHtPAtiL+tX+2dhWcIHehw7shIdjeAxVYZQAv535x28F0D XE1Q== X-Forwarded-Encrypted: i=1; AFNElJ+I6zUqbs5Fo4LSEoWkSCFBFMsqsPhR2yzGNQuBqLQY/W3UvieSCFVIPP6TCysGhlqW704G+l0=@vger.kernel.org X-Gm-Message-State: AOJu0YzH+13KUhqpcwzTt3IC+4XSn2v1j5dHILo9zvEWtYYPbhcPDf7j LDbe6cB4H8HwN/istAl95jwUWtr9MYyNiLJddOSf/yG8/BGYNv3zUq9x X-Gm-Gg: Acq92OEsHagGcFMMrNaPBqC4Jrodop4468wRM3eg9CUjmv/oq/659302F9MGUBaRX9e W275EmuZD7IUrlJYFwi2u+LAEAOtoclzF9x856ajufBHZ3nTJ2VFn2Yp7oS850X9fZ9DMSARTGW LJbOkX1A5BG23O8kH25shpC0jggRtPp0z1XNFCr3KXn/3SH8319lQ9t6GdEUYD55jUt8XVV1fp3 9Qte8NIDNYOtG+mwEU4m1i7cZwaQqJTa7zhjIPFyscvxjKCdvmRDdONdRkksj8NevO0iNQF6TdB +46LxS+AXZKTEJPxObEgcz5I3tkrc+xfIiyKr6eyPQOxkRYimWGZpOUAWMh2pcHa09SuIHgpsTX VqNCEVX6sZrBFTx4n0jnuYoNJrtidU6cPcrjX5ju9KOtw1RLkokIzpy9sztdqnfdkWDmLMBOqJ8 isaoVpzflnIcTHYXt+ X-Received: by 2002:a05:6a00:4195:b0:824:374a:1407 with SMTP id d2e1a72fcca58-83a5c4bd711mr13683272b3a.16.1778252221575; Fri, 08 May 2026 07:57:01 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:72::]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-839659498f1sm16492392b3a.17.2026.05.08.07.57.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 07:57:01 -0700 (PDT) Date: Fri, 8 May 2026 07:57:00 -0700 From: Stanislav Fomichev To: Bobby Eshleman Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Shuah Khan , Alex Shi , Yanteng Si , Dongliang Mu , Michael Chan , Pavan Chebbi , Joshua Washington , Harshitha Ramamurthy , Saeed Mahameed , Tariq Toukan , Mark Bloch , Leon Romanovsky , Alexander Duyck , kernel-team@meta.com, Daniel Borkmann , Nikolay Aleksandrov , Shuah Khan , dw@davidwei.uk, mohsin.bashr@gmail.com, willemb@google.com, jiang.kun2@zte.com.cn, xu.xin16@zte.com.cn, wang.yaxin@zte.com.cn, netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, Stanislav Fomichev , Mina Almasry , Bobby Eshleman Subject: Re: [PATCH net-next v3 2/8] net: netkit: declare NETMEM_TX_NO_DMA mode Message-ID: References: <20260507-tcp-dm-netkit-v3-0-52821445867c@meta.com> <20260507-tcp-dm-netkit-v3-2-52821445867c@meta.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260507-tcp-dm-netkit-v3-2-52821445867c@meta.com> On 05/07, Bobby Eshleman wrote: > From: Bobby Eshleman > > Some virtual devices like netkit (or ifb) never DMA and never touch frag > contents, they just forward the skb to another device. They are unable > to forward unreadable skbs, however, because they fail to pass TX > validation checks on dev->netmem_tx. The existing two-state > NETMEM_TX_NONE / NETMEM_TX_DMA doesn't give the TX validator enough > information to differentiate devices that will attempt DMA on the > unreadable skb from those that will simply route it untouched. > > Add a third mode to the enum so drivers can indicate 1) if they have > netmem TX support, and 2) if they do, whether they are DMA-capable: > > NETMEM_TX_NO_DMA - pass-through, device never DMAs > > Widen dev->netmem_tx from a 1-bit field to 2 bits to fit the new value, > and declare netkit as NETMEM_TX_NO_DMA. Devmem TX support over these > devices comes in a follow-up patch. > > Signed-off-by: Bobby Eshleman Acked-by: Stanislav Fomichev