From: Markus Elfring <Markus.Elfring@web.de>
To: Maxim Petrov <mmrmaximuzz@gmail.com>, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Alexandre Torgue <alexandre.torgue@st.com>,
"David S. Miller" <davem@davemloft.net>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>
Subject: Re: [PATCH v2] stmmac: fix pointer check after utilization in stmmac_interrupt
Date: Mon, 4 May 2020 17:42:24 +0200 [thread overview]
Message-ID: <af38eb97-d734-3911-2f5d-eb666deaad7e@web.de> (raw)
> … However, the code fragment is incorrect
> because the dev pointer is used before the actual check
I find such information interesting.
> which leads to undefined behavior. …
I suggest to adjust the wording for this “conclusion”.
Regards,
Markus
next reply other threads:[~2020-05-04 15:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 15:42 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-04 6:26 [PATCH v2] stmmac: fix pointer check after utilization in stmmac_interrupt Maxim Petrov
2020-05-04 17:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af38eb97-d734-3911-2f5d-eb666deaad7e@web.de \
--to=markus.elfring@web.de \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=joabreu@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=mmrmaximuzz@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox