From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A1023FB7F1 for ; Fri, 8 May 2026 15:15:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.193 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778253349; cv=none; b=WkmNl5tTGWk6SoBtz3wdcxevoinnUd+ljgCcftU+uDs1++Jh0N45p9CW4EQqHaTj3rqhkdk5wuMDlJ/3VGf3c7b+yTw+55rS+Y9qf7p5wJ9wV78sqpNrtoEF8cPxiXbPejO/tRiiBe45g7CD6MHFbKiBiKEiST4upDcaOilLWgU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778253349; c=relaxed/simple; bh=QTCFy54J5oT0q57ktVfbNPWs/6RQUoT+/yIYyo5bzkQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PTgP1ab8OjrPTHWGNtXbveeW19VkRxb3TeBHYCxMVhYk9P/F+1LdM/QrXhqhwxnUWX3gshn5uGSH60of56dADaqggKvpmAKN4MEeWPwX7tNiJwl7wvCnXrttD362TR/BeZ+ocAhQRI8wJKLwgmlhQKe51soj+LPZ5tMoWY/5D/0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ir6HEYxu; arc=none smtp.client-ip=209.85.214.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ir6HEYxu" Received: by mail-pl1-f193.google.com with SMTP id d9443c01a7336-2ad4d639db3so11372435ad.0 for ; Fri, 08 May 2026 08:15:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778253346; x=1778858146; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Oaliql9sqskgI8tL8intOqmIn9GbCLcLJL3l5R2zxMM=; b=Ir6HEYxuF1jD8KFdAzUHcMEimZ1BXDVOpgBTRRLDBQirqFxoxf361jYpidJsQ9+zk6 0uDJWJWY85YTTLH/YGn9IV9VY4EYlStRliUCAjGUoUNZoN/kQXEQmEzmNtQnOIlrsXCb LtGV/5HRS8STmeFefz6uu1yy/7PgnHL3j+NUs8AjFq9LzR+6AllyiO+36ADvCT/VtGVw bzK26DRnZvGWCWohogjVOanoEIDlqvnjmgR6SbCf2NeI38l2N2xa3J8tBFuNsj+C9HTp xmYjgEl5XpBBj/F+PUBsvlx1Npiq4FILa+ZpSV73OE1v3nnqIR3JOSCzWOEZypYGhlNM nlmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778253346; x=1778858146; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Oaliql9sqskgI8tL8intOqmIn9GbCLcLJL3l5R2zxMM=; b=B8OcVQR9jCakgUnGXmEvaZLi3R8GdoF7Y4JwctDb5mVCG1pfkz1lRYTrWPNIbbDG2s 70whIJCVMSMnTxpHHlAtqZglft2UcRN2wf63Af4jz5Cjsbl/KuuwYHptkQ3OUH5X/Dbd 19lTXmIX5z4e3SpA6XRjjREqmZ5Erqqh0ty8QBHdBAvKlidbqMT7dakIMbxGGFHAtCW8 sMK3Yj3GPeILNW76QICAdRbhZvpo3AWdws+J/IiQFJBvjJ4kAwkbGQOLslWr9FYQ0d1Y pyZ18AlZTQ1llHV2kVAnUt5ALU4ujzNqfBD89EY4BaId8Mz5+wrFcvAGEpA4JLJM0yQJ 9twQ== X-Forwarded-Encrypted: i=1; AFNElJ8xjK6VkCnPKOqoWdgEMPNqeTI5W03+Wzn+SNv3s5I8qOVRu8rcoIANsn8Bhoax/Hz1wT3yprY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxm0WFj9Zq2awFUDRGQz2YUugfp/RZLxb04+pYpADk3zjx8NH1D myjbIj8X/CjenXbKvNloAAMf9yQA/fcO985SHX4skXYs3cGsZTnOcV43 X-Gm-Gg: Acq92OGr1Cqv9vKW709UT/yuVEIKveYPq8/Iisz665rrhXaFs73j6KaXiCPXVwnpFo9 luDU6uFXAu4GM9Pu+VEKBMSqLYN6HZpzVjDzO3h7tPaKu3bT6Fq6ocNpoMwsTQ/Jjgji9vcsgkv bUJpx9myuQwpDcL0aTFyBGrNXumjL2CNOrtBA1uGq1P6xyNCOzuHbLDhREb1YUyPOSKNelJ7vf9 XAo9kqklfDKtt1QBzjNksT+6iVNq4B7Ym1pD+0K0wNqKTooZMhGA9/aiD+X2/pPf7/8rg7Liglh hn3V7ipCDstclCqnKVLC672xEwQ/2BDt7PLSV0emwQp/NaYSzq6XFph7MqG/chC/UX1EaMSL3JQ vn4wgLDZXjyeofCAMXp5ssALtPm+B0/e/Blku+GiRXasaQ3PeZ/EXkNc8E+0hUHuf+Xt351/59G v6eJX+ZQtDI25dyoyx0xqK/asQ29o= X-Received: by 2002:a17:902:8b84:b0:2b4:6d92:b002 with SMTP id d9443c01a7336-2ba7a343404mr94812295ad.37.1778253346416; Fri, 08 May 2026 08:15:46 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:72::]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1ec232esm26222665ad.81.2026.05.08.08.15.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 08:15:45 -0700 (PDT) Date: Fri, 8 May 2026 08:15:45 -0700 From: Stanislav Fomichev To: Kuniyuki Iwashima Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Kumar Kartikeya Dwivedi , Yonghong Song , John Fastabend , Stanislav Fomichev , Eric Dumazet , Neal Cardwell , Willem de Bruijn , Tenzin Ukyab , Kuniyuki Iwashima , bpf@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v1 bpf-next 3/8] bpf: tcp: Support bpf_skb_load_bytes() for BPF_SOCK_OPS_RCVLOWAT_CB. Message-ID: References: <20260508073355.3916746-1-kuniyu@google.com> <20260508073355.3916746-4-kuniyu@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260508073355.3916746-4-kuniyu@google.com> On 05/08, Kuniyuki Iwashima wrote: > When a TCP skb is queued to sk->sk_receive_queue, BPF SOCK_OPS > prog can be called with BPF_SOCK_OPS_RCVLOWAT_CB. > > In this hook, we want to parse the RPC descriptor in the skb > and adjust sk->sk_rcvlowat based on the RPC frame size. > > However, we cannot access payload via bpf_sock_ops.data on > modern NICs with TCP header/data split on as the payload is > not placed in the linear area. > > Let's support bpf_skb_load_bytes() for BPF_SOCK_OPS_RCVLOWAT_CB. > > Two notes: > > 1) bpf_sock_ops_kern.skb will be NULL when the BPF prog is > invoked from recvmsg(). > > 2) Access to bpf_sock_ops.data will be disabled by passing > 0 end_offset to bpf_skops_init_skb(). > > Signed-off-by: Kuniyuki Iwashima > --- > net/core/filter.c | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/net/core/filter.c b/net/core/filter.c > index 5fa9189eb772..94d07a15b2ab 100644 > --- a/net/core/filter.c > +++ b/net/core/filter.c > @@ -7718,6 +7718,38 @@ static const struct bpf_func_proto bpf_sk_assign_proto = { > .arg3_type = ARG_ANYTHING, > }; > > +BPF_CALL_4(bpf_sock_ops_skb_load_bytes, struct bpf_sock_ops_kern *, bpf_sock, > + u32, offset, void *, to, u32, len) > +{ > + int err; > + > + if (bpf_sock->op != BPF_SOCK_OPS_RCVLOWAT_CB) { > + err = -EOPNOTSUPP; > + goto err_clear; > + } > + > + if (!bpf_sock->skb) { > + err = -EPERM; > + goto err_clear; > + } > + > + return ____bpf_skb_load_bytes(bpf_sock->skb, offset, to, len); nit: wondering whether it's better to use __bpf_skb_load_bytes (which wraps BPF_CALL_4's ____bpf_skb_load_bytes) here? Seems a bit less magic and used already by dynptr?