From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: [PATCH 2/2] tipc: Improve a size determination in two functions Date: Wed, 8 Nov 2017 22:35:31 +0100 Message-ID: References: <25790616-164d-fe3e-bda4-3155299a8171@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: LKML , kernel-janitors@vger.kernel.org To: tipc-discussion@lists.sourceforge.net, netdev@vger.kernel.org, "David S. Miller" , Jon Maloy , Ying Xue Return-path: In-Reply-To: <25790616-164d-fe3e-bda4-3155299a8171@users.sourceforge.net> Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Markus Elfring Date: Wed, 8 Nov 2017 22:23:07 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- net/tipc/server.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/tipc/server.c b/net/tipc/server.c index 7359d37e39cd..5d001b6acbe5 100644 --- a/net/tipc/server.c +++ b/net/tipc/server.c @@ -219,7 +219,7 @@ static struct tipc_conn *tipc_alloc_conn(struct tipc_server *s) struct tipc_conn *con; int ret; - con = kzalloc(sizeof(struct tipc_conn), GFP_ATOMIC); + con = kzalloc(sizeof(*con), GFP_ATOMIC); if (!con) return ERR_PTR(-ENOMEM); @@ -410,7 +410,7 @@ static struct outqueue_entry *tipc_alloc_entry(void *data, int len) struct outqueue_entry *entry; void *buf; - entry = kmalloc(sizeof(struct outqueue_entry), GFP_ATOMIC); + entry = kmalloc(sizeof(*entry), GFP_ATOMIC); if (!entry) return NULL; -- 2.15.0