From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Byungchul Park <byungchul@sk.com>, <netdev@vger.kernel.org>,
<kuba@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <kernel_team@skhynix.com>,
<harry.yoo@oracle.com>, <david@redhat.com>, <willy@infradead.org>,
<toke@redhat.com>, <asml.silence@gmail.com>,
<almasrymina@google.com>, <przemyslaw.kitszel@intel.com>,
<andrew+netdev@lunn.ch>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>,
<intel-wired-lan@lists.osuosl.org>
Subject: Re: [RESEND PATCH] ice: access @pp through netmem_desc instead of page
Date: Thu, 26 Feb 2026 10:13:14 -0800 [thread overview]
Message-ID: <af90b7e6-de47-485d-9e1b-31612456ef9c@intel.com> (raw)
In-Reply-To: <20260226010811.GA16777@system.software.com>
On 2/25/2026 5:08 PM, Byungchul Park wrote:
> On Tue, Feb 24, 2026 at 02:35:46PM +0900, Byungchul Park wrote:
>> To eliminate the use of struct page in page pool, the page pool users
>> should use netmem descriptor and APIs instead.
>>
>> Make ice driver access @pp through netmem_desc instead of page.
>
> Hi Tony and Przemek,
>
> Is there something that I'm missing or something wrong with this? Your
> feedback would be appreciated. Thanks!
Hi Byungchul,
Nothing wrong. I plan to apply it today.
Thanks,
Tony
> Byungchul
>
>> Signed-off-by: Byungchul Park <byungchul@sk.com>
>> ---
>> drivers/net/ethernet/intel/ice/ice_ethtool.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c
>> index c6bc29cfb8e6..c16e54dbe75b 100644
>> --- a/drivers/net/ethernet/intel/ice/ice_ethtool.c
>> +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c
>> @@ -1251,7 +1251,7 @@ static int ice_lbtest_receive_frames(struct ice_rx_ring *rx_ring)
>> rx_buf = &rx_ring->rx_fqes[i];
>> page = __netmem_to_page(rx_buf->netmem);
>> received_buf = page_address(page) + rx_buf->offset +
>> - page->pp->p.offset;
>> + pp_page_to_nmdesc(page)->pp->p.offset;
>>
>> if (ice_lbtest_check_frame(received_buf))
>> valid_frames++;
>> --
>> 2.17.1
prev parent reply other threads:[~2026-02-26 18:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 5:35 [RESEND PATCH] ice: access @pp through netmem_desc instead of page Byungchul Park
2026-02-26 1:08 ` Byungchul Park
2026-02-26 18:13 ` Tony Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af90b7e6-de47-485d-9e1b-31612456ef9c@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=almasrymina@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=asml.silence@gmail.com \
--cc=byungchul@sk.com \
--cc=davem@davemloft.net \
--cc=david@redhat.com \
--cc=edumazet@google.com \
--cc=harry.yoo@oracle.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kernel_team@skhynix.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=toke@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox