From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 101DB39A049; Tue, 28 Apr 2026 07:10:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777360236; cv=none; b=av71NH/u8wHneighhMhkmfjrhPh+jWgzw53jUE2lA56ky8QrV/+ALpDdHDhOaggPYi5MwpCBmdiygAUbSYCnpysyJyVK1mEQ3NCkRxPTnQjpUoGcUYiazU5l4dXH6tvTE/Ocwj+A/YMRAtVTlgu2WWfV6n9VOKBmqRWBADGE2ao= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777360236; c=relaxed/simple; bh=X/LMtGLsAI98KpSAX0nwBX/szOSGt8ghowDeNGWHy9w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PJKtP4OST241h86/gE2YVnioYpPTXfTgLt9EpEhdRINlAI9JwD1QY+0SKy+zJmjFQgSzno29aoEQnosOM1bGV5ZfKYdarnV08iKIKq8uvM0xF41z1vI5Zf89o9I1mNJ/8px8kbETxcrEjG1KQaPhAZbW0P0+9b+XCby5hXgG9tc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=f4xJxPnq; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="f4xJxPnq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777360234; x=1808896234; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=X/LMtGLsAI98KpSAX0nwBX/szOSGt8ghowDeNGWHy9w=; b=f4xJxPnqOOjTKIvaiPGB6pHrYvEWO4yXkcteqRVtUluMDxppSp5tOLnw 2KgsWY6UoBmYCQ19SSw98sw4t2du3B3KengqB71mRjM3HkdSQzjETJORk rOD6OYHl/elnjkgVwFeIg+9kO829Hx4l7O54aII3DLOWuPueIB4yaO0CW OcyA42McGjN9ma56K43zghu4ROXZ8MTRxnnuOxkbA4vZOxpmokMdkBdNF 9WjyeR4KpdorfbVgedEbJK4xE9gUzntvMbJqjodIG25ybtEXMgE5LhP1b H6n4W1wjghtluxi0TMKHZb04bfyk6IqXX9JpTK5EmUE/bN5e2pPaJzAGi g==; X-CSE-ConnectionGUID: CSbc6oE4T3KR5bp7jStLDQ== X-CSE-MsgGUID: WHDjQXjcTWaFMQZovvK4UA== X-IronPort-AV: E=McAfee;i="6800,10657,11769"; a="95674680" X-IronPort-AV: E=Sophos;i="6.23,203,1770624000"; d="scan'208";a="95674680" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2026 00:10:33 -0700 X-CSE-ConnectionGUID: lVSkmhXlQ/mFlOhxzX6tFQ== X-CSE-MsgGUID: tuF8HfU7RNWOHPfANBcGjg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,203,1770624000"; d="scan'208";a="234150595" Received: from kniemiec-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.213]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2026 00:10:25 -0700 Date: Tue, 28 Apr 2026 10:10:22 +0300 From: Andy Shevchenko To: Yury Norov Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Jonathan Cameron , David Lechner , Johannes Berg , David Laight , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Ping-Ke Shih , Richard Cochran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Belloni , Yury Norov , Rasmus Villemoes , Hans de Goede , Linus Walleij , Sakari Ailus , Salah Triki , Achim Gratz , Ben Collins , x86@kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v2 7/9] wifi: rtw89: switch to using FIELD_GET_SIGNED() Message-ID: References: <20260427214127.406067-1-ynorov@nvidia.com> <20260427214127.406067-8-ynorov@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260427214127.406067-8-ynorov@nvidia.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Mon, Apr 27, 2026 at 05:41:24PM -0400, Yury Norov wrote: > Switch from sign_extend32(FIELD_GET()) to the dedicated > FIELD_GET_SIGNED() and don't calculate the fields length explicitly. ... > for (i = 0; i < ADDC_T_AVG; i++) { > tmp = rtw89_phy_read32_mask(rtwdev, R_DBG32_D, MASKDWORD); > - dc_re += sign_extend32(FIELD_GET(0xfff000, tmp), 11); > - dc_im += sign_extend32(FIELD_GET(0xfff, tmp), 11); > + dc_re += FIELD_GET_SIGNED(0xfff000, tmp); > + dc_im += FIELD_GET_SIGNED(0xfff, tmp); In the same driver the GENMASK() is being used, why not doing it here while at it? > } ... > for (i = 0; i < ADDC_T_AVG; i++) { > tmp = rtw89_phy_read32_mask(rtwdev, R_DBG32_D, MASKDWORD); > - dc_re += sign_extend32(FIELD_GET(0xfff000, tmp), 11); > - dc_im += sign_extend32(FIELD_GET(0xfff, tmp), 11); > + dc_re += FIELD_GET_SIGNED(0xfff000, tmp); > + dc_im += FIELD_GET_SIGNED(0xfff, tmp); > } Ditto, and it even looks like the same piece repeating twice in different compilation units of the same driver... -- With Best Regards, Andy Shevchenko