From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C139824E4C4; Tue, 28 Apr 2026 14:13:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.12 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777385589; cv=fail; b=aci80V6bWbbztPruN3xOE469uX9z7Ek0mhx4/D35rMwkLfZUxMs3Ag+qOYju8WQvPfJDZLtaKsJOP5CSgwCU2QKE4prVpgnwzDMebuWw23W2fLkCLH5TS6DpUefkg6YF4bKW5tRTJR0h/jMTZge2IBMPQdu6Q5dP7QpH9pVFEP4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777385589; c=relaxed/simple; bh=sw2GrklNIam5lUUj1Qt8/kRC3kcDu/wm1ToCXpfJ3fE=; h=Date:From:To:CC:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=sz2WDD2aPV2d3AsPn7yGNtjYziMox0iWGhLSzyu6eEse8w09/QU1/YIeWIYgkuJvsvBxoo2BfF1hM5gIq+S3geP7YLZB8XraYDBzqhA5RJnsQj04yhmpXvwszHSRl9hpMjL2E5On7Oc7jEbeGrRm9AcWlgFUy7q9SGqG4eBoe/o= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=U+MlwoLV; arc=fail smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="U+MlwoLV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777385587; x=1808921587; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=sw2GrklNIam5lUUj1Qt8/kRC3kcDu/wm1ToCXpfJ3fE=; b=U+MlwoLVC5mMfilCt8C8xtGzjZQNc6Y3MPpDOW7Y95wUmNsRF5Z5DmS/ gqeD0Qd+W2rF0XdZ0DEOqgMM/MwT02X8MOUq73MBTqxfrm951G/ZrQ9Mc +XPlXrXtFkr72lCDMxNK26Mwsx1H4IwiBSw+vCLw4YbR3+fV26cx5KWGM oBUjLHcerrxmeDAKlPJZGH/t4ykPHWqSg6pDDcg3+ezaICJUBQKTI7PW3 f+3pw2+c1plUMpTEcmTn/fS46LFPDHivqcyQXm88nBFZuzSm7cTbDJLpM byalZ9WFzchzRqMFSaRFy0CoRjM/KuIp9n95DAx//jHkFvmCnVjeJiuhI A==; X-CSE-ConnectionGUID: y+0Q6TSYStq5wlsQyklppw== X-CSE-MsgGUID: uP4HicSoQX6HcvlGyc2tmw== X-IronPort-AV: E=McAfee;i="6800,10657,11770"; a="89755714" X-IronPort-AV: E=Sophos;i="6.23,204,1770624000"; d="scan'208";a="89755714" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2026 07:13:07 -0700 X-CSE-ConnectionGUID: C5cyhmynRnuC7Kx8C6yv0Q== X-CSE-MsgGUID: lPdicSLXSBGjW8in9Znwkw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,204,1770624000"; d="scan'208";a="227442929" Received: from fmsmsx902.amr.corp.intel.com ([10.18.126.91]) by fmviesa009.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2026 07:13:07 -0700 Received: from FMSMSX903.amr.corp.intel.com (10.18.126.92) by fmsmsx902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 28 Apr 2026 07:13:06 -0700 Received: from fmsedg901.ED.cps.intel.com (10.1.192.143) by FMSMSX903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Tue, 28 Apr 2026 07:13:06 -0700 Received: from SA9PR02CU001.outbound.protection.outlook.com (40.93.196.26) by edgegateway.intel.com (192.55.55.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Tue, 28 Apr 2026 07:13:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KVNIpw86IFZfujHiNKXjzAmB7tkUMYEoItV0YT1bacxh9p1jgDXE6f3fJ1A0CyI7YyD2eysPK/+2lLJH/IGuMSMvq/2nZufI+pUZwnBMVOD8aeMVcderhr/cSj4Z2aX5scN3Oo4YHATNEd0yWQvgq7uCErrna0FFqTUvme5E/XG5FLDCscbQA8PlkJdGcPWoorsvSPqBVpNxDhMg9rfswYWb4JEEXNicyLZAGuFfNlLp+l6jZtHSEv+HARMnoqPThL3ltPIwB5irh6DLw/7YdbpR4axP5ZYCEjCgmjWOQoG6jGvVNsYswVx1N4UtSOBcVb2StE2EE0eesUnFuB6flg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z7Fiqubad4icQ51WnV2eW3jKgbDW4CQwV64Y3AB9Ygc=; b=Y1wMOhSGVgkEKalFOzLQJ5O7cVpzFb2ZpslGU9QW08ScKQKcsrMczsloSQrIa9CCatV+jKl/vVOMJReTW+giIrJCcNn/N8JVyL/nekGHrGC4xrVxPQ2fSwKuFY5U7MOPBE3Z5jBQQUk10yFZ5brL6ObBifoaqPXGo22a2areoNnd3mboHx0Ovl2RyNIFaUO/wiMxi7J/BT25oGDyvzAoaVgcp6otXDPNkE7N5Ix/EW3omOCI1t/b1HH8Y0uRBK5eRQbKTvlZJ4kEIEAtV5V9Dpu29Aks7FOEm2Tc6L/uBV/Mvt9kcBoEdVmYvG1bqCXRIHxrmmmgWC86VHF1kNG3ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DS0PR11MB7529.namprd11.prod.outlook.com (2603:10b6:8:141::20) by SAWPR11MB9781.namprd11.prod.outlook.com (2603:10b6:806:4c9::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.17; Tue, 28 Apr 2026 14:13:04 +0000 Received: from DS0PR11MB7529.namprd11.prod.outlook.com ([fe80::1289:ce98:2865:68db]) by DS0PR11MB7529.namprd11.prod.outlook.com ([fe80::1289:ce98:2865:68db%2]) with mapi id 15.20.9870.016; Tue, 28 Apr 2026 14:13:04 +0000 Date: Tue, 28 Apr 2026 16:12:50 +0200 From: Larysa Zaremba To: "Loktionov, Aleksandr" CC: "intel-wired-lan@lists.osuosl.org" , "Nguyen, Anthony L" , "Lobakin, Aleksander" , "Samudrala, Sridhar" , Michal Swiatkowski , "Fijalkowski, Maciej" , "Tantilov, Emil S" , "Chittim, Madhu" , "Hay, Joshua A" , "Keller, Jacob E" , "Shanmugam, Jayaprakash" , Jiri Pirko , "David S. Miller" , Eric Dumazet , "Jakub Kicinski" , Paolo Abeni , Simon Horman , Jonathan Corbet , Richard Cochran , "Kitszel, Przemyslaw" , Andrew Lunn , "netdev@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "R, Bharath" Subject: Re: [Intel-wired-lan] [PATCH iwl-next v7 13/14] ixd: add the core initialization Message-ID: References: <20260428082654.44364-1-larysa.zaremba@intel.com> <20260428082654.44364-14-larysa.zaremba@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: VI6PEPF00000232.AUTP296.PROD.OUTLOOK.COM (2603:10a6:808:1::8fc) To DS0PR11MB7529.namprd11.prod.outlook.com (2603:10b6:8:141::20) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR11MB7529:EE_|SAWPR11MB9781:EE_ X-MS-Office365-Filtering-Correlation-Id: 36903804-4fd0-4b9c-5c65-08dea530433c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|366016|1800799024|7416014|376014|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: M5TQ8FjdpAmNQnn+949Za8C2nVMOenmmBNH4Yg48VeaGacUziZHV75/qhqa93FlxeP6lUaB+vu9v+nwqDcMZLuFHLnZytow4ccHXXf8cVBW0b7YPrqRp+kZBAam4xnJykTfpDovRTtul0iyXeN78nkbEEMqf+7U+JYCj5VObOusduMEX3OPM504F4NxVUCGlZOI7Gb3/rWNWzOukyDZNC+1fVpulvme+P0K8fiP4/yvU1KJLELM1zF91sAi6QofCRVk3EFUdesokh45DCYrbOayvE4+SdIgLz8ulHQD/Zs2YNWPSmw71Y8MmGJ18Kn/v4ncEmEPDnBw8ObREAzwuGY07QeCQin191Zz4JzZGiWi/uhD3Dawf2QFRXA8Dpj4pH+YEze+z8wdEz2HWgjahT/B0U2F8x17c3dHPZsAJA79q7UMIqQWXbA6BxGDoVjA8YGhzgQfEDAKkNNvG9sx9l3b5XNRt9jslfWiOTK8f5V1OIP176qad29uqZcZc0a+W4nkH2VOh0plWSY/tpvjGsORB5kAnDAbuAbhPEYF0ChE5N4aiHjowb42qV85EhgOFQADSuEaTk3xVmnMUb2XXEvZ2UreKOK0El759L1E22+lbW6lo7T/zyRVD4hsqAbbIJtt2N1YTKUcj4CbO38MUd5V0jC/RuU0qe8B4tLoXE4GsZuHQF6org1abIGnHvlaMZnFIDKXJ9f14XH5gAeMdij8RxqWTbDTn+TEIot/Pk04= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR11MB7529.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(366016)(1800799024)(7416014)(376014)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?w1sHir+/GnwNBpsLVdMsPaP39Hwc94ix9JJE7MPKclfW/dySIfFLIuQU0gpf?= =?us-ascii?Q?uOdeTzqWDGNvx9CZNCkLWeRoks+MAOVIzVPg0lt1Pc/zMVqaQ2bLglX0F7WK?= =?us-ascii?Q?GnwMY8X6dE2KOO0+I+p6CCTcQ+ltZE1YrdRnwDZ0tVgAGcJa99DE0Ay7j9Tu?= =?us-ascii?Q?o9L0N2SrdCM6tcJ+0F90nTgcO2pDOfssH6V6PtgGiiTlLbDyrdXXhqtI0R+6?= =?us-ascii?Q?x08pp/bmszcPpeur9d1rmZAQO+7zilGinLyogGioeGGxOHLIrENPzu0ZQKwd?= =?us-ascii?Q?N43BO7NSkAbnCxhZDM3rK0QCAWv9FRl07/MkHE9hEmTDoo1nuj1p714UU3ka?= =?us-ascii?Q?CWXWhNn/rQADLVLlkYxoxcGxgp1FxX59YEl95RV7SpwegYpuPykhraMR5qnZ?= =?us-ascii?Q?chIwvxJkFo9erenu6risl3IzYJnVHgHcTdCYnqFI4jSj0Vtm9DvVGlnb7zXB?= =?us-ascii?Q?+hJBM4ducTeJGvnPnd6h0/j3N5wcFUQsLCaT2HF56yw7ZcynXU95gJTPIP8a?= =?us-ascii?Q?ukBnnzL1HOQ5zyjjoEL02ybeRKm7KuzYW9OVuoTtqLb4c9kanPjMJT25lO61?= =?us-ascii?Q?U+HFtLI3SXFZnyrMnyjBLLh685eEfUC4RTuEI7Uys1jqlLxj6Mnm2Rm1TqAO?= =?us-ascii?Q?BTCiRjwq++BX9OFZHbf8Qnhe8WuXJAZ7A+vyogrvk79rSya2s5YcGxsZEwxx?= =?us-ascii?Q?Z+sQupYp2+4H7lPf+V37vCE0wLICqnGEXHQepifN+oOqqOmyv63f77DYvbC+?= =?us-ascii?Q?snKAEXKV/h9Uh1mqihZec0IdMu7HiO8wb9hKO7au48A6Ja6sYf25CaUlwsRt?= =?us-ascii?Q?yRLpwcveXOjeUFgDqV86WOXmCK/Qwt4jdVLY4/SdRkxaOfnGV+OZfb3Sd6lr?= =?us-ascii?Q?JNoWSo4uMjyoDLdfEkqSsKDh4c9OyH8jxp1Ab3HcCRfVc2SvEIdy7Oz1QDDn?= =?us-ascii?Q?ZICnC3lQUNH5WViMwNGg9DeJNYIZqrmheeHEFny6RD6ZBUQz+65cgQCcRKFP?= =?us-ascii?Q?UkVIYZ/CIMlzZutNovFzQ0NzwDoWUNZH60clRDMnicXJ8CrOlMfUbb+Dx//v?= =?us-ascii?Q?nm2mAQIUvJgt8SQm89EeYKBpb2Sec53sMUx4Mpdnn+W5YLtdG1Rg0EAtbwqY?= =?us-ascii?Q?KxidetRMXzjPcHiG0DVqQPer4YDYLcFNDzc2aE0kMKylSy3yShB0ZmnUB4V2?= =?us-ascii?Q?Wjo4nG6Fi230k56UjWd2V/evspewi3zK3LH98OMb8IvEHcIFGT5mZ17yWiDs?= =?us-ascii?Q?/p3wGnzVr1D+lO+asICC+m6FG7dPOAZdHhiXkHMNWmwauOyjV9xrPnyFoMgo?= =?us-ascii?Q?6MGv4Y3j8AocRi7L4bvHA5hV0cUc3BbtCF7ZjuoXgyxJU2rR3iQmoNlZRQyq?= =?us-ascii?Q?y1kmF1axhoyPKLSeUoRa/E9EN7JpNqUCVOz7ofceQrTtHviw4NMEHiQ7ELVp?= =?us-ascii?Q?Pyxm2ny9Kw4SP+mGUCHUrxlQ5XNRqHU9YWOfWRRplv7LzlQ0JkHwwN5DUhkn?= =?us-ascii?Q?E2ni3u2fe/+32MoIoQzv3zPcTQo1nq9/xaT2yxZj2sBRN2NzW4UkAKgRhzaX?= =?us-ascii?Q?7evRc7/gC42IlQjzht47b2XH64kitLmoWeLTLXCpHnI8ZNwjyiAgHyxTLhr0?= =?us-ascii?Q?cUGmRXszzKqQBmcUYxkwqtCdZ+3o32ohMvzr/xWJLqdy8Y/mjcUxP+PvlBRd?= =?us-ascii?Q?1UVDpL2s5ogaTC2/iQJ4mpVQwru2S+aCy5/7naQbHteqV3dKY/2G+hUodTid?= =?us-ascii?Q?hX1Havnwkj7nFoUGeIXHa8oYvaVJpYvc+VDoblO0gsLT3TqVzWDo6Q91gjtD?= X-MS-Exchange-AntiSpam-MessageData-1: PyscIOvsv9XpGHRsLcuD4Avh3HL2dwtY2U8= X-Exchange-RoutingPolicyChecked: DLyO+P0Cv7/AB9T7ie34gLL3WbBMaDvSPauGsjDW29zProRGBKyuwqC+DD1VO7qukqMSfSH622XpvK5zkjdCONgJ0sCxkhDAsFVYIe2HkPKWiERl/5Z3wVOhGL1j0PGYk9FcwIyUOWH4uKMLdbz4VTe5pOWfR44VPCPU7zrS02CJA8zhpqk8vieyRy2KJ9Dl9Fxz53KSloEQ+TU2es/TO6x4MC1sgWj0gjrOy9grfr0dlpUArs/OcqKhki6YhWbAQAbAcML9HwSrxG1AEbDiP+/ITJEbyV++fRCLikrOI645G2OfItE/Fe4ln7EBpodAqGZpEtbELlZtwjnjhcTyvQ== X-MS-Exchange-CrossTenant-Network-Message-Id: 36903804-4fd0-4b9c-5c65-08dea530433c X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2026 14:13:04.1696 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: awNxtK6wi3Sg0y+MeLa9V9zJBF+TeLxXnhbpKiK/5kEGRv/BCsBjXpZksCx0t+5nm7mQ+khBtUPpTp8gsfZkaJUNjVg4ucWxzl6BZUXls9A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SAWPR11MB9781 X-OriginatorOrg: intel.com On Tue, Apr 28, 2026 at 10:50:54AM +0200, Loktionov, Aleksandr wrote: > > > > -----Original Message----- > > From: Intel-wired-lan On Behalf > > Of Larysa Zaremba > > Sent: Tuesday, April 28, 2026 10:27 AM > > To: intel-wired-lan@lists.osuosl.org; Nguyen, Anthony L > > > > Cc: Lobakin, Aleksander ; Samudrala, > > Sridhar ; Michal Swiatkowski > > ; Zaremba, Larysa > > ; Fijalkowski, Maciej > > ; Tantilov, Emil S > > ; Chittim, Madhu ; > > Hay, Joshua A ; Keller, Jacob E > > ; Shanmugam, Jayaprakash > > ; Jiri Pirko ; > > David S. Miller ; Eric Dumazet > > ; Jakub Kicinski ; Paolo Abeni > > ; Simon Horman ; Jonathan Corbet > > ; Richard Cochran ; Kitszel, > > Przemyslaw ; Andrew Lunn > > ; netdev@vger.kernel.org; linux- > > doc@vger.kernel.org; linux-kernel@vger.kernel.org; R, Bharath > > > > Subject: [Intel-wired-lan] [PATCH iwl-next v7 13/14] ixd: add the core > > initialization > > > > As the mailbox is setup, initialize the core. This makes use of the > > send and receive mailbox message framework for virtchnl communication > > between the driver and device Control Plane (CP). > > > > To start with, driver confirms the virtchnl version with the CP. Once > > that is done, it requests and gets the required capabilities and > > resources needed such as max vectors, queues, vports etc. > > > > Use a unified way of handling the virtchnl messages, where a single > > function handles all related memory management and the caller only > > provides the callbacks to fill the send buffer and to handle the > > response. > > > > Place generic control queue message handling separately to facilitate > > the addition of protocols other than virtchannel in the future. > > > > Co-developed-by: Amritha Nambiar > > Signed-off-by: Amritha Nambiar > > Reviewed-by: Maciej Fijalkowski > > Signed-off-by: Larysa Zaremba > > Tested-by: Bharath R > > Signed-off-by: Tony Nguyen > > --- > > drivers/net/ethernet/intel/ixd/Makefile | 2 + > > drivers/net/ethernet/intel/ixd/ixd.h | 10 + > > drivers/net/ethernet/intel/ixd/ixd_ctlq.c | 149 +++++++++++++++ > > drivers/net/ethernet/intel/ixd/ixd_ctlq.h | 33 ++++ > > drivers/net/ethernet/intel/ixd/ixd_lib.c | 25 ++- > > drivers/net/ethernet/intel/ixd/ixd_main.c | 3 + > > drivers/net/ethernet/intel/ixd/ixd_virtchnl.c | 178 > > ++++++++++++++++++ drivers/net/ethernet/intel/ixd/ixd_virtchnl.h | > > 12 ++ > > 8 files changed, 411 insertions(+), 1 deletion(-) create mode 100644 > > drivers/net/ethernet/intel/ixd/ixd_ctlq.c > > create mode 100644 drivers/net/ethernet/intel/ixd/ixd_ctlq.h > > create mode 100644 drivers/net/ethernet/intel/ixd/ixd_virtchnl.c > > create mode 100644 drivers/net/ethernet/intel/ixd/ixd_virtchnl.h > > > > diff --git a/drivers/net/ethernet/intel/ixd/Makefile > > b/drivers/net/ethernet/intel/ixd/Makefile > > index 164b2c86952f..90abf231fb16 100644 > > --- a/drivers/net/ethernet/intel/ixd/Makefile > > +++ b/drivers/net/ethernet/intel/ixd/Makefile > > @@ -6,5 +6,7 @@ > > obj-$(CONFIG_IXD) += ixd.o > > > > ixd-y := ixd_main.o > > +ixd-y += ixd_ctlq.o > > ixd-y += ixd_dev.o > > ixd-y += ixd_lib.o > > +ixd-y += ixd_virtchnl.o > > diff --git a/drivers/net/ethernet/intel/ixd/ixd.h > > b/drivers/net/ethernet/intel/ixd/ixd.h > > index 99c44f2aa659..98d1f22534b5 100644 > > --- a/drivers/net/ethernet/intel/ixd/ixd.h > > +++ b/drivers/net/ethernet/intel/ixd/ixd.h > > @@ -10,19 +10,29 @@ > > * struct ixd_adapter - Data structure representing a CPF > > * @cp_ctx: Control plane communication context > > * @init_task: Delayed initialization after reset > > ... > > > diff --git a/drivers/net/ethernet/intel/ixd/ixd_ctlq.h > > b/drivers/net/ethernet/intel/ixd/ixd_ctlq.h > > new file mode 100644 > > index 000000000000..f450a3a0828f > > --- /dev/null > > +++ b/drivers/net/ethernet/intel/ixd/ixd_ctlq.h > > @@ -0,0 +1,33 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > +/* Copyright (C) 2025 Intel Corporation */ > > + > > +#ifndef _IXD_CTLQ_H_ > > +#define _IXD_CTLQ_H_ > > + > > +#include "linux/intel/virtchnl2.h" > Every other file use #include why do you need #include "linux/intel/virtchnl2.h" here? > Please explain This is a small oversight. > > > + > > +#define IXD_CTLQ_TIMEOUT 2000 > > + > > ... > > > -- > > 2.47.0 >