From: Dan Carpenter <error27@gmail.com>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: Jakub Raczynski <j.raczynski@samsung.com>,
netdev@vger.kernel.org, kuba@kernel.org,
intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v3 net-next] net/intel: Replace manual array size calculation with ARRAY_SIZE
Date: Tue, 28 Apr 2026 17:59:13 +0300 [thread overview]
Message-ID: <afDLQUjaQ4Zs_9D_@stanley.mountain> (raw)
In-Reply-To: <ef61b770-ebf4-406a-90a0-8a49aba02aee@intel.com>
On Tue, Apr 28, 2026 at 04:06:48PM +0200, Przemek Kitszel wrote:
> On 4/28/26 12:36, Jakub Raczynski wrote:
> > There are still places in the code where manual calculation of array size
> > exist, but it is good to enforce usage of single macro through the whole
> > code as it makes code bit more readable.
> > While at it, beautify condition surrounding it by reversing check and remove
> > unnecessary casting.
> >
> > Signed-off-by: Jakub Raczynski <j.raczynski@samsung.com>
> > Reviewed-by: Dan Carpenter <error27@gmail.com>
>
> thank you,
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
>
> (next time use "iwl-next" in the title, no need to repost just for that)
>
These prefixes are a headache. It seems like no big deal if you only
work on one subsystem, but if you're dealing with tree wide code then
we're dealing with 418 trees.
These days I have a script for net and net-next because they are a
high volume list and the original prefix subsystem. But otherwise
it just automatically puts [PATCH next] if it's in linux-next or
[PATCH] if it's in Linus's tree.
These are all automatic on my end, right? So it would be totally
possible to automate in the recieving side instead.
Although in this case, my script would net-next in the subject because
I had no idea that Intel was managing their own ethernet drivers... It
used to be that wireless had their own tree and everything else went
through net. So it's just seems like a in impossible task to keep track
of it all even if you are not a newbie. :/
regards,
dan carpenter
next prev parent reply other threads:[~2026-04-28 14:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260428103757eucas1p132f3f1123fae21d596a51cbdce72c931@eucas1p1.samsung.com>
2026-04-28 10:36 ` [PATCH v3 net-next] net/intel: Replace manual array size calculation with ARRAY_SIZE Jakub Raczynski
2026-04-28 14:06 ` Przemek Kitszel
2026-04-28 14:59 ` Dan Carpenter [this message]
2026-04-28 15:01 ` Dan Carpenter
2026-04-29 9:01 ` Przemek Kitszel
2026-04-29 10:24 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afDLQUjaQ4Zs_9D_@stanley.mountain \
--to=error27@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=j.raczynski@samsung.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox