From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1127B3D5640 for ; Wed, 29 Apr 2026 10:30:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777458626; cv=none; b=VWw5+O0n/DYjfXOkedpZAnyiDiPhF2/gX/bsZV+BoXbR26bokiTqfpifItTP4mafOTlq3LLL8/FkT7LcuTygtFLO3Pu1I8fD+LdYmT/NjAT+aBJztLfRgSAV+uB8YqM0LynqJUlU4GxFqHvkwfh8ikfD/GvhwE3BIf29kcWLkmk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777458626; c=relaxed/simple; bh=8k+/eJ+oplAKwa6y8hgdOMX1aMdC7hSdvQ+WDtJexew=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uPt++Lgyzh7dqRAN3GlzrrqbBYdn1UeAAOAkB9c3n0kOirMtX1qaeLQAeMUCYWiZR6VfXMajzMzFzmEDV829iFjuI10P83ANDWov5oUuBLYrSvHUeYAkH3EzZfySvN0mhYDasSEsNU3j22yMLrwYOiRY2BtSHURdeLjzwuEF8L0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=bjgsjhgb; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="bjgsjhgb" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-488d2079582so144955175e9.2 for ; Wed, 29 Apr 2026 03:30:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1777458622; x=1778063422; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4K3CX6fQVp3G5LFrOMSsx2n8N4FljSdUREsN/3Z40rY=; b=bjgsjhgb4OsQIhvq0fHIIxH0cSCfCKFi1n04zU6r75eqdWhQPXahMcQUfQFXi6x1c5 f1EyEG4/TtvYx4j+IWrkk3EN2bJqSqqYEfCaZUZFwPZbs6rIfdATuqntg9fG5HiVNba2 r0lTsBgGML1akn11CEmCoZCHkaIgPiOsDNuZ7gj5RHLeFHOwxfhfzcaUeB2AWvElJsry 5fj6nLHhewUeWD8JULg4yJMi+laRDU89fHvNln0y1E5h1oGbHnWhypceJ0UD/0TGuDQd k7p9RoPpJxxncom3FjG4LGEQ/eLJEriLw8incVpA5TwDHKQ331+s6B09FQXSkdLw9DXs LVIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777458622; x=1778063422; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4K3CX6fQVp3G5LFrOMSsx2n8N4FljSdUREsN/3Z40rY=; b=tVm2uPdgEPzHfunJzxMdPqoG6IdJA3SX9SEFWEn4/U856gOQkUodXigklKAsUOCUfo oWse/1W6QDC555+/C0hYTE9vQy4wQS3GKmOb41VjcJq4MmeFSL0bnstRedZKpISajgDD M+PDfHIQVEevQZz+E+MqxoWgzuryWYYBA5iKc0aYD0jSBMAI1TGiQQV71ty1+rrbmLNd SS9MbeWjCRkVtMah42q95kdfd0hsaD26BA1ppcA3IZboVhdAHAO0rC435ob+7Wo7PU2F /YrNK6fFjEAforILU2PSh/1d90be4Gto0L2r5DAPh3Vy2T1vJpcVVBItWmM/2FlAwaMB Vb4w== X-Forwarded-Encrypted: i=1; AFNElJ+31yoIYlMG1QToqzyjQPCiTewgf/V6DlAZsznwFoKRYzXGXX8dxuZOKpRkFteVMtlSU3LeLIE=@vger.kernel.org X-Gm-Message-State: AOJu0Yzq/gPZ+kFB+j8BFjR8KzeANycx+VaCFDshtX3eHd71BS7RzMmy qcoHVdIwu7s2P7FD0soHv+2QDvtmHS+0SYtyBW5YwTi8ly14zCkz6KeAAI1vycZNh8g= X-Gm-Gg: AeBDieuwC6fC9bBgucmwclVPqJYLhFbQGtB6AN4/QhUmst3NRNhFQ3bBBHjTDZS9sKF 1e25eG1zNueNxa0gFm5qx/SJTk5ik5MrE6srXwecfeL4BvXkLBr56BE/loHcArYZPgvVaTIozDS Ic0rPyfvSCjkWn7oxzFfsRNEPBQXijcA/2IZNS2TEFJZClbbwIFjM/WfbCpFnI2ORVcHXqCnJIu reHZQarX+lt+kTYi2GQKJhWAeX0OJ55F/81HBohdVNFMv1il8b3X/9ly5HdO7xbWuhvnq8VIRFC KtehEHDzZ7I76VrazBxtkmn6jlwRIAhqD8IKW8iVaY0ZVYbP8Cnkspn+/zO/h3+zvJOuMg65H/p IcHY6r1sIKlVlCFm+YrIuJKq4IkMchb+d0oSB8NV3V4Q8JYL+KPD/9mKSzFlXrUzoBN+Dnqk/81 jZbLIwxc/EO7qV5H0DiQMYAuEQrDBUX5StIsQxE6CBviKv8L9HkbdiwCtSYYYFrKid+Po3Ojmzb DsByeCHx1iu7OEhjyMr41sUaQ== X-Received: by 2002:a05:600c:a4f:b0:485:3a03:ceca with SMTP id 5b1f17b1804b1-48a7b543796mr66187605e9.23.1777458621928; Wed, 29 Apr 2026 03:30:21 -0700 (PDT) Received: from localhost (p200300f65f114e08936c55da887fa426.dip0.t-ipconnect.de. [2003:f6:5f11:4e08:936c:55da:887f:a426]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-48a7c57b641sm47160965e9.6.2026.04.29.03.30.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 03:30:21 -0700 (PDT) Date: Wed, 29 Apr 2026 12:30:20 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Marc Kleine-Budde Cc: Michael Grzeschik , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vincent Mailhol , Krzysztof Halasa , Johannes Berg , Markus Schneider-Pargmann , Steffen Klassert , David Dillow , Ion Badulescu , Mark Einon , Rasesh Mody , GR-Linux-NIC-Dev@marvell.com, Manish Chopra , Potnuri Bharat Teja , Denis Kirjanov , Jijie Shao , Jian Shen , Cai Huoqing , Fan Gong , Tony Nguyen , Przemek Kitszel , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Mark Bloch , Ido Schimmel , Petr Machata , Yibo Dong , Simon Horman , Heiner Kallweit , nic_swsd@realtek.com, Jiri Pirko , Francois Romieu , Daniele Venzano , Samuel Chessman , Jiawen Wu , Mengyuan Lou , Kevin Curtis , Arend van Spriel , Stanislav Yakovlev , Richard Cochran , Kees Cook , Thomas Gleixner , Thomas Fourier , Ingo Molnar , Kory Maincent , Zilin Guan , Marco Crivellari , Vadim Fedorenko , Jacob Keller , Philipp Stanner , Bjorn Helgaas , Yeounsu Moon , Denis Benato , Yonglong Liu , Andy Shevchenko , Yicong Hui , Randy Dunlap , MD Danish Anwar , Nathan Chancellor , Sai Krishna , Ethan Nelson-Moore , Larysa Zaremba , Joe Damato , Double Lo , Colin Ian King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-can@vger.kernel.org, linux-parisc@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@corigine.com, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com Subject: Re: [PATCH net-next] net: Consistently define pci_device_ids using named initializers Message-ID: References: <20260428171845.2288395-2-u.kleine-koenig@baylibre.com> <20260429-responsible-clever-coyote-6b79f1-mkl@pengutronix.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3grpbpcumi4i3vj3" Content-Disposition: inline In-Reply-To: <20260429-responsible-clever-coyote-6b79f1-mkl@pengutronix.de> --3grpbpcumi4i3vj3 Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH net-next] net: Consistently define pci_device_ids using named initializers MIME-Version: 1.0 Hello Marc, On Wed, Apr 29, 2026 at 11:10:21AM +0200, Marc Kleine-Budde wrote: > On 28.04.2026 19:18:44, Uwe Kleine-K=F6nig (The Capable Hub) wrote: > > }, > > - { 0,} > > + { } >=20 > Nitpick: can you convert the terminating entry to follow the same style > as the rest of the driver: >=20 > diff --git a/drivers/net/can/sja1000/plx_pci.c b/drivers/net/can/sja1000/= plx_pci.c > index a03553b80a5d..d69ff0ccfd94 100644 > --- a/drivers/net/can/sja1000/plx_pci.c > +++ b/drivers/net/can/sja1000/plx_pci.c > @@ -353,8 +353,8 @@ static const struct pci_device_id plx_pci_tbl[] =3D { > PCI_DEVICE_SUB(ASEM_RAW_CAN_VENDOR_ID, ASEM_RAW_CAN_DEVI= CE_ID, > ASEM_RAW_CAN_SUB_VENDOR_ID, ASEM_RAW_CAN_= SUB_DEVICE_ID_BIS), > .driver_data =3D (kernel_ulong_t)&plx_pci_card_info_asem= _dual_can, > - }, > - { } > + }, { > + } > }; > MODULE_DEVICE_TABLE(pci, plx_pci_tbl); That might be subjective. I also see some value to have the terminating entry stand out a bit in the formatting and so I usually kept the entry as it was. If you prefer I can rework the can drivers at least to match your taste. As you didn't object to have the can drivers converted as part of the drivers/net patch, I assume that part is OK for you?! Best regards Uwe --3grpbpcumi4i3vj3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmnx3bkACgkQj4D7WH0S /k6JpggAqaPu+dVWg39EGo869zm4GExkyk9Cfi0y4X05WE8coeYG2q3U4oD1x05e mbEJVHdpAHnBcB/vafRjFDSueFN1LbdYKyqmCOoSEVZm6FUryg3uez5LBTQ1H2M+ HSSsw95R2MJqtNxxGphk2Cr4lR3yVrG+oJpIot8CPMMed7xddK4yn7AdrudrcYAv fhOuS+7KEB4g6yajDT95eF2Jj+hN7rzcU0+g6TBO5Gd3GnLwIhG6FG4iZnwnaU8Z FqH+sC+KN85L/JYWezdPXgx5DnHkrmX1530hPFowO9u5SBLf6zBmbuKUgF8CdU4H gSp6StxoogXj+z4H3WJRpNSbxjHwNQ== =BqTG -----END PGP SIGNATURE----- --3grpbpcumi4i3vj3--