From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A1B72253EE for ; Wed, 29 Apr 2026 23:36:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777505761; cv=none; b=M+gUHDJpHIzAb9y+rvcW5aE0UtRpBBYGgZMsPqDh4PfjCR6kBMB6umuUVc6gHtAYNT8zTrTrgnM7tak+rCH9J3POAkzAD1hy1JBtuj6BqqzxnW3mUTXte5pFpCusxfSYFHvHX7bLpWZB+3dNAyr59fBHTmeDBmeecZg2inX7WYg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777505761; c=relaxed/simple; bh=6p2wF/KAGBxnYjm9WujwA9uUvhFUL23UjYg0EjS0VbU=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=bS6L/9nNODIZZi8bke79D6tMBFNJ4btQSub2Cpo1kWUA2wZiIz4NJcjWo+KziMPX72DW+iFgbpDVpPjK2+JpPk161R2IbLQUckYd5JCwfCETxKnUxtkWcsTRoEdvXgDRNwzJf2usNXVAuPF/x8xVjflhoPsFVlmCxZBlyEXoSUw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G5yeLmvP; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G5yeLmvP" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-364c5317d67so25867a91.2 for ; Wed, 29 Apr 2026 16:36:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777505760; x=1778110560; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=ijVyuUROF7AQHIY8lacIUeZaqX8lgHCdNnE9tX/cb9U=; b=G5yeLmvP13Ex+0qipNhWSre54NNl5ME37rO+RtGdUX5fq7SnH8GFRU8xym3qJipK/S 4RxeStjglL/br5nCI03EyX78CE76s4PxFHWRZlfDWrpiipN/p1UupnXFp7Z6Mg3wQOvn aob2rBlN2KS6kqSVGryWT5GtVAHVq1wCSbysZRPXW/jYcsI46jNpDMkFpvIurnYO98WZ P709rcdCIvIE6jR0IMw/W7zOmdxxPQjT669z2NoEM0glLYtwexsqxJkZitQed1xIbI1r d7AhgneoBZIFQOuLsx9lHojm3OCwGcneQp9Rgzgs3FK+Oi4ByYE6eC24p4SxjEA8WukU yuLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777505760; x=1778110560; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ijVyuUROF7AQHIY8lacIUeZaqX8lgHCdNnE9tX/cb9U=; b=BiAB/bUMkyrhPmb1AAq5Rgb4NO7zu6THiWyfFBEd4jDIG1U9Zw+aJc+DEyiRLa59Y0 WL3vbIF7W+NU8nVpqnvK2bTLKZ5C90xSYqAsRfAOVrWl2M7ZVWz8xAnLG++IQi0QLQlz b9p2daY9UvEYGHa498m7aNvg8poOdnaTNKUXEy5Cp2gHJURQDmmyBpc+a2zyxLhHOMZI MYgdGJEl5VuUAOEcqMeGw7+WeSSb9C5WBPIUy78ZSwKKSEJW8WCEzEm6ur9zjrnaN8vu xVNFiUJ/jcLFHFxXa5b+P+qpZ7so4TnRBxmUhcpGMh41Yl4P8xo3IWKCJ9MiVtd+ALDO OY3w== X-Forwarded-Encrypted: i=1; AFNElJ8zOlf1ZD5J5saPkGC70IBoiRT2/YemJdT3e4iQbqSPwJyyKGaWvjWeXvtOz96TMMjmPB88Jm0=@vger.kernel.org X-Gm-Message-State: AOJu0YwsguusulOrMw/ybs9CFeslGJLBSapRn8eJV4iSAHI+gNAGYtIK JtvESZTytfHnhzBBVYJM65Aj31QT3UibGaYbia4rtVb8z/5Utpk7oHCX X-Gm-Gg: AeBDieu83hPKTSORofk4F/RrAz7XsUSJjT+FQRTpbK5ymfLGAAjVokbREH1DSfZE9Ss u/ToKIJrXTD34gAlRQsXiyWZb3b6iJjI3jzMJjMMjl5Iy8ymPN49JVD9aonTxt4RAX/yKJnJyU0 9wiqgqz/iKN3CmHUGKastaBe7oSmqt/aIFiqc4OYwiJNSSCFaH6nyQOOE+ZYOf/a1g3tqICfUvo BXo0BG2arIRfIIvbjVEkGQ9aB9EtJIwsMDiA4bEMrUp+rPkJDCrFqHjurk58smw01Knut2I2f8y QetS9efdaFm0nJq3cvIdUBdzy0B7Np3K3lNxCDatXIGSqGxKqZuhH9zWo7InZXZd8JjfzI1m8Di oODrYYc/wGHexyl2UeOTE5Ka+FCfbUvmIqnySE5V9p5Fmp4dJkKnbaxTN+pDM6S/MWhrVxf27TG PDuqEDg8aouxBdbEB+L4phhyIyVBLs+hxJOtK9GkILnOSByrFk4wgeag== X-Received: by 2002:a17:90b:52cf:b0:35f:ccf6:69a5 with SMTP id 98e67ed59e1d1-364c31a6b14mr389899a91.20.1777505759731; Wed, 29 Apr 2026 16:35:59 -0700 (PDT) Received: from v4bel ([58.123.110.97]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-364bdf50bc3sm793425a91.8.2026.04.29.16.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 16:35:59 -0700 (PDT) Date: Thu, 30 Apr 2026 08:35:55 +0900 From: Hyunwoo Kim To: dhowells@redhat.com, marc.dionne@auristor.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, linux-afs@lists.infradead.org, netdev@vger.kernel.org Cc: imv4bel@gmail.com Subject: [PATCH net] rxrpc: Also unshare DATA/RESPONSE packets when paged frags are present Message-ID: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline The DATA-packet handler in rxrpc_input_call_event() and the RESPONSE handler in rxrpc_verify_response() copy the skb to a linear one before calling into the security ops only when skb_cloned() is true. An skb that is not cloned but still carries paged fragments (skb->data_len != 0) falls through to the in-place decryption path, which binds the frag pages directly into the AEAD/skcipher SGL via skb_to_sgvec(). Extend the gate so that any skb with non-linear data is also copied, ensuring the security handler always operates on a fully linear skb. The OOM/trace handling already in place is reused. Fixes: d0d5c0cd1e71 ("rxrpc: Use skb_unshare() rather than skb_cow_data()") Signed-off-by: Hyunwoo Kim --- net/rxrpc/call_event.c | 2 +- net/rxrpc/conn_event.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/rxrpc/call_event.c b/net/rxrpc/call_event.c index fdd683261226..6c924ef55208 100644 --- a/net/rxrpc/call_event.c +++ b/net/rxrpc/call_event.c @@ -334,7 +334,7 @@ bool rxrpc_input_call_event(struct rxrpc_call *call) if (sp->hdr.type == RXRPC_PACKET_TYPE_DATA && sp->hdr.securityIndex != 0 && - skb_cloned(skb)) { + (skb_cloned(skb) || skb->data_len)) { /* Unshare the packet so that it can be * modified by in-place decryption. */ diff --git a/net/rxrpc/conn_event.c b/net/rxrpc/conn_event.c index a2130d25aaa9..eab7c5f2517a 100644 --- a/net/rxrpc/conn_event.c +++ b/net/rxrpc/conn_event.c @@ -245,7 +245,7 @@ static int rxrpc_verify_response(struct rxrpc_connection *conn, { int ret; - if (skb_cloned(skb)) { + if (skb_cloned(skb) || skb->data_len) { /* Copy the packet if shared so that we can do in-place * decryption. */ -- 2.43.0