From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90BAC2F290A for ; Thu, 30 Apr 2026 13:15:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777554913; cv=none; b=Uhcq/2WBDvig04CDMuhJyEi8S3u23wQwL1y3dWmUiL69k0FwaJWshme6BUS9wiMyUtCGKiPMErcu65ExmvEcPJu94UWwb3ze2aqIYUZ5s1HFekmtexcb6AhaG/V0pD8S9NaFQpeac/9xFIW8KgSxx35zJ88FfOZ/IgS7hjK5LHg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777554913; c=relaxed/simple; bh=k6Ky8SekzqlEMWe2IfF4o9e521vL5c/R7nKtlYixpPs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=c1yc1VvPetGT9ekRpUWRyUKbUn2slEMfhYGVhfbjMMRgC16fxInlCT2I0/lVXnfCFpV+K4k89+ABkL1HYqLD3hLs4Rl3BmKeL3+6UNZcIWSy39Nmk3QJW6Od6xe6+i83HxU/rEm6w+4FjVIw2sZgCQvcRgWBIqbYtbsPhqdcBT0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=ZcxvhIgY; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="ZcxvhIgY" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-488ab2db91aso11340975e9.3 for ; Thu, 30 Apr 2026 06:15:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1777554910; x=1778159710; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Q14Nfv+UEqF4wGTpTXYwRmNvMzztXWMPU3JKrPL0wNU=; b=ZcxvhIgYSB2FjP+0ja//gHRzj0S/DjUT2vV7ujd1DIAIMDat4t6ICYdT1a+tsUH42b JVNnKNPGZCu6M3GPd5DH5VqgCKC/ofDpGehGjrbG+nKzDQQDHPkMrlFjdw0HYqpGAf6D GtykEVIZKTFCt7Y6Lu+uEzP9bxlwp+3zJu1sI5jwJu9YmaPLq4ozuRnBtV+eqjLTABs/ rCdCeEa8ZTY2ZB9TZ2WgVvKJX/vRIcGD5IHnKPwXCqdYG1KiedfYzTBnjswAIo6zlLrd ktLvWZ/vyddbrfcIGCpBKJldcrnCRmf0nr/uuIdEBqQxjHMyJa3zNWk8QlR9WAUryMRL Qc/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777554910; x=1778159710; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q14Nfv+UEqF4wGTpTXYwRmNvMzztXWMPU3JKrPL0wNU=; b=GC6Q6vdo91QIvMOgQ3Ib+KSRSsXev7CPJ2MJgvuKzuuS9zbD7wsQd2u/94Vjl57Swc HtKssFdl2EFLtxLxQe1WcPmkuUzASsKh+R8n/HH94rQETXLrjcwkX6ysyYOUCG4ZrYds mPJrhgnyQWsQyC17ZE0FMx7iDNpH1zC2XrDeEC0IoveXAFxI4Qbe5HLb2ddYkm3dOJdL IbFbkJkd4H2qDEDD3zj8fuhiPpCicSV+CqUoN7uyj36wX4ZOzblFdR035h+HqiYILlUD 4JhFs8CRnvYuMzNiXvwu7Zj4toiDkibzFdDBfRUEIlx5m9qf4uSBPyJ6D2wJnydkdACZ kW5w== X-Forwarded-Encrypted: i=1; AFNElJ+ZqjsFW/FZeOAMQLWgQQVGujiOuTJEPe9yMNZvei7KjPzqJMSL6aQbdnlGrmJvvCDq46GQtuo=@vger.kernel.org X-Gm-Message-State: AOJu0YwYlq6N5AtoJz4besxnfkcihOiL90xdYGpKbzSA69HRBYkw7/Kq JcpF9ePl2GZUVIqxA/oBMl0wZrepb44jyk0SJFgSXMQE1UiYdJP4ph5iBo6YisjSOuc= X-Gm-Gg: AeBDiesmXwEdOwoQJ2EPaGPi7/B3J2L5lxsm958gp4CHnkTKOdFRAoHMtA+njhylNOX r1aSgBPeTYNwCGe1IZ/vcXKjj18RvZXMKbwfRGh66z2XbI3QCOft2DAxwXtGVRK3azRJAJ0nciQ cM3podNdS8f6Vp1IRl0Jy/Se/9z7WT+o1YAzJdGpuBKRnnhptwWEKU4CJHAdmmsjNvbOKxLg0ke 34dmo4ok+kFsli9d3WBgXrpzoZQ2LWOpUSVKDHmtTtbq7y2thjBSganKnd1BZhOcpvR3BQ+I4hF 0jSV0PZB97hwLxODK4zuZXgFL24c1Td/OzAHDj9+uibOOWq9XiBTiy4pi93E/Rsb8S1sKmwDnTd naQ6tzsvsIC12xL3cPE0lwUOsz8CKFZtf4XQGnygtvSHZT8mnv4K0iImBlTUDmwoTl2P8/L4cGH Lpj9Xm5ngsB5izr7vA+lKKS8hlCMg8ZNZsbM3Di7YBmIrwF2/PMl9LnHsNqB9NLvO+G0+e69ves JF9f+rtr1t+4/LZPrj65ui8oQ== X-Received: by 2002:a05:600c:c0db:b0:489:284:44ab with SMTP id 5b1f17b1804b1-48a83f6b306mr35501805e9.12.1777554909754; Thu, 30 Apr 2026 06:15:09 -0700 (PDT) Received: from localhost (p200300f65f114e0859f76ff87a50eb14.dip0.t-ipconnect.de. [2003:f6:5f11:4e08:59f7:6ff8:7a50:eb14]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-447b3d47ff1sm13921904f8f.6.2026.04.30.06.15.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2026 06:15:08 -0700 (PDT) Date: Thu, 30 Apr 2026 15:15:07 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Markus Schneider-Pargmann Cc: Michael Grzeschik , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marc Kleine-Budde , Vincent Mailhol , Krzysztof Halasa , Johannes Berg , Steffen Klassert , David Dillow , Ion Badulescu , Mark Einon , Rasesh Mody , GR-Linux-NIC-Dev@marvell.com, Manish Chopra , Potnuri Bharat Teja , Denis Kirjanov , Jijie Shao , Jian Shen , Cai Huoqing , Fan Gong , Tony Nguyen , Przemek Kitszel , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Mark Bloch , Ido Schimmel , Petr Machata , Yibo Dong , Simon Horman , Heiner Kallweit , nic_swsd@realtek.com, Jiri Pirko , Francois Romieu , Daniele Venzano , Samuel Chessman , Jiawen Wu , Mengyuan Lou , Kevin Curtis , Arend van Spriel , Stanislav Yakovlev , Richard Cochran , Kees Cook , Thomas Gleixner , Thomas Fourier , Ingo Molnar , Kory Maincent , Zilin Guan , Marco Crivellari , Vadim Fedorenko , Jacob Keller , Philipp Stanner , Bjorn Helgaas , Yeounsu Moon , Denis Benato , Yonglong Liu , Andy Shevchenko , Yicong Hui , Randy Dunlap , MD Danish Anwar , Nathan Chancellor , Sai Krishna , Ethan Nelson-Moore , Larysa Zaremba , Joe Damato , Double Lo , Colin Ian King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-can@vger.kernel.org, linux-parisc@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@corigine.com, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com Subject: Re: [PATCH net-next] net: Consistently define pci_device_ids using named initializers Message-ID: References: <20260428171845.2288395-2-u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6b5ffjhgb6zy7r2y" Content-Disposition: inline In-Reply-To: --6b5ffjhgb6zy7r2y Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH net-next] net: Consistently define pci_device_ids using named initializers MIME-Version: 1.0 Hello Markus, On Thu, Apr 30, 2026 at 10:55:14AM +0200, Markus Schneider-Pargmann wrote: > On Tue Apr 28, 2026 at 7:18 PM CEST, Uwe Kleine-K=F6nig (The Capable Hub)= wrote: > > diff --git a/drivers/net/can/m_can/m_can_pci.c b/drivers/net/can/m_can/= m_can_pci.c > > index eb31ed1f9644..cb9335c1d3ea 100644 > > --- a/drivers/net/can/m_can/m_can_pci.c > > +++ b/drivers/net/can/m_can/m_can_pci.c > > @@ -183,9 +183,9 @@ static SIMPLE_DEV_PM_OPS(m_can_pci_pm_ops, > > m_can_pci_suspend, m_can_pci_resume); > > =20 > > static const struct pci_device_id m_can_pci_id_table[] =3D { > > - { PCI_VDEVICE(INTEL, 0x4bc1), M_CAN_CLOCK_FREQ_EHL, }, > > - { PCI_VDEVICE(INTEL, 0x4bc2), M_CAN_CLOCK_FREQ_EHL, }, > > - { } /* Terminating Entry */ > > + { PCI_VDEVICE(INTEL, 0x4bc1), .driver_data =3D M_CAN_CLOCK_FREQ_EHL, = }, > > + { PCI_VDEVICE(INTEL, 0x4bc2), .driver_data =3D M_CAN_CLOCK_FREQ_EHL, = }, > > + { } /* terminating entry */ >=20 > M_CAN_CLOCK_FREQ_EHL is basically hardcoded for all PCI devices since > 2020. I don't think we need this driver data at all and can just drop it > and use M_CAN_CLOCK_FREQ_EHL directly in the code for the frequency. > Once a real new PCI device gets added we can see if and what driver_data > is needed. Sounds like a nice *separate* change, right? Best regards Uwe --6b5ffjhgb6zy7r2y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmnzVdgACgkQj4D7WH0S /k4x3Af/edtfz9YYPFE6xum2g4TegCtLIvKw++0KDUAoyqpgkttjiVhQP2pkII1I bwoXEDLgA701tfOm6K4xaBwmjr22fTEMmwqGBUUV9kbxJkZTOYaAvGL9vZUhumqW aON4lzwvfmfJ4n1Nk/YWjSE0QmjI9PG7aoUCczzIPsEamTrS3xLh7OpHvF2bshFv 8t879m4kyInFizFXvDm3Pb+7WfqIwJHbJBKFtf3yy5ZlAf4JxFccVoOC3ygeZaz7 2S+yew8q9RxoAdReZzT/aUjlxkf0z4CmHidC1JcBK8qT/tAsE7w86uaDZOy5/ZKz gpkzwoU/cOxmGkcr+S/smN1/kcOCJg== =Kvic -----END PGP SIGNATURE----- --6b5ffjhgb6zy7r2y--