From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38BE11EEA54 for ; Fri, 1 May 2026 10:03:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777629804; cv=none; b=Y7uqqqw7CuLfXLkd+tV6vwlnEhPY8D79cn9qnwCbfPugURs91RHSYAPLXi0z/9X5+yLsITbsw7h53yrM8FPmrK6j4+4cwIQJh8jZ6ASHwRt0gAs7EqNsr6Ic8596CrEU6mRmNtWFkVtRzHoxjtT6Q8QbEjwmF99Y2vwLWtlgc8o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777629804; c=relaxed/simple; bh=FSYftY8QuORJHCe8t1V2XVW+trM6gYk9XA6x4O1Ehpo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XPK10sZzZPsUveu3VPuiHBYcfeevhP5uEe6zUyUAZChCIp+zJgrqcHkvONL6Xfu+KdWI+UfVamyHd9PE8+6W0T9obz7vVpYXfpkXTgAh18WQ5kiZqeO9aaaPCeN7RQv/rxLSp1UseQ67qDf2mre0ReseXu2+eUKuEVtCpw1WaTU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com; spf=pass smtp.mailfrom=cloudflare.com; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b=Kid+u6Ol; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="Kid+u6Ol" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-44985f4ab0fso715014f8f.0 for ; Fri, 01 May 2026 03:03:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1777629802; x=1778234602; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Su0c59s+EOGt4bGqynE6SKSlrnRdNQb/dtAHeJcNMSg=; b=Kid+u6OlSbGcKdUSB+idjqsnBx40kDmZKqqac6l7X0yknTEMLkeu37AD/l0rpuk5nc Qjh8bCkGZzboFuP1ZnH/Enq716GEFXnYjtjPM8MROJ9BEoGWbYMlczrE5p5Ra7I872QV PIMsJyipJjnCErBGPePcEFfu3fXsuRbotHQw/QZbMLt75iAjITMY1XD7ODsUiQYLIjV8 ua8NHnI2k5OJh5PVmQ3dXTXyqPJ7LZeJGgWNRpNMlvSIAUbjAkcNhCuF5k6NHvISYsDi XbO6ToRyIEzdS0Ex+qGHvzKgPd5zY3Jr5uRgB+3gnzojeVhcpDZR3iZuNBu3qUd7WKOm 6o/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777629802; x=1778234602; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Su0c59s+EOGt4bGqynE6SKSlrnRdNQb/dtAHeJcNMSg=; b=qBgBCDnYHxU27YsHp1dVnUjmtBQ1WJED0lO0WbfBfzP5vxMP7NY5z40wGXGXSCQhEb AE50Zc5P5yvKp16UOyuIBj35loOUTGRDFAF4glaECrOupT+FHFugC2YtkFFPsC+MksFS xWKE6j1xtXOb186QefxOabpxNLLHcxpsHbEn2VNSjarYW+cLZaQrccspBhffAaD6Y7IT XAoD3A9UF26lRITt0AoYI1yXCAsUreEAki6k7Y/JIhmMg5u4sVp7S8Wl8MMoYbJBzcVd H+Ycf5X/CtfNHOV3QW2sxFQorLptHtwO6EfJfS2epOZYyX5kdjF+zjKKBZuJf+cl68JE hb9g== X-Forwarded-Encrypted: i=1; AFNElJ9FcMGE1oySU4C7972BKOdMzechkolCLAkFnx5k8VqQv9vhD/VlS06OGtlvR1leOoKoCOXIWjg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8AGQl0yhKmnmCxrl3Tj5tyjIrghwSYAm+nz7EAA35mPaYQP3I vxI77HVere052fNq8Zlt2Otm2rqR6ZjNK2kB2VYTUl5IVNGHtwueuA+QrO0P0xXBs38= X-Gm-Gg: AeBDiet5jv4BshWCs0/5IvfcIl7kuOMMHb8qg0HL7L+zHxa7cDmJ7IhijQL1rUSpEzD JEPfK+/Q1I7ZcmE0b9RXNzQetLqL1f8VBKDSE72QH/aUr3G0Qy+B6Jry1SCisHZQzuuFWvIG4IN XdZY4GqtStLFQZUoG+/aYR6lVj/Y1PQotrEKYrsM23ttF/3iDyGY1EOvr0pegUf8giZsbKJIbsh egfUwUGjcbJ9twYEi0hFt1Hf6nQ+x5E9JHRJfULNdStanjumElk6631KCGdPTesF8Cq0Tq/tehY gXGKMRwqNnCm+3xRdF3BnK11pCvpp/vRCQ4Ffl4Qo8bK6pbQs7n1/yczc5NuhItOnBqTwttPa4T G26naZtRIOK4TwNtbRJ6T17impoDaqd88phWgRSj+g8g4bD07DaBsOjPvtzsPLlkqObOH9AFSOr mqEDmyhsrMZO96AHvY8JF8jc4= X-Received: by 2002:a5d:584a:0:b0:43f:ea91:63ff with SMTP id ffacd0b85a97d-4493ded555bmr11715307f8f.10.1777629801487; Fri, 01 May 2026 03:03:21 -0700 (PDT) Received: from localhost ([2a09:bac6:37a8:26d2::3de:68]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-44a8ea7cf97sm4271919f8f.6.2026.05.01.03.03.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 03:03:21 -0700 (PDT) Date: Fri, 1 May 2026 11:03:20 +0100 From: Matt Fleming To: Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Mark Bloch Cc: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@cloudflare.com Subject: Re: [PATCH net] net/mlx5e: Fix use-after-free in mlx5e_tx_reporter_timeout_recover Message-ID: References: <20260408184458.1274662-1-matt@readmodwrite.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260408184458.1274662-1-matt@readmodwrite.com> On Wed, Apr 08, 2026 at 07:44:58PM +0100, Matt Fleming wrote: > From: Matt Fleming > > mlx5e_tx_reporter_timeout_recover() accesses sq->netdev after > mlx5e_safe_reopen_channels() has torn down and freed the channel (and > its embedded SQs). Replace the three sq->netdev references with > priv->netdev which is safe because priv outlives channel teardown. > > The netdev_err() call already used priv->netdev for this reason; make > the trylock/unlock and health_channel_eq_recover calls consistent. > > This fixes the following KASAN splat: > > BUG: KASAN: use-after-free in mlx5e_tx_reporter_timeout_recover+0x1dd/0x360 [mlx5_core] > Read of size 8 at addr ffff889860ed0b28 by task kworker/u113:2/5277 > > Call Trace: > mlx5e_tx_reporter_timeout_recover+0x1dd/0x360 [mlx5_core] > devlink_health_reporter_recover+0xa2/0x150 > devlink_health_report+0x254/0x7c0 > mlx5e_reporter_tx_timeout+0x297/0x380 [mlx5_core] > mlx5e_tx_timeout_work+0x109/0x170 [mlx5_core] > process_one_work+0x677/0xf20 > worker_thread+0x51f/0xd90 > kthread+0x3a5/0x810 > ret_from_fork+0x208/0x400 > ret_from_fork_asm+0x1a/0x30 > > Fixes: 83ac0304a2d7 ("net/mlx5e: Fix deadlocks between devlink and netdev instance locks") > Signed-off-by: Matt Fleming > --- > drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c b/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c > index afdeb1b3d425..8409ae73768f 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c > @@ -160,13 +160,13 @@ static int mlx5e_tx_reporter_timeout_recover(void *ctx) > * channels are being closed for other reason and this work is not > * relevant anymore. > */ > - while (!netdev_trylock(sq->netdev)) { > + while (!netdev_trylock(priv->netdev)) { > if (!test_bit(MLX5E_STATE_CHANNELS_ACTIVE, &priv->state)) > return 0; > msleep(20); > } > > - err = mlx5e_health_channel_eq_recover(sq->netdev, eq, sq->cq.ch_stats); > + err = mlx5e_health_channel_eq_recover(priv->netdev, eq, sq->cq.ch_stats); > if (!err) { > to_ctx->status = 0; /* this sq recovered */ > goto out; > @@ -186,7 +186,7 @@ static int mlx5e_tx_reporter_timeout_recover(void *ctx) > "mlx5e_safe_reopen_channels failed recovering from a tx_timeout, err(%d).\n", > err); > out: > - netdev_unlock(sq->netdev); > + netdev_unlock(priv->netdev); > return err; > } > > -- > 2.43.0 > Hey there, any thoughts on this? Thanks, Matt