Re: [PATCH net-next v3 5/5] selftests: net: add veth BQL stress test

Jesper Dangaard Brouer
2026-05-01T07:03:58Z

On 01/05/2026 04.00, Jakub Kicinski wrote:
> On Wed, 29 Apr 2026 19:20:32 +0200 hawk@kernel.org wrote:
>> A companion wrapper (veth_bql_test_virtme.sh) launches the test inside
>> a virtme-ng VM, with .config validation to prevent silent stalls.
>>
>> Usage:
>> sudo ./veth_bql_test.sh [--duration 300] [--nrules 100]
>> [--qdisc sfq] [--qdisc-opts '...']
>> [--bql-disable] [--normal-napi]
>> [--qdisc-replace]
>
> Not convinced we need to carry this in the tree.

I agree, I will drop the selftest in V4.

The selftest have been very useful during *development* phase.
The number of options also reveal that we (Jonas and I) have been using
this beyond a selftest. The veth_bql_test_virtme.sh wrapper have been a
huge help to accelerate test-based development cycles, but it's not a
selftest component per say. This have caught actual bugs in our BQL/DQL
API usage, but all those BUGs are fixed in code.

It makes a lot of sense to avoid having to maintain this code in tree.
I can place it somewhere on GitHub, else it can be pulled from lore.

--Jesper