From: Eric Dumazet <eric.dumazet@gmail.com>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Yang Guo <guoyang2@huawei.com>,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH] Revert "net: get rid of an signed integer overflow in ip_idents_reserve()"
Date: Fri, 26 Jul 2019 11:58:29 +0200 [thread overview]
Message-ID: <afa992f6-eb5e-8104-9a03-f992b184a6b6@gmail.com> (raw)
In-Reply-To: <1564132635-57634-1-git-send-email-zhangshaokun@hisilicon.com>
On 7/26/19 11:17 AM, Shaokun Zhang wrote:
> From: Yang Guo <guoyang2@huawei.com>
>
> There is an significant performance regression with the following
> commit-id <adb03115f459>
> ("net: get rid of an signed integer overflow in ip_idents_reserve()").
>
>
So, you jump around and took ownership of this issue, while some of us
are already working on it ?
Have you first checked that current UBSAN versions will not complain anymore ?
A revert adding back the original issue would be silly, performance of
benchmarks is nice but secondary.
next prev parent reply other threads:[~2019-07-26 9:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 9:17 [PATCH] Revert "net: get rid of an signed integer overflow in ip_idents_reserve()" Shaokun Zhang
2019-07-26 9:58 ` Eric Dumazet [this message]
2019-09-06 1:25 ` Shaokun Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afa992f6-eb5e-8104-9a03-f992b184a6b6@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=guoyang2@huawei.com \
--cc=jiri@resnulli.us \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox