From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03C3DC282C2 for ; Wed, 13 Feb 2019 18:17:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C2253222B6 for ; Wed, 13 Feb 2019 18:17:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550081869; bh=71O+fnodIpheBsnQQttvHbye3OawJPh/PUxXi2XaT6Y=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=qeSElhh7iTpHZfqlNAq86HKHLbjvW37aFqJJZl1H+UeVWApqZwjmxNnPq1bvxzmNe oCf9HjW0HBv7dlcPLt6gYRnzCYSnCKTEFEoUVavpNrOLhOMHQPp0iMAXyqbbat7EDe T6gt65puNA4cvPzYdGsumCBENv8Lfi6i7F5KrKdI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393650AbfBMSRt (ORCPT ); Wed, 13 Feb 2019 13:17:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:45672 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730697AbfBMSRs (ORCPT ); Wed, 13 Feb 2019 13:17:48 -0500 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 95D5821934; Wed, 13 Feb 2019 18:17:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550081867; bh=71O+fnodIpheBsnQQttvHbye3OawJPh/PUxXi2XaT6Y=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=MOBXDn4jOsEj91bjZXZkSD5HVlXqOruUMBkmmZrSBEf22WazexauuDlkG5y1OsRbE B0Q88HtMMypXRRL/OUEES/TUSc91iWhX6E9D1sdr0OdGLYUWGdQ7juys7CZ6DOqBdD 9Y8I6K/qb4YueDxca8T7J0I66+KX6uJMoia8NKZQ= Subject: Re: [PATCH net] selftests: fix timestamping Makefile To: Deepa Dinamani Cc: willemb@google.com, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, shuah References: <20190213170914.11991-1-deepa.kernel@gmail.com> From: shuah Message-ID: Date: Wed, 13 Feb 2019 11:17:34 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190213170914.11991-1-deepa.kernel@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/13/19 10:09 AM, Deepa Dinamani wrote: > The clean target in the makefile conflicts with the generic > kselftests lib.mk, and fails to properly remove the compiled > test programs. > > Remove the redundant rule, the TEST_GEN_FILES will be already > removed by the CLEAN macro in lib.mk. > > Signed-off-by: Deepa Dinamani > --- > > * Changes since v1: as per review comments > > tools/testing/selftests/networking/timestamping/Makefile | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tools/testing/selftests/networking/timestamping/Makefile b/tools/testing/selftests/networking/timestamping/Makefile > index 9050eeea5f5f..1de8bd8ccf5d 100644 > --- a/tools/testing/selftests/networking/timestamping/Makefile > +++ b/tools/testing/selftests/networking/timestamping/Makefile > @@ -9,6 +9,3 @@ all: $(TEST_PROGS) > top_srcdir = ../../../../.. > KSFT_KHDR_INSTALL := 1 > include ../../lib.mk > - > -clean: > - rm -fr $(TEST_GEN_FILES) > Thanks for the patch. Acked-by: Shuah Khan thanks, -- Shuah