From: Jason Wang <jasowang@redhat.com>
To: Sridhar Samudrala <sridhar.samudrala@intel.com>,
mst@redhat.com, stephen@networkplumber.org, davem@davemloft.net,
netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
virtio-dev@lists.oasis-open.org, jesse.brandeburg@intel.com,
alexander.h.duyck@intel.com, kubakici@wp.pl
Subject: Re: [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available
Date: Tue, 23 Jan 2018 18:33:59 +0800 [thread overview]
Message-ID: <afd11f19-6906-2a7e-1b82-e3138c4d9530@redhat.com> (raw)
In-Reply-To: <1515736720-39368-3-git-send-email-sridhar.samudrala@intel.com>
On 2018年01月12日 13:58, Sridhar Samudrala wrote:
> static netdev_tx_t start_xmit(struct sk_buff *skb, struct net_device *dev)
> {
> struct virtnet_info *vi = netdev_priv(dev);
> int qnum = skb_get_queue_mapping(skb);
> struct send_queue *sq = &vi->sq[qnum];
> + struct net_device *vf_netdev;
> int err;
> struct netdev_queue *txq = netdev_get_tx_queue(dev, qnum);
> bool kick = !skb->xmit_more;
> bool use_napi = sq->napi.weight;
>
> + /* If VF is present and up then redirect packets
> + * called with rcu_read_lock_bh
> + */
> + vf_netdev = rcu_dereference_bh(vi->vf_netdev);
> + if (vf_netdev && netif_running(vf_netdev) &&
> + !netpoll_tx_running(dev) &&
> + is_unicast_ether_addr(eth_hdr(skb)->h_dest))
> + return virtnet_vf_xmit(dev, vf_netdev, skb);
> +
A question here.
If I read the code correctly, all features were validated against virtio
instead VF before transmitting. This assumes VF's feature is a superset
of virtio, does this really work? Do we need to sanitize the feature
before joining? (e.g at last NETIF_R_GSO_ROBUST needs to be removed).
Thanks
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2018-01-23 10:33 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 5:58 [RFC PATCH net-next v2 0/2] Enable virtio to act as a backup for a passthru device Sridhar Samudrala
2018-01-12 5:58 ` [RFC PATCH net-next v2 1/2] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit Sridhar Samudrala
2018-01-17 18:15 ` Alexander Duyck
2018-01-17 19:02 ` [virtio-dev] " Michael S. Tsirkin
2018-01-17 19:25 ` Samudrala, Sridhar
2018-01-17 19:57 ` [virtio-dev] " Michael S. Tsirkin
2018-01-17 21:49 ` Alexander Duyck
2018-01-22 21:31 ` [virtio-dev] " Michael S. Tsirkin
2018-01-22 23:27 ` Samudrala, Sridhar
2018-01-23 0:02 ` Stephen Hemminger
2018-01-23 1:37 ` Samudrala, Sridhar
2018-01-23 0:05 ` Michael S. Tsirkin
2018-01-23 0:16 ` Jakub Kicinski
2018-01-23 0:47 ` Michael S. Tsirkin
2018-01-23 1:13 ` Jakub Kicinski
2018-01-23 1:23 ` Michael S. Tsirkin
2018-01-23 19:21 ` Jakub Kicinski
2018-01-23 1:34 ` Samudrala, Sridhar
2018-01-23 2:04 ` Michael S. Tsirkin
2018-01-23 3:36 ` [virtio-dev] " Alexander Duyck
2018-01-23 5:54 ` Samudrala, Sridhar
2018-01-23 23:01 ` Michael S. Tsirkin
2018-01-12 5:58 ` [RFC PATCH net-next v2 2/2] virtio_net: Extend virtio to use VF datapath when available Sridhar Samudrala
2018-01-22 20:27 ` Siwei Liu
2018-01-22 21:05 ` Samudrala, Sridhar
2018-01-23 19:53 ` Laine Stump
2018-01-22 21:41 ` Michael S. Tsirkin
2018-01-23 20:24 ` Siwei Liu
2018-01-23 22:58 ` Michael S. Tsirkin
2018-01-26 8:14 ` Siwei Liu
2018-01-26 16:51 ` Samudrala, Sridhar
2018-01-26 21:46 ` Siwei Liu
2018-01-26 22:14 ` [virtio-dev] " Michael S. Tsirkin
2018-01-26 22:47 ` Jakub Kicinski
2018-01-26 23:30 ` Samudrala, Sridhar
2018-01-27 2:30 ` Jakub Kicinski
2018-01-27 5:33 ` Samudrala, Sridhar
2018-01-27 5:58 ` Jakub Kicinski
2018-01-28 17:35 ` Alexander Duyck
2018-01-28 19:18 ` [virtio-dev] " Samudrala, Sridhar
2018-01-28 20:18 ` Alexander Duyck
2018-01-28 21:01 ` [virtio-dev] " Samudrala, Sridhar
2018-01-29 0:58 ` Alexander Duyck
2018-01-28 23:02 ` Stephen Hemminger
2018-01-29 4:26 ` Alexander Duyck
2018-01-29 18:24 ` Michael S. Tsirkin
2018-01-29 20:09 ` Alexander Duyck
2018-01-23 10:33 ` Jason Wang [this message]
2018-01-23 16:03 ` Samudrala, Sridhar
2018-01-29 3:32 ` Jason Wang
2018-01-26 16:58 ` Michael S. Tsirkin
2018-01-26 18:15 ` Samudrala, Sridhar
2018-01-12 5:58 ` [RFC PATCH 1/1] qemu: Introduce VIRTIO_NET_F_BACKUP feature bit to virtio_net Sridhar Samudrala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afd11f19-6906-2a7e-1b82-e3138c4d9530@redhat.com \
--to=jasowang@redhat.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=jesse.brandeburg@intel.com \
--cc=kubakici@wp.pl \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sridhar.samudrala@intel.com \
--cc=stephen@networkplumber.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).