From: "Desnes Augusto Nunes do Rosário" <desnesn@linux.vnet.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
tlfalcon@linux.vnet.ibm.com, jallen@linux.vnet.ibm.com,
nfont@linux.vnet.ibm.com
Subject: Re: [PATCH, net] ibmvnic: fix firmware version when no firmware level has been provided by the VIOS server
Date: Fri, 2 Feb 2018 12:34:25 -0200 [thread overview]
Message-ID: <afddeb9a-c4c7-97b4-b38e-f2ffc8d64a5c@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180201.145935.1511421104143236233.davem@davemloft.net>
Hello David,
Thank you for your review and the heads up about protocol.
On 02/01/2018 05:59 PM, David Miller wrote:
> From: Desnes Augusto Nunes do Rosario <desnesn@linux.vnet.ibm.com>
> Date: Thu, 1 Feb 2018 16:04:30 -0200
>
>> Older versions of VIOS servers do not send the firmware level in the VPD
>> buffer for the ibmvnic driver. Thus, not only the current message is mis-
>> leading but the firmware version in the ethtool will be NULL. Therefore,
>> this patch fixes the firmware string and its warning.
>>
>> Fixes: 4e6759be28e4 ("ibmvnic: Feature implementation of VPD for the ibmvnic driver")
>>
>> Signed-off-by: Desnes A. Nunes do Rosario <desnesn@linux.vnet.ibm.com>
>
> Applied.
>
> Please do not put empty lines between Fixes: and Signed-off-by: and other
> tags, all tags are equal and are placed together in an uninterrupted
> sequences of consequetive lines.
>
> Thank you.
>
--
Desnes Augusto Nunes do Rosário
------------------------------------------
Linux Developer - IBM / Brazil
M.Sc. in Electrical and Computer Engineering - UFRN
next prev parent reply other threads:[~2018-02-02 14:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 18:04 [PATCH, net] ibmvnic: fix firmware version when no firmware level has been provided by the VIOS server Desnes Augusto Nunes do Rosario
2018-02-01 19:59 ` David Miller
2018-02-02 14:34 ` Desnes Augusto Nunes do Rosário [this message]
2018-02-01 21:02 ` Tyrel Datwyler
2018-02-02 14:37 ` Desnes Augusto Nunes do Rosário
2018-02-02 17:55 ` Tyrel Datwyler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afddeb9a-c4c7-97b4-b38e-f2ffc8d64a5c@linux.vnet.ibm.com \
--to=desnesn@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=jallen@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=nfont@linux.vnet.ibm.com \
--cc=tlfalcon@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).