From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Desnes_Augusto_Nunes_do_Ros=c3=a1rio?= Subject: Re: [PATCH, net] ibmvnic: fix firmware version when no firmware level has been provided by the VIOS server Date: Fri, 2 Feb 2018 12:34:25 -0200 Message-ID: References: <20180201180430.16950-1-desnesn@linux.vnet.ibm.com> <20180201.145935.1511421104143236233.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, tlfalcon@linux.vnet.ibm.com, jallen@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com To: David Miller Return-path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:57992 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751469AbeBBOec (ORCPT ); Fri, 2 Feb 2018 09:34:32 -0500 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w12EXXc4045900 for ; Fri, 2 Feb 2018 09:34:31 -0500 Received: from e38.co.us.ibm.com (e38.co.us.ibm.com [32.97.110.159]) by mx0a-001b2d01.pphosted.com with ESMTP id 2fvsux81px-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 02 Feb 2018 09:34:31 -0500 Received: from localhost by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 2 Feb 2018 07:34:30 -0700 In-Reply-To: <20180201.145935.1511421104143236233.davem@davemloft.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: Hello David, Thank you for your review and the heads up about protocol. On 02/01/2018 05:59 PM, David Miller wrote: > From: Desnes Augusto Nunes do Rosario > Date: Thu, 1 Feb 2018 16:04:30 -0200 > >> Older versions of VIOS servers do not send the firmware level in the VPD >> buffer for the ibmvnic driver. Thus, not only the current message is mis- >> leading but the firmware version in the ethtool will be NULL. Therefore, >> this patch fixes the firmware string and its warning. >> >> Fixes: 4e6759be28e4 ("ibmvnic: Feature implementation of VPD for the ibmvnic driver") >> >> Signed-off-by: Desnes A. Nunes do Rosario > > Applied. > > Please do not put empty lines between Fixes: and Signed-off-by: and other > tags, all tags are equal and are placed together in an uninterrupted > sequences of consequetive lines. > > Thank you. > -- Desnes Augusto Nunes do Rosário ------------------------------------------ Linux Developer - IBM / Brazil M.Sc. in Electrical and Computer Engineering - UFRN