From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F228B2DC321 for ; Mon, 4 May 2026 07:21:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777879279; cv=none; b=Vdnt7RtFlvnZOAmjkR8r67VjFD+g+5EbpnIJjnTK6Pxl9NOvirqdhrmBTB8QV7FgWauoepde5xpfcKIopvKlq428lP4ULaWZwWUw4SwoRC2QeLRkh9zbYvUMVl/xmwk8PkHZHxWhSg6NqNY+J1pRtIojmqamkjMy1eKhfTnLwSs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777879279; c=relaxed/simple; bh=Q7I05WchKE/fXGbHEmNhvOymjgzLAabQER7PjYhbc/0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ir6wajKesEhsqQ9x0AlMkYq3+yii8uHorSy2el6po8IMZQ5vr2pg7apHxFiT6TbQuL8UREO1Ry4h109ukevfLZJXo+LbHqp4B16CD1SDqORMJrN5IZs7dDwU8FmUVFvQTR+tCtZoy5gBYhzd12bnEAkj4WGg0xFfKJ49K2ZEVj8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1wJnbv-0000pr-Ne; Mon, 04 May 2026 09:20:59 +0200 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wJnbs-000N2y-2r; Mon, 04 May 2026 09:20:57 +0200 Received: from ore by pty.whiteo.stw.pengutronix.de with local (Exim 4.98.2) (envelope-from ) id 1wJnbt-0000000GYf2-0sZJ; Mon, 04 May 2026 09:20:57 +0200 Date: Mon, 4 May 2026 09:20:57 +0200 From: Oleksij Rempel To: Markus Baier Cc: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , Ethan Nelson-Moore , Miaoqian Lin , linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: usb: asix: ax88772: re-add usbnet_link_change() in phylink callbacks Message-ID: References: <20260501163941.107668-1-Markus.Baier@soslab.tu-darmstadt.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260501163941.107668-1-Markus.Baier@soslab.tu-darmstadt.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org Hi Markus, On Fri, May 01, 2026 at 06:39:41PM +0200, Markus Baier wrote: > Commit e0bffe3e6894 ("net: asix: ax88772: migrate to phylink") replaced > the asix_adjust_link() PHY callback with phylink's mac_link_up() and > mac_link_down() handlers, but did not carry over the usbnet_link_change() > notification that commit 805206e66fab ("net: asix: fix "can't send until > first packet is send" issue") had added. > > As a result, the original symptom returns: when the link comes up, > usbnet is never notified, so the RX URB submission stays dormant until > some other event (e.g. a transmitted packet triggering the status > endpoint interrupt) wakes it up. > > This is reproducible with the Apple A1277 USB Ethernet Adapter > (05ac:1402, AX88772A based) on a Banana Pro using a static IPv4 > configuration. After bringing the interface up, no incoming packets are > received until the first outgoing frame triggers usbnet's RX path. > > Restore the link change notification, gated on a carrier transition so > the call remains idempotent if the status endpoint also reports the > change later. > > Fixes: e0bffe3e6894 ("net: asix: ax88772: migrate to phylink") > Assisted-by: Claude:claude-opus-4-7 > Signed-off-by: Markus Baier I did some limited testing on AX88772C. Seems to work without regressions: Tested-by: Oleksij Rempel Sashiko suggests to update commit message: https://sashiko.dev/#/patchset/20260501163941.107668-1-Markus.Baier%40soslab.tu-darmstadt.de Thank you! Best Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |