From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>
Subject: Re: [PATCH net-next] net: usb: mcs7830: fix typo in module description and clarify it
Date: Tue, 5 May 2026 09:43:22 +0300 [thread overview]
Message-ID: <afmRigJK0yPrJZYy@ashevche-desk.local> (raw)
In-Reply-To: <20260505013504.45975-1-enelsonmoore@gmail.com>
On Mon, May 04, 2026 at 06:34:59PM -0700, Ethan Nelson-Moore wrote:
> The mcs7830 driver's MODULE_DESCRIPTION has an errant parenthesis
MODULE_DESCRIPTION()
> and does not indicate that the device is an Ethernet adapter. Remove
> the parenthesis and improve the description.
...
> -MODULE_DESCRIPTION("USB to network adapter MCS7830)");
> +MODULE_DESCRIPTION("MCS7830 USB to Ethernet adapter driver");
It's better to align this with the top comment
* MOSCHIP MCS7830 based (7730/7830/7832) USB 2.0 Ethernet Devices
Another option is to align to Kconfig help
tristate "MosChip MCS7830 based Ethernet adapters"
(ideally all three should be the same).
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-05-05 6:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 1:34 [PATCH net-next] net: usb: mcs7830: fix typo in module description and clarify it Ethan Nelson-Moore
2026-05-05 6:43 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afmRigJK0yPrJZYy@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=enelsonmoore@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox