From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from flow-a3-smtp.messagingengine.com (flow-a3-smtp.messagingengine.com [103.168.172.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 772B63CAE70; Thu, 7 May 2026 10:13:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.138 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778148842; cv=none; b=A6D6Fm7I3veO64Lm6i1ulYT/uf5CNnowbtd6Wvj77T9vyj7vHdr6fFLIC/4ClVAQ+1e2z9fsC+2oCIkKO1HeJyX7Vxg3EYJlcxC5mmZqLhCsbYEoW6EjmCJTgE4/UYaz4DUHhruixiwfLLGmtNvsw+nL5qZm+lZiBawaPxWsInM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778148842; c=relaxed/simple; bh=Pduj4URnW69trNA43ahMRzfHJFsP5v1YTGwtCVEOylc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jPtUzEe5m4Q7RAjUXjrk2Res95Gc7wmIogPoig7sjxFCEnInYcqj6SuToQOpaI5areETU2UA4zlOv7R7fI9KPAR2gTjsfquUXBFKe9kb81vl6MqDQb5wtSchW03JkLZ/UWqoclWa0lI9hnyCjCDUH3pl18HwfGJYEqFnnaFFbAo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net; spf=pass smtp.mailfrom=queasysnail.net; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b=P2UFzXu7; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=Sy9W1BhA; arc=none smtp.client-ip=103.168.172.138 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b="P2UFzXu7"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Sy9W1BhA" Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailflow.phl.internal (Postfix) with ESMTP id D464713803BC; Thu, 7 May 2026 06:13:57 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Thu, 07 May 2026 06:13:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=queasysnail.net; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1778148837; x= 1778156037; bh=3FFUwq2v3e8bOgdMOV9uftE2p5x+Umzu6kxFgcUWFEc=; b=P 2UFzXu7W9rgKh3ENHsVU8C5GXS9sWGE52PpxjB/wjbBsbAP0aMPNsnydBmPQrGz2 Nd94z2/lCLK/5ZCLsocZpdlkF9PwsevLWDhAIm/KV+p8bbiA38DoJj5i+Mgp6GcR ZgmC9Slj3Q+LmFpUO5SudQZ0kCOyR32uftdiWAEpFAoQgyFr+Luc7EBJ/owNBXjT H0PMkUkd/H0dxla7X9yflJqTz4wgLvgccvQVIs2J36KKB5U9l80IVbG1vZ/YiT4x 0VdMg+VXDutnIxA4XoLCpOdHelxCIw8oQ8FNNzLsy+r+ldx4Gv1zmk824K0TFA/c z8q113eq7+bsH80bStjhw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1778148837; x=1778156037; bh=3FFUwq2v3e8bOgdMOV9uftE2p5x+Umzu6kx FgcUWFEc=; b=Sy9W1BhARSXvwYpzXiI8J2Hc8eNBNFHQZPs22vkmcNx/haidZGk Fj0qEQb+dJ7mVT8vWdk8fP8LACJEfHV0d3CqgI9mBUE57ewShNZpBxkE54wsZoA2 C/+tMmw8ZQJsaYGM9rRZcDyb20cSGWHGaLcK/XQuQuEEPr9PSs7qG2YEKeW3je0+ PtfcD1mUCXakPWfuXf5X8E7m0px1LwxIZsv3gP5DN/GGgssT5AQeZVypPLZdABD0 G8cWBz3VBIMzIgZbXpQCj9aqEFgG9xYwKJ4hgJ9PpRupexwwJKipLOy03dSnZzYL HXDkCtj8y7UXwAZB7VodCUS7OD3QavoCWIw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgddutdejvddtucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujgesthdtredttddtjeenucfhrhhomhepufgrsghrihhn rgcuffhusghrohgtrgcuoehsugesqhhuvggrshihshhnrghilhdrnhgvtheqnecuggftrf grthhtvghrnhepuefhhfffgfffhfefueeiudegtdefhfekgeetheegheeifffguedvueff fefgudffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epshgusehquhgvrghshihsnhgrihhlrdhnvghtpdhnsggprhgtphhtthhopedvvddpmhho uggvpehsmhhtphhouhhtpdhrtghpthhtohepshhtvghffhgvnhdrkhhlrghsshgvrhhtse hsvggtuhhnvghtrdgtohhmpdhrtghpthhtoheprghnthhonhihrdgrnhhtohhnhiesshgv tghunhgvthdrtghomhdprhgtphhtthhopehhvghrsggvrhhtsehgohhnughorhdrrghprg hnrgdrohhrghdrrghupdhrtghpthhtohepuggrvhgvmhesuggrvhgvmhhlohhfthdrnhgv thdprhgtphhtthhopegvughumhgriigvthesghhoohhglhgvrdgtohhmpdhrtghpthhtoh epkhhusggrsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehprggsvghnihesrhgvughh rghtrdgtohhmpdhrtghpthhtohephhhorhhmsheskhgvrhhnvghlrdhorhhgpdhrtghpth htohepughsrghhvghrnheskhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: i934648bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 7 May 2026 06:13:56 -0400 (EDT) Date: Thu, 7 May 2026 12:13:55 +0200 From: Sabrina Dubroca To: Steffen Klassert Cc: Antony Antony , Herbert Xu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , David Ahern , Masahide NAKAMURA , Paul Moore , Stephen Smalley , Ondrej Mosnacek , Jonathan Corbet , Shuah Khan , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, selinux@vger.kernel.org, linux-doc@vger.kernel.org, Chiachang Wang , Yan Yan , devel@linux-ipsec.org Subject: Re: [PATCH ipsec-next v8 04/14] xfrm: fix NAT-related field inheritance in SA migration Message-ID: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: 2026-05-07, 11:56:58 +0200, Steffen Klassert wrote: > On Thu, May 07, 2026 at 11:33:09AM +0200, Sabrina Dubroca wrote: > > 2026-05-05, 06:32:43 +0200, Antony Antony wrote: > > > During SA migration via xfrm_state_clone_and_setup(), > > > nat_keepalive_interval was silently dropped and never copied to the new > > > SA. mapping_maxage was unconditionally copied even when migrating to a > > > non-encapsulated SA. > > > > mapping_maxage should be harmless (0/unused on non-encap), but I think > > migrating nat_keepalive_interval should be considered a fix: > > > > Fixes: f531d13bdfe3 ("xfrm: support sending NAT keepalives in ESP in UDP states") > > > > (maybe even split out of this series, but that would cause a conflict > > with the previous patch) > > Can this be backported without the previous patches? > If not, we might need to split it out. git cherry-pick managed to handle the small context change, so it's probably fine like this. -- Sabrina