From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B21DF3FB7FB for ; Thu, 7 May 2026 14:23:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778163829; cv=none; b=fSo9+gQcmncaCKZ4VsFwL8xx8Ej77EJia+L+UfC/hf10V2JOCIT16hVFHamVWaWXtGsZ9Ntb9VU8QS21rnSG8sSHnRMd+dc0jqHJfwlX9L9O6kDJzzArPOobjKItqlP4KOxqW5obx4YjHx0Qco+YNJB3aVJGUwMxQYsoVRKXW9o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778163829; c=relaxed/simple; bh=9PPgK4QLRSfTOdseskC5krVmq0BpGiNeGu5HCLmSg74=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=emzg2Q69iUIXF16+Q9PbtGdxhhxvtzNtCxMBnBwGlAh8Wt6UkIt3uPUoFynK8iLVgJwYEmLeY7jWZgjT9vYh7XN3l6Jk3owfG3kgvwOPxAmEBVaaKm4yoHfglfmXqXH26LyloKgGZRqDAAPIS6K8mS4499hcHw2eXYhVcDDwYIQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=FkhbCI6+; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="FkhbCI6+" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4852a9c6309so8131425e9.0 for ; Thu, 07 May 2026 07:23:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1778163825; x=1778768625; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KHdHPIlg8ERzV5KgqRTDZ9XRFXSHKLYAiHw6AYH9eg4=; b=FkhbCI6+5iGRjZDWKXPWkgyGSB1Rtp2FJO25fv5YVM16EJDf3nQ5DeNsCnKRIgo1XU uYA8+soz4vGtGZuuTPHPPzyTCxMA8S/u3Jvv4OyRF2C0E4r+JlNe1O18B9vI1CnKstde tLkvxSE+Hmnm8QuomilBsAonXLuiPktzZIyoFhJMUnyyTWtGKVk2/ti8+5wSakHBTh/7 cDqssVgVtg5yEpeaFOgOlWn4Zg59DYfOH/bGBAkGbB7Xe3xnuyT3XgkLtxweJel+Vt+y j1NhpAGJf9fnl/RVWEPYVHjuxpH/ju12RbWfGCzFUsNxu+Ao2910f8UhhE05burJWSmZ OUNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778163825; x=1778768625; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KHdHPIlg8ERzV5KgqRTDZ9XRFXSHKLYAiHw6AYH9eg4=; b=Z7hsuc3uXlOCAQiMelXSqZBk6+VCrYx2jpDY97YiHrVIMtl+rRm6WdiHNl1hp/1+b/ rr5KDaR7y6ayNzL7a9w/aPY9xjqCCfIMKir93gRzRzZqZ4od6s1GM4pUg7j8ybftA5FT yWf4leVPHpQ8guYvlCtFioPbAlO1gb+q026pgHajCjC9U59qt12NFf+wtoog5xJZOpIG XVeInD1ZLMKN/JHPlJqlHnTpXAKmBSp85OqHbFb75GbgJa8/YPKst41EgMHA4JLBvlYR aJJkQDQTBd1NZoP1hjh/W8uCMguYCyXQI5zqTXtHVA+E9HmuNDdQUZ4W+dLTgR9rtrYT kNvw== X-Forwarded-Encrypted: i=1; AFNElJ+VsTBaQhtVt+jYVh3KImp6LJebsd4AJaIIDadVBNrE/ISP56GYE8UfiFM5vJ0uTssHJqt7DwU=@vger.kernel.org X-Gm-Message-State: AOJu0YxFkBCfCGSNtg+PaQ331s8tPbRkpJglsLuMSuDdjmmrUbSEAji6 dW0CNZd8tTGjA/Y2UVLuszXfDt5KmIU7IeI1TTg2IiA88KDuw/6QOQaWDF82zwKHqgI= X-Gm-Gg: AeBDiev0gAO/d4W57wrrtaCZTj4oa5YSv7rS9bHWxGOC+QdWyiOvk/XrUz5D+dGPb7e Vt1XmXE8ewIC5ak27fDSUbauMPC4whkDTpIpL0dlTTmz/RU9/2aZ5+xBDycD60xAV+GGuzGnAlw cMMQbDH6JI7ttof8kdOULwy3BFz10il5aINJOWnbz0oC9xYL9XZ6zt3cxnA66LJ+3ET03pJrveG SksyvhoAHdv9a4GzTefwBue+iPJ2SzPa62Fmw+HK2GyfKTvWw7f+SfN24ulrdw+wHP3n2Tjkdo1 E4CQEoup418MmKDT2hIS/mt6vY2M3/+UBgArqqo22w7PLP0ypgERxkQ3bluEIJ3qiprp5lsTLYJ AYpYAYOVENiLA1UtJHoFY3bdv02xxtoX3CnKz0MyCCeAvEpwz82zfIgfcQC5fx16hfShItk664h RQk0RNXrSybsJLcssUPtQ3sn4XiJFxoYG6HW88tOaqhccEFH8oZmX+TIgfEr6P0+dRoS6nMwVFz Drprd3QGOkKJNwEnx52RsZKaAwDdp7zC8a4 X-Received: by 2002:a05:600c:628e:b0:48e:60a3:220a with SMTP id 5b1f17b1804b1-48e60a32224mr33559005e9.0.1778163825055; Thu, 07 May 2026 07:23:45 -0700 (PDT) Received: from localhost (p200300f65f114e08e9fd60f450b139aa.dip0.t-ipconnect.de. [2003:f6:5f11:4e08:e9fd:60f4:50b1:39aa]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-48e538a8159sm137501655e9.6.2026.05.07.07.23.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 07:23:44 -0700 (PDT) Date: Thu, 7 May 2026 16:23:43 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Marc Kleine-Budde Cc: Michael Grzeschik , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vincent Mailhol , Krzysztof Halasa , Johannes Berg , Steffen Klassert , David Dillow , Ion Badulescu , Mark Einon , Rasesh Mody , GR-Linux-NIC-Dev@marvell.com, Manish Chopra , Potnuri Bharat Teja , Denis Kirjanov , Jijie Shao , Jian Shen , Cai Huoqing , Fan Gong , Tony Nguyen , Przemek Kitszel , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Mark Bloch , Ido Schimmel , Petr Machata , Yibo Dong , Heiner Kallweit , nic_swsd@realtek.com, Jiri Pirko , Francois Romieu , Daniele Venzano , Samuel Chessman , Jiawen Wu , Mengyuan Lou , Kevin Curtis , Arend van Spriel , Stanislav Yakovlev , Richard Cochran , Kees Cook , Aleksandr Loktionov , Thomas Gleixner , Jacob Keller , Thomas Fourier , Ingo Molnar , Kory Maincent , Zilin Guan , Vadim Fedorenko , Marco Crivellari , Bjorn Helgaas , David Arinzon , Yeounsu Moon , Denis Benato , Yonglong Liu , Andy Shevchenko , Randy Dunlap , Yicong Hui , MD Danish Anwar , Nathan Chancellor , Ethan Nelson-Moore , Larysa Zaremba , Ian Lin , Colin Ian King , Double Lo , Markus Schneider-Pargmann , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-can@vger.kernel.org, linux-parisc@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, oss-drivers@corigine.com, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com Subject: Re: [PATCH net-next v2 1/2] net: Consistently define pci_device_ids using named initializers Message-ID: References: <76da4f44d48bdde84580963862bf9616bee5c9e9.1778149923.git.u.kleine-koenig@baylibre.com> <20260507-healthy-gainful-fox-500552-mkl@pengutronix.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2r3luua3e55dgqvk" Content-Disposition: inline In-Reply-To: <20260507-healthy-gainful-fox-500552-mkl@pengutronix.de> --2r3luua3e55dgqvk Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH net-next v2 1/2] net: Consistently define pci_device_ids using named initializers MIME-Version: 1.0 Hello Marc, On Thu, May 07, 2026 at 12:55:45PM +0200, Marc Kleine-Budde wrote: > > + }, { > > /* ASEM Dual CAN raw -new model */ > > - ASEM_RAW_CAN_VENDOR_ID, ASEM_RAW_CAN_DEVICE_ID, > > - ASEM_RAW_CAN_SUB_VENDOR_ID, ASEM_RAW_CAN_SUB_DEVICE_ID_BIS, > > - 0, 0, > > - (kernel_ulong_t)&plx_pci_card_info_asem_dual_can > > + PCI_DEVICE_SUB(ASEM_RAW_CAN_VENDOR_ID, ASEM_RAW_CAN_DEVICE_ID, > > + ASEM_RAW_CAN_SUB_VENDOR_ID, ASEM_RAW_CAN_SUB_DEVICE_ID_BIS), > > + .driver_data =3D (kernel_ulong_t)&plx_pci_card_info_asem_dual_can, > > }, > > - { 0,} > > + { } >=20 > Nitpick: can you convert the terminating entry to follow the same style > as the rest of the driver: >=20 > diff --git a/drivers/net/can/sja1000/plx_pci.c b/drivers/net/can/sja1000/= plx_pci.c > index a03553b80a5d..d69ff0ccfd94 100644 > --- a/drivers/net/can/sja1000/plx_pci.c > +++ b/drivers/net/can/sja1000/plx_pci.c > @@ -353,8 +353,8 @@ static const struct pci_device_id plx_pci_tbl[] =3D { > PCI_DEVICE_SUB(ASEM_RAW_CAN_VENDOR_ID, ASEM_RAW_CAN_DEVI= CE_ID, > ASEM_RAW_CAN_SUB_VENDOR_ID, ASEM_RAW_CAN_= SUB_DEVICE_ID_BIS), > .driver_data =3D (kernel_ulong_t)&plx_pci_card_info_asem= _dual_can, > - }, > - { } > + }, { > + } > }; > MODULE_DEVICE_TABLE(pci, plx_pci_tbl); After the conversation in the v1 thread it was unclear to me if you stand by your opinion, so I kept the format as it was. I interpret your repetition of the nitpick as request to rework the can drivers for the next revision (if that happens). Best regards Uwe --2r3luua3e55dgqvk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmn8oGwACgkQj4D7WH0S /k5magf/eyQ23u39ybxkW2OdbwK59q0fpRutP/sxrKWuT6tv8V2fFyOeuGTCjF38 S+nSwmuH/rU1tyi6cJiCBx8U/lrBqlri55tfqDeMMmEdaTgDx/f8rLh5gw/OXR6w iiW3jwdOchqKMQAWW0XFekrRumOxBYByCEve5jEyzQwjs4cggMP+GUBgYLi9VMsu p0EMeC469BJE9KTtF0MQoLVR4xXQebXlYBWyCtn6NXuHOWYlZbFW4NYx1YQADQGM vg8UmTZiP5QB08RryLszWVJxAzMjkvPj8VPLDjxs5zDqJDt6Zbm3G+mNqj3JHLlV t3qw6OQQis3J/F/BMUIXdtL08Ss0JA== =i/K5 -----END PGP SIGNATURE----- --2r3luua3e55dgqvk--