From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78E1A3F54AD for ; Thu, 7 May 2026 15:39:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778168347; cv=none; b=tZWVDF3epn6q6P3sBbA2YTuD3L4obeezXuYkFfDyp266SbTTI1MpdyCW1De2MSO4E2qOr2GFIzqzBaPR91Ufs9FTur3AXlzfWeA4Zja35YMp3tTUtf3YrLLuOHUL8E/Kf5gacr5rELdcVW8h50k0H8WLMf3VhmHCTBUPUz8xan4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778168347; c=relaxed/simple; bh=I7bHVcUPCbFavnPQE9NIAPWTbSlQISkdMWu7R9FX+Ss=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bZvYyCAF6QpVe6qR97mZIJ/ddFWd584bJbFN/tyoXrEemgOCH7JIQ4cO1Mi5TnbZFojbRCDQjMhbzyVNsiHWvGwiWjOr4zcc0sKRTsqAGNfvMJCozqmIE5fJZ28bQxn6k1v/HcfBMc0V8JBjwEa3L3NBMP/IGDZIvdgdXB234uo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lELMVwd2; arc=none smtp.client-ip=209.85.222.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lELMVwd2" Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-8ef2118b478so100241885a.0 for ; Thu, 07 May 2026 08:39:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778168344; x=1778773144; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hQASz0K9bAEWsvTANOg3uGMuZOgruzesi2JgdTAVAkE=; b=lELMVwd2v+v3Y2UjmN0rjzuYIZkTeRK8VqQUHf+rI68gGfgcG8NCRLWnzDSU7Ejg3a Fkw6my+S6bAF/4E4hCUawNWJPvhr1TNcPhPRWjqkvLDfn3aOBNptDGyNH86WSvyJo283 sWtpk53zfbttBN4gwE+xdhjPtewc4RWBahS89D/lN22YvuzFwhbBxwkjAQV+wl+AgeCk lXNzb4qXqs00gTDv0uytVS0ClClxoEGzxVnEniq0d3y4Gw9GHs0fmfn66iThHtOpR7TJ l3wCy1J1YODPtn2r0c+N3ZstW4mN3WeMU4SFG3zlY2trp4eE2dESUXTSK8mMG8ZRqvme 3PWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778168344; x=1778773144; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hQASz0K9bAEWsvTANOg3uGMuZOgruzesi2JgdTAVAkE=; b=cyIhPdK8MYAD1V/ZBnyFbsR/Ge01+gvE6wk5p1a5eeES28tJLCtt/cdtGl6kqZIeMX vD5l0A4qYPm4QfKCuSTRr/jPp3fHuYikgNIow7iF0X9a4qQyrnQBfaYjXC1OkWc/4wTy 769URWEaLsLO9vP2G1VmlJ/YCeg7Q5Q+2uxGnqMpkJv7GQzGvU+BxokIIIjNGBOpFBu7 iYEfZsIC/5IwDPgL/dGnmAcW5ruvh6ApvjFUHBe9N6UJVrl0EYq/jBEGka6XZP22djBA grFo5P4nlHALl6dr1qJXCbtXzVsInNMafp2Kwh5P1VvG8c00Vh9hRbf54SWvzYU28RjT s2tQ== X-Forwarded-Encrypted: i=1; AFNElJ+VK0oZfkN0d2rthPkP95yBsjdskvUEDw3mQKbLyiEf0y8QGZPPyWzVx5ILYAk0xzGM6HYfgTI=@vger.kernel.org X-Gm-Message-State: AOJu0YzCF06GyQ+pCC6i6hVy9Su7u3l+9vZbYjuqdLi251mv96hNg0Z5 kUpPU+pMMm05KZk9xqfd0XG5zCI248Rli43QLkenHoSTHXk33mqKvQo0 X-Gm-Gg: AeBDiesRvpotSR58xKJ6S+cYU+mILNp9IsxRGIReB99AwfLl0Qwj9NLjT+m5RbzANFf +sSQl56Unt7UfPshb/xV0Qng8aSrDMoMmOe5xcG5Sc2oL8gsR4mH2IG3BHtZUrKghSrJ7P0556f CYcrMPKMirzWh4dmPKj3hdcs3KHylEyacEn0w1uFSTG2ATw30uAAC1JAUDIUEA5smM2GvWcNDWm TAwA09UDSo07uBpsyOC17EyEdEYLWeZ9takr1Q0+c/reYtM7T+FVrS+KCYuDtZB9vXuvOudIO1W upSbapKoVIUPhwmkLnv/IIuXgw61A31MGqUqM/mnHJDxxyomtLYZ4BRUl5h3F7YIlmYIaxc4bKS 6cNoc26sMOaEfZ8s+aOZ5d3/FX6koaFjbbOoeT//jKYKizcug311wI+1/NHTV4rYz9K/RSK7V7Z cnrYTz93EB6E18gB3qoD7RpCKd9bnDBM1t+aQrHxghjetcqgQ88CVRYb1INA== X-Received: by 2002:a05:620a:440f:b0:8ed:11b9:1ecb with SMTP id af79cd13be357-904d4b58929mr1205520185a.20.1778168344205; Thu, 07 May 2026 08:39:04 -0700 (PDT) Received: from devvm29614.prn0.facebook.com ([2a03:2880:f800:13::]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8fc293837b5sm2153539785a.10.2026.05.07.08.38.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 08:39:02 -0700 (PDT) Date: Thu, 7 May 2026 08:38:56 -0700 From: Bobby Eshleman To: Jakub Kicinski Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Jonathan Corbet , Shuah Khan , Alex Shi , Yanteng Si , Dongliang Mu , Michael Chan , Pavan Chebbi , Joshua Washington , Harshitha Ramamurthy , Saeed Mahameed , Tariq Toukan , Mark Bloch , Leon Romanovsky , Alexander Duyck , kernel-team@meta.com, Daniel Borkmann , Nikolay Aleksandrov , Shuah Khan , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, Stanislav Fomichev , Mina Almasry , Bobby Eshleman Subject: Re: [PATCH net-next v2 2/6] net: devmem: support TX over NETMEM_TX_NO_DMA devices Message-ID: References: <20260504-tcp-dm-netkit-v2-0-56d52ac72fd4@meta.com> <20260504-tcp-dm-netkit-v2-2-56d52ac72fd4@meta.com> <20260506193420.575e1806@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260506193420.575e1806@kernel.org> On Wed, May 06, 2026 at 07:34:20PM -0700, Jakub Kicinski wrote: > On Mon, 04 May 2026 17:27:49 -0700 Bobby Eshleman wrote: > > + if (bind_dev != netdev) > > + netdev_lock(bind_dev); > > + dma_dev = netdev_queue_get_dma_dev(bind_dev, 0, NETDEV_QUEUE_TYPE_TX); > > + if (bind_dev != netdev) > > + netdev_unlock(bind_dev); > > + binding = net_devmem_bind_dmabuf(bind_dev, > > + bind_dev != netdev ? netdev : NULL, > > + dma_dev, DMA_TO_DEVICE, dmabuf_fd, > > + priv, info->extack); > > Not sure if it matters but are we intentionally releasing the bind_dev > lock before calling net_devmem_bind_dmabuf() ? Previously more code here > was covered by the physical netdev's lock. True, lock needs to be held at least until after binding. I have this fixed in the next rev. Best, Bobby