From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73B9E388E72 for ; Sun, 10 May 2026 16:48:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778431725; cv=none; b=H5rcjwfc1GGFs0C9xsPUrTxIWldgV17YhtxeXYpZ3EHIIDso/Hd8NrPVKKq7YS45uF2e6crB11BXM0jnOWSRwWWXuzxVuMuOEVmH3BT2Ud1RVtNkEzmq/7q4u0SU07m4sbT4S4jvYSkpOnA6XtsIwA6NJ3w2pr8BsC9xzHljIHQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778431725; c=relaxed/simple; bh=SaRV1teEcYuK3pDM4kjkaHnrIO71cSDF/PbaaMnoYTc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pN5sJxTG2JtJZZOhPsqNs8eFE0//qIcnzA/wLjuMzrMVqXv/aHFQyd/hcKECyFFKpb/tqyTiL4xTF59WEmNYeOEmQDrlAc3hlERS1jGoy37/aOKwFgHE+TISC69GkpUZ1ZbMCmmWsRck93IOQjo+PTSJG9X6vgD1jszLlV6p59Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JaGaJsVR; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JaGaJsVR" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-367c2a39fcfso751689a91.3 for ; Sun, 10 May 2026 09:48:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778431724; x=1779036524; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eArBLCmYCsffvtaqVgZP4cXQn2AO6g/xQoo/oq6NlGs=; b=JaGaJsVRMIl2RcXQ5IAKLq1GFZwBXqvT93Ih88vKuq3hbLbu0apXjA4jhNUyEBj7rh mfyj4XvmgZ15Cr9LHVW06Lr+LGKhSVcCv8ALLB+rnQaaIO4SuQaqH53uJwn7i0nqYpr7 b2lXFomRktDpMBgaCvAA4kP9CGW/Gnl1ZM6TvcRV7cI8d5LkQeiI8cMcXc/oZ6XjFqY2 6stj+0Z+aTamVZPkbGrO74GedOFqWNgz0W+omL5VdjrDEHGG76XMjl2GbW3RkYgKciaj S/y0j2SQOlrwYcVujdTu+oWjAoh4jSAySswig+qH2spOkIlwq5QZ2ftics8kQIGMoe8P 0iOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778431724; x=1779036524; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eArBLCmYCsffvtaqVgZP4cXQn2AO6g/xQoo/oq6NlGs=; b=LHUNcZ+4HS+buLp9+FoMsA+oHLEGVey2/Ns8phADY2wbFzHqcIvUsNA9ul5Nvt6oFg JwatqUKB1xizZgBpjmtEsFBkiDi7NyypwPInSYVJileq8tkfJ/eZ8z5+Kgss/l6E3w3P +8bXHbJ5+sRUscXEx1Vw6K4GePMUGQlUovLt8XSQFs+uA6zRvN0QHtIaPjKimNlRL8sQ 922FDmIQdc9LPAATajY0nRvoM/Tesrkbyxx40EzAKqN3T8HmVRl3CeL4pk5NffsnQfo1 xkoCNmqCiWrxDm0R0HpUUhGLJ60xPttKykeo3vIznj+9NUOqmmtAU7L+vNyShvbEnb9N sCSQ== X-Forwarded-Encrypted: i=1; AFNElJ9Wz2TXS1PYuzdgYY372dNBOmhznN9CMxIk0qajBcViqIU6gdP7AHEDhN4+iYdtTG/XZwwvU40=@vger.kernel.org X-Gm-Message-State: AOJu0YwioohlW4WqFh3Fs0OK7UaQLnqq+AG96s11Ry658TEtJDNtln25 Q+ZuVcShfdwQLXolQJMf9iH6v1/DkCZQAbSZqvV9unlcIZmymzqJc/Y6 X-Gm-Gg: Acq92OHhKLo2auH0V9KhFlpdH1JkDRunXt6MTN56z/lD1RlJp2lgijioBdXTQ0RVHPx KmBE1apZnSU5kE2xWPSOIN9dJ7QZ1VHb73yqSGmtqx7VZtqNzRzvUmfurzROAHFnWaC8lsaUWFa zIbRrMMHQrWb4AAebnODtRuCl27LEomaUlAp4ZQg2kao1SaR5gqNJ5/iG1LXHlrAjFtrphttMcP 8Blou9ZiWs/EE4XFFsGfGbmlk1I5/Zh3p9G5pUPRZPVD4y3g+XQ15z8RUMy+LBRye1UBkaWvVkk 8VKtlV6XVwUvWKJpauLlkjZoOGiCVW3cdQGXEXpc9j4+ltLgqj8Ld3pMQSr4vpp1K9O6TCon1AP /gvQ2bCtFIqdSTF8JTIzP82kHIDhBBeMcAU1ffd9vh4rp07/3UYIErHJp2PrWQq1ROi643LjkJ0 mrqPgQulRSO/3MGCtHJZa0Bp065aIw6R4AztRR7DIH2SotYJZVg+dXgw== X-Received: by 2002:a17:903:9ce:b0:2ba:b5a3:1864 with SMTP id d9443c01a7336-2bab5a3210bmr186878225ad.20.1778431723638; Sun, 10 May 2026 09:48:43 -0700 (PDT) Received: from v4bel ([58.123.110.97]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1eac3afsm83382135ad.71.2026.05.10.09.48.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 May 2026 09:48:43 -0700 (PDT) Date: Mon, 11 May 2026 01:48:39 +0900 From: Hyunwoo Kim To: Jakub Kicinski Cc: dhowells@redhat.com, marc.dionne@auristor.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, horms@kernel.org, qingfang.deng@linux.dev, jiayuan.chen@linux.dev, linux-afs@lists.infradead.org, netdev@vger.kernel.org, stable@vger.kernel.org, imv4bel@gmail.com Subject: Re: [PATCH net v3] rxrpc: Also unshare DATA/RESPONSE packets when paged frags are present Message-ID: References: <20260510084520.476745b5@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260510084520.476745b5@kernel.org> On Sun, May 10, 2026 at 08:45:20AM -0700, Jakub Kicinski wrote: > On Fri, 8 May 2026 17:53:09 +0900 Hyunwoo Kim wrote: > > sp->hdr.securityIndex != 0 && > > - skb_cloned(skb)) { > > + (skb_cloned(skb) || > > + skb_has_frag_list(skb) || > > + skb_has_shared_frag(skb))) { > > We seem to be getting a lot of fixes for this issue, and this one is > incorrect :| Writing to _any_ frags is incorrect. You have to copy > if skb is not linear. skb_ensure_writable() I was testing a patch based on skb_ensure_writable() but it seems v3 has just been merged to mainline... What would be the best way to proceed? Best regards, Hyunwoo Kim