From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.secunet.com (mx1.secunet.com [62.96.220.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CACEC344DB5 for ; Mon, 11 May 2026 10:02:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.96.220.36 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778493738; cv=none; b=F4x+d2klTuothe1HKoNrdkXPRkLuKMjOcn/cH2BOI5KoijDZEZ1KS9cCe7VmKFVkaQ7BsHC5StEWKZS1YCZZQ2i967nR0OeEQKMy1ow7IrEQvFmqTVKIhOJXHMgTO0yocsxkPDWXsRIVX/OB7m9mdpJrVGy0F51FBrXgmEUnyyM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778493738; c=relaxed/simple; bh=gxr9pavRElNh7wh4l2v6vm1riscc6vcnj4mRFG36syM=; h=Date:From:To:CC:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=U1iVfuZ5qFlG0HMUuvl60lZc4RZGi60W3fFNsqdwQX7Ar9GLXsqImJPOx0YqZuAWYVLj0Dhc1gerkDWphfAT9JCoLC4lJ/EBjs+UuLsz0TRwJRxg2FTNtVa3M/0PgLZODjqMLhl2Jf+GYTVOqF+Di5KeY+lkgXHvOlAjr4kPm3A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=secunet.com; spf=pass smtp.mailfrom=secunet.com; dkim=pass (2048-bit key) header.d=secunet.com header.i=@secunet.com header.b=zlbMpr/M; arc=none smtp.client-ip=62.96.220.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=secunet.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=secunet.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=secunet.com header.i=@secunet.com header.b="zlbMpr/M" Received: from localhost (localhost [127.0.0.1]) by mx1.secunet.com (Postfix) with ESMTP id 68CAA20704; Mon, 11 May 2026 12:02:08 +0200 (CEST) X-Virus-Scanned: by secunet Received: from mx1.secunet.com ([127.0.0.1]) by localhost (mx1.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2TlJR6UyHjGn; Mon, 11 May 2026 12:02:05 +0200 (CEST) Received: from EXCH-01.secunet.de (rl1.secunet.de [10.32.0.231]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.secunet.com (Postfix) with ESMTPS id 8646B201AA; Mon, 11 May 2026 12:02:05 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.secunet.com 8646B201AA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secunet.com; s=202301; t=1778493725; bh=lKGB39JXJTxL8tUDgD/z4BYCZRQYs8mxvCJtK0ZDbPk=; h=Date:From:To:CC:Subject:References:In-Reply-To:From; b=zlbMpr/MurgPXcba0qUfGV83F7lDrPMJX7ZArIdlixNjf6s2AT1ncQG1s7IHLWFaA Yy943tHLHBmXWdmeLsuPXS8WMQQ+O+YXNh6B7lquOWBYmQI2odH8nPf2DSvQ77eilx geIEcDbHtSkR5V4v7IWMjF+8PiISgNaMrZ4UtNP/kA7W7iLG1bfvwDVeC6i07zuGY4 cuMKxJbvCji93xa+bsJK0KMjdTQGCw/fVdEMeqkNQpx+q+iugzCYm2l8IY6WHEdMRv xT6JmzexXCMK9cRViTTwbPWp4DKoI+52oGMJiGtJ8blubuog6UKq0FWnp08VROyZKD GLhBc/DeovvBw== Received: from secunet.com (10.182.7.193) by EXCH-01.secunet.de (10.32.0.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 11 May 2026 12:02:04 +0200 Received: (nullmailer pid 411050 invoked by uid 1000); Mon, 11 May 2026 10:02:03 -0000 Date: Mon, 11 May 2026 12:02:03 +0200 From: Steffen Klassert To: Herbert Xu CC: Orion Zhu , , , , , , , , , , , , Subject: Re: [v3 PATCH] xfrm: ipcomp: Free destination pages on acomp errors Message-ID: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: EXCH-04.secunet.de (10.32.0.184) To EXCH-01.secunet.de (10.32.0.171) On Wed, May 06, 2026 at 09:23:28PM +0800, Herbert Xu wrote: > Orion Zhu wrote: > > > > Thanks, but I think moving the label is not safe for all paths reaching > > ipcomp_post_acomp(). > > Thanks for checking! > > We could fix this by checking whether req is NULL and whether > sg_page(dsg) is NULL. > > ---8<--- > Move the out_free_req label up by a couple of lines so that the > allocated dst SG list gets freed on error as well as success. > > Fixes: eb2953d26971 ("xfrm: ipcomp: Use crypto_acomp interface") > Cc: stable@kernel.org > Reported-by: Yuan Tan > Reported-by: Yifan Wu > Reported-by: Juefei Pu > Reported-by: Xin Liu > Signed-off-by: Herbert Xu Applied, thanks a lot everyone!