From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51E6640628A for ; Mon, 11 May 2026 15:41:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778514096; cv=none; b=KCDd7qdc21gNB4N3yPxTqRywIsi4x3mHNXM0QNbFEY5hzOuR7QgEWbrwepg3aWisXbMpfGJrMfCD75itheI1EM3ly4ZLvlqEhB7hdCdaEdVdKfu5O1OROrXwr5tVvdQ7EOgQZeF2uNcE5tffsaNwYSos9f5tP5Xb9cjDmgGQyuw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778514096; c=relaxed/simple; bh=QYUz8b5kzsmvQFipBJ/YClQFCzx8AI1CLI1nrVUTxv0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bzQbQlm7EbNNIXj4ujRYcTg1QD9ErR9XLJRNdo9qiZkHcOguN+lYQ8mUPtxlAibXsUY33stk70Jgv0nUAh/nFHsV9OQW4wOfOYm+lOGOIZAxgDO930FLhWI4Q6EOAEfxhIQTI2hwYnYCpBm/D2ZHCOgZXmaWNYx5HGHYkv6JrYU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=Heko3cGu; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="Heko3cGu" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-48984d29fe3so48042295e9.0 for ; Mon, 11 May 2026 08:41:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1778514093; x=1779118893; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QYUz8b5kzsmvQFipBJ/YClQFCzx8AI1CLI1nrVUTxv0=; b=Heko3cGu0Pyebt5bmYaWD5pTPrs+ZlplJer06F5Q3e9Ipc3Hi+pgI51EIhUU1T0ncf c4gO5Em2u4wlHWzDpeHA3DKtgyvG/TC2z3IoMk96Ekl6HoiCL7TdKph+bb5n4SXJ6g0P /opjNxoxU4YepoTNEddD9i5yfspCTDqhwkCPHZpy6MP6pQHszoGnw+I0gAqxHglOk1td UX/nAq9/M1jppHUduHWyQFPlGUWPQZt2oBTccyRjSok+olkdvR+SLawsm+GtGJ7SjoMO 4yUg9H0xC3yWKaHycUvgIdVK4SRQpAQg89Z1D43EhU1IglbucyJojJXkmJkcQcz9YkR4 gd1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778514093; x=1779118893; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QYUz8b5kzsmvQFipBJ/YClQFCzx8AI1CLI1nrVUTxv0=; b=OvEgofbOTmNeEa/7dpZp1ZX1JfS0KRvxWj9oSIfI26dnuZlSx5pDH3go8ApiW/DJ/J JST5TiE19ndsysyvrJwiA3uiIPVxclKyJTppYGO2kL3BKNJ8uNcpmV1OUbfANU/uD7H5 koYAePBjHQDiplTi3bJxVUqH91YYdyhAlzL9SOGXXnDYPBmdheq70EPaweyeLWw6ecpM 3oJXxagLcBupCYOZ6YlPH2otAHfZcUrq67O/mtVibH+mh28KUNyHwyKQ+cWoMIpUe+S7 lHhWptg2CztbUgeI29zFoi4n4H3H7eXxvDE92ajC4cyOTeCVMUoQwvsRYNZ95EcGEl7s boXw== X-Forwarded-Encrypted: i=1; AFNElJ8o+6nSQMOWjxYll8zgQ7yxoPOonPtR44m75a3R3HN23rr4nmvFK+YW4QIkDuPsGuZMWFOx9b0=@vger.kernel.org X-Gm-Message-State: AOJu0YxRtOPLNV46NG5mRjADs90sVhomlsjFRwad4F6wKLBkGpb7Xi6A TbBYtPffxmY9xTe3n8S9XDnfizNPZ6wA5I9rrVUps/Lv/lYII3CyVEpd8PLVQGNnUCU= X-Gm-Gg: Acq92OExJQC+YTBaMatJ0DnztKnc0jdkKff7oa9Hb5yprqtk/i0JV7/Oz8CTFhzGQrN nvOnHCf1bxMq9wSPyWgi8GqPRFZmkp2i1Kl4IJAJytqszy379SWjZWxdlPmIufNtRN3ucNV/JXq HlpRzCqmIcDt68ejerJs/oFd9smyvrWhokb79SZEuPxwlhF+ANkQIL3uwagGS2+9AFerzVkbMEr hOf5jNE5YwSSh5djyjYsxk3xFOrwKvwBwmhw9eOVltBSIgcZz7gzV812/FE4cRYhU50w4dT6Yz0 MvC0Vnsx60xuIqsbfuDQ1pZjG9H6RntUrbrUvqvoU/cxB/Ia5A+yuuAKsnWBI9dmd/tWcogdnC+ neK5wJFO2qVTv5aNkGsUdN3skUj/8j5Uf5AjyfBpt94lnLMrxq8o7X2fK1cF7oFDEGKs+MCs6R3 sNgpcERujfkTBb642oBOIfNnq3QpRwM1tq4+Zkd7JRaWOVA2DIbOVYAB1GtJtO8gTPwY5qfzZS3 9AFcVj46niW6FXqyAS8EEIfeqwt/QYRjNs802nkDq6KQlxamnRq30XFp+lsLaFKKqsFvqQFIDH+ EUoJlgdH X-Received: by 2002:a05:600c:1f89:b0:48e:8741:fd42 with SMTP id 5b1f17b1804b1-48e8741ff8cmr37216095e9.12.1778514092586; Mon, 11 May 2026 08:41:32 -0700 (PDT) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e6d8e3247sm64622295e9.8.2026.05.11.08.41.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 08:41:31 -0700 (PDT) Date: Mon, 11 May 2026 16:41:28 +0100 From: Daniel Thompson To: Xilin Wu Cc: Alex Elder , andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, maxime.chevallier@bootlin.com, rmk+kernel@armlinux.org.uk, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linusw@kernel.org, brgl@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, mohd.anwar@oss.qualcomm.com, a0987203069@gmail.com, alexandre.torgue@foss.st.com, ast@kernel.org, boon.khai.ng@altera.com, chenchuangyu@xiaomi.com, chenhuacai@kernel.org, daniel@iogearbox.net, hawk@kernel.org, hkallweit1@gmail.com, inochiama@gmail.com, john.fastabend@gmail.com, julianbraha@gmail.com, livelycarpet87@gmail.com, matthew.gerlach@altera.com, mcoquelin.stm32@gmail.com, me@ziyao.cc, prabhakar.mahadev-lad.rj@bp.renesas.com, richardcochran@gmail.com, rohan.g.thomas@altera.com, sdf@fomichev.me, siyanteng@cqsoftware.com.cn, weishangjuan@eswincomputing.com, wens@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 10/12] net: stmmac: tc956x: add TC956x/QPS615 support Message-ID: References: <20260501155421.3329862-1-elder@riscstar.com> <20260501155421.3329862-11-elder@riscstar.com> <7f3a0f16-5159-4bbc-8b15-9b5841603bf6@riscstar.com> <3A5C0389E7C0D241+21a4f16b-1af8-46ac-8831-0c1b49694df0@radxa.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3A5C0389E7C0D241+21a4f16b-1af8-46ac-8831-0c1b49694df0@radxa.com> Hi Xilin On Thu, May 07, 2026 at 09:57:26PM +0800, Xilin Wu wrote: > Do you think if a shutdown callback like this is required? It looks like the > driver sometimes does a MDIO MMIO read when the PCIe link is down, causing > the board to reset due to SoC side PCIe NoC timeout. > > After this change, the board can always shutdown gracefully. I've preferred controlled reboots to power cycles throughout development and I hadn't spotted any major problems with graceful shutdown (which isn't to say there have never crashes but generally I expect `reboot` to provoke a reboot successfully). Just to be sure configured my board with irq=POLL (to match your setup) and still can't reproduce. We mostly run Debian/systemd so there might be something happening in userspace to sequence things nicely. However I have ruled out NetworkManager.service and networking.service (stopped this services does *not* tear down the network link). Can you share a bit more about how to reproduce the problem (including reliability of reproduction)? Daniel.