From: Paul Fertser <fercerpav@gmail.com>
To: Michael Bommarito <michael.bommarito@gmail.com>
Cc: Samuel Mendoza-Jonas <sam@mendozajonas.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 0/6] net/ncsi: harden packet parsing against malformed BMC replies
Date: Tue, 12 May 2026 15:30:20 +0300 [thread overview]
Message-ID: <agMdXKQgo3jEWtXN@home.paul.comp> (raw)
In-Reply-To: <CAJJ9bXyoAND+CzLqY=jGWdtaY33jeLWf0sBbj-6OXHyXudqjUQ@mail.gmail.com>
Hello Michael,
On Wed, Apr 22, 2026 at 01:06:56PM -0400, Michael Bommarito wrote:
> On Wed, Apr 22, 2026 at 12:44 PM Paul Fertser <fercerpav@gmail.com> wrote:
> > The code your patches modify always runs only on the BMC itself, the
> > packets parsed are generated by a NIC directly.
...
> Should I submit a v2 with the corrected notes or wait for any other
> feedback / review on patch substance (assuming you think it's actually
> worth merging)?
So I see you got some interesting AI-generated review from the net
maintainer Jakub on 23rd Apr. That raises many important points so
please take time to go through them manually and respond. Once some
sort of consensus is reached feel free to send a v2.
Thank you for working on improving this dark corner of the Linux
networking, I hope server manufacturers will appreciate.
prev parent reply other threads:[~2026-05-12 12:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 16:03 [PATCH net 0/6] net/ncsi: harden packet parsing against malformed BMC replies Michael Bommarito
2026-04-22 16:03 ` [PATCH net 1/6] net/ncsi: validate response packet lengths against the skb Michael Bommarito
2026-04-23 19:12 ` Jakub Kicinski
2026-04-22 16:03 ` [PATCH net 2/6] net/ncsi: bound filter table state to software limits Michael Bommarito
2026-04-23 19:12 ` Jakub Kicinski
2026-04-22 16:03 ` [PATCH net 3/6] net/ncsi: validate GMCMA address counts against the payload Michael Bommarito
2026-04-23 19:12 ` Jakub Kicinski
2026-04-22 16:03 ` [PATCH net 4/6] net/ncsi: validate OEM response payloads before parsing Michael Bommarito
2026-04-22 16:03 ` [PATCH net 5/6] net/ncsi: validate AEN packet lengths against the skb Michael Bommarito
2026-04-22 16:03 ` [PATCH net 6/6] net/ncsi: validate GP payload lengths before parsing Michael Bommarito
2026-04-23 19:12 ` Jakub Kicinski
2026-04-22 16:44 ` [PATCH net 0/6] net/ncsi: harden packet parsing against malformed BMC replies Paul Fertser
2026-04-22 17:06 ` Michael Bommarito
2026-05-12 12:30 ` Paul Fertser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agMdXKQgo3jEWtXN@home.paul.comp \
--to=fercerpav@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.bommarito@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sam@mendozajonas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox