From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from abb.hmeau.com (abb.hmeau.com [180.181.231.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A33D3B7B98 for ; Thu, 14 May 2026 04:53:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=180.181.231.80 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778734410; cv=none; b=TLF51uhncEUTH0C3MrHju2R9qfpysy1Sunkv/JGNqo87tQ90mETb/Fie4N36XWlj/+WrENo8IH5fC7aNvUzJcoq17qCOpoaI9WA+pyOhWOCjRbFqiU9zxMHG2IxxUmN1AQAS+bqz1kDDOh8KLrrtwHKWGcJdAsaH/yM12wQvjM0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778734410; c=relaxed/simple; bh=TBasVBtl4YDvRvrYf10bEMt5/K81Tc3CArZvvHAPV8M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TGgZeQ4lKjaX+QGNoSedSXynoMjS2QcUNSnyHoExjf3K4tOoEKy5GmNTN4txNKOl6EJzQaez9nIUwoiklyr2xAttG3Jt1l1bSeDDwHYmm9FHyFYBnflMJ5hjEK++t0vtG6jHfpOmiCjKkIo+vFi+8epac3MKR8yPfqBtCdAOZGw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gondor.apana.org.au; spf=pass smtp.mailfrom=gondor.apana.org.au; dkim=pass (2048-bit key) header.d=gondor.apana.org.au header.i=@gondor.apana.org.au header.b=BKwOS3+C; arc=none smtp.client-ip=180.181.231.80 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gondor.apana.org.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gondor.apana.org.au Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gondor.apana.org.au header.i=@gondor.apana.org.au header.b="BKwOS3+C" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gondor.apana.org.au; s=h01; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:cc:to:subject:message-id:date: from:content-type:reply-to; bh=7N8YT99TfR/1x81R/DSiDayVSyQH3Rhupn6pkMHesq4=; b=BKwOS3+CfvEBOhhBbLccGqe+NaICLCrNBzmWa4Jt6MMZVivnNFq46pZHwJQhkKiiDwSl1LOS2Uo uxD1ejudoKHSQgS9V3+ROI7bnScPcCuoxSPIPoXhzI/Ip08qmcVFJni5bTSb++k3uWLXNagIaIL9T Fkx3Yfb5bkW6E45g4ARu8imzFSGNNcm2Z5hdq+zlVJ7vly/l2463f0g+q629VctAgA3veEQlubG+0 Jz2RH0NWBmXHS6/ut7kF/OmQP0yXj8LNpgohri5hMsK6swhkiu37bHH1u5QvBGOfKI4BrNFMTW7J2 f6DWOO47cyzEbdARcw194VtTpPmmUd+UkxzA==; Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.96 #2 (Debian)) id 1wNO4J-00E1ck-0V; Thu, 14 May 2026 12:53:08 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Thu, 14 May 2026 12:53:07 +0800 Date: Thu, 14 May 2026 12:53:07 +0800 From: Herbert Xu To: Dong Chenchen Cc: steffen.klassert@secunet.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, tpluszz77@gmail.com, netdev@vger.kernel.org, zhangchangzhong@huawei.com Subject: Re: [PATCH net] net: xfrm: Fix dev refcnt leak in async resumption Message-ID: References: <20260509074443.104163-1-dongchenchen2@huawei.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260509074443.104163-1-dongchenchen2@huawei.com> On Sat, May 09, 2026 at 03:44:43PM +0800, Dong Chenchen wrote: > xfrm async resumption hold dev ref until after transport_finish. > When afinfo is NULL (e.g. x->props.family is invalid) and xfrm_gro > is not set, dev_put in transport_finish() and xfrm_gro path is skipped. > This will trigger refcnt leak. There should never be a an xfrm_state with a NULL afinfo. That would be a serious bug. How did you trigger this? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt