From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-a8-smtp.messagingengine.com (fhigh-a8-smtp.messagingengine.com [103.168.172.159]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6539175A6D; Thu, 14 May 2026 15:45:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.159 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778773552; cv=none; b=p9aXCXXyZ5aX1ZU4rm0OzGwi7dwoToiRGqIbaC838pS7+gLN+tRdcQuQvpftXwgG0/FJIrYX2HuiuJ7FvweP7dsgAWEfzRwSXokYsyFPcUdEx5ALbdbXvrzqf0RWYm045IsdHcOgjdE/kQ7ORTArBS2U98iab+8JkxlolrZSOEM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778773552; c=relaxed/simple; bh=2eZQ28o2aeUb29+g7yRCupFzyRVNMQupfH8jXxpZaOY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gKGsBmANOWLh4YNRfccH+dJ/nnYEiY5uYromck4rRP4DOd7PchgyqIgpFsfOUc7nWfSDgDItFwiNEIFUtL41DjPMh3HN/cMJRG52vTLnJ9qJO02mSPXKOQPLNqAaXognGx1mH3LX8IYGtMEaLZRUYsQL/81bJHr0fkLHpX41F6A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net; spf=pass smtp.mailfrom=queasysnail.net; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b=D1BVIKXX; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=RJdzz2/T; arc=none smtp.client-ip=103.168.172.159 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=queasysnail.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=queasysnail.net header.i=@queasysnail.net header.b="D1BVIKXX"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="RJdzz2/T" Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailfhigh.phl.internal (Postfix) with ESMTP id CC65B14001D8; Thu, 14 May 2026 11:45:48 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Thu, 14 May 2026 11:45:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=queasysnail.net; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1778773548; x= 1778859948; bh=UsgCLgF9UwbEiwmeUtgZkK88jnAqNvlDzxdt4itg7V4=; b=D 1BVIKXX3t118XISFBRL8rWMzGtSS2KpxPIqjLYqAT4Yd0mVS0cpvJDR5lF1KiNBy PFmBa0HSNn1SQ3MnyY/Li03JHCjN3OPUyjfneHnhzqHNIfWp+eTr+EuK/2Oel7MB DVTiu6DLPxDjDVNb2edWFSe8Oy/7cHD6xk9j1xfLSudbDDhIIUq+a4MBV+XvFbbt 62nhUNzQpllx+Q/jMiqp0EuQNwOas3fJSFueI6x1vVaDiBKRgOR/F5gDLcow1h7o zmfwSsRzodSRVaozpa4uMOpHmOkScp7ffg69m+289trqw+A4GwKNus74vB7TF+mt klcB0NvzEJczYRmboO6ig== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1778773548; x=1778859948; bh=UsgCLgF9UwbEiwmeUtgZkK88jnAqNvlDzxd t4itg7V4=; b=RJdzz2/TR+QVl1zoMiTFWHiec21D4kFmQ0x7ovD42KVNs8FxzqF mqWSTpMJUW8Q9x+22W9YtenEnspnIXFOplhYWe4MnCMHY37hyqPBMjlC5C13IEHE eyo4XwsJlk+YDD+hrTpWvlyDFYgX0laTU5jNSUZabl2BmMnU7fCYsAlfkI5s3VSJ 73omUKCt50huhoXdTqJWijgzWTRuvSWBYjucrIOgnwjKfNCN4FT5vMz6fhY9Bnvo 7D1iI5w7SXJMlTuo7aUwiKs9wsogMsdYU7lSnxJ1Qmv2XMGXzM+evV/wMuEbx1Vv gXH5LCTw5kkE+6Cy9PcTjJZfSTjFHsbHI0g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdduvdejleduucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujgesthdtredttddtjeenucfhrhhomhepufgrsghrihhn rgcuffhusghrohgtrgcuoehsugesqhhuvggrshihshhnrghilhdrnhgvtheqnecuggftrf grthhtvghrnhepuefhhfffgfffhfefueeiudegtdefhfekgeetheegheeifffguedvueff fefgudffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epshgusehquhgvrghshihsnhgrihhlrdhnvghtpdhnsggprhgtphhtthhopedujedpmhho uggvpehsmhhtphhouhhtpdhrtghpthhtohepughsrghhvghrnheskhgvrhhnvghlrdhorh hgpdhrtghpthhtohepihhmvhegsggvlhesghhmrghilhdrtghomhdprhgtphhtthhopehp rggsvghnihesrhgvughhrghtrdgtohhmpdhrtghpthhtohepkhhusggrsehkvghrnhgvlh drohhrghdprhgtphhtthhopehsthgvfhhfvghnrdhklhgrshhsvghrthesshgvtghunhgv thdrtghomhdprhgtphhtthhopehnvghtuggvvhesvhhgvghrrdhkvghrnhgvlhdrohhrgh dprhgtphhtthhopehsthgrsghlvgesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphht thhopehmhhgrlhesrhgsohigrdgtohdprhgtphhtthhopegurghvvghmsegurghvvghmlh hofhhtrdhnvght X-ME-Proxy: Feedback-ID: i934648bf:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 14 May 2026 11:45:46 -0400 (EDT) Date: Thu, 14 May 2026 17:45:45 +0200 From: Sabrina Dubroca To: David Ahern Cc: Hyunwoo Kim , Paolo Abeni , kuba@kernel.org, steffen.klassert@secunet.com, netdev@vger.kernel.org, stable@vger.kernel.org, mhal@rbox.co, davem@davemloft.net, horms@kernel.org, edumazet@google.com, kerneljasonxing@gmail.com, herbert@gondor.apana.org.au, vakzz@zellic.io, kuniyu@google.com, jiayuan.chen@linux.dev, ben@decadent.org.uk Subject: Re: [PATCH net v2] net: skbuff: propagate shared-frag marker through frag-transfer helpers Message-ID: References: <92ec6190-0255-4b7c-9524-254cb37476ab@redhat.com> <69f72d09-8054-4d26-b277-9e9b7a8854c1@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <69f72d09-8054-4d26-b277-9e9b7a8854c1@kernel.org> 2026-05-14, 08:37:19 -0600, David Ahern wrote: > On 5/14/26 4:21 AM, Sabrina Dubroca wrote: > > 2026-05-14, 18:38:34 +0900, Hyunwoo Kim wrote: > >> On Thu, May 14, 2026 at 10:04:29AM +0200, Paolo Abeni wrote: > >>> On 5/13/26 11:07 PM, Hyunwoo Kim wrote: > > >> Agreed. tracing SKBFL_SHARED_FRAG propagation paths one by one is > >> not a robust direction for the fix. Even minor logic changes elsewhere > >> could cause the issue to resurface. > >> > >> As a follow-up, eliminating the in-place handling in esp_input -- accepting > > > > It would close this group of vulnerabilities, but there are other > > parts of the networking stack that consume this flag. For those, > > chasing missing flag propagation is still a useful task. > > > > Seems like this should be an skb helper to manage the flag with really > good documentation on when it needs to be set, reset and propagated. > > I walked skbuff.c yesterday as well, and there are several places where > it is not clear if the flag needs to be propagated or not. Or maybe even something like a skb_transfer_frag that handles updating the frags array and copying the flag. Then we wouldn't have to chase functions that mess with frags[] directly and forget to also adjust flags. -- Sabrina