Re: [PATCH net-next 2/2] net/mlx5: implement max_sfs parameter

[Nikolay Aleksandrov <nikolay@nvidia.com>]

On Mon, May 18, 2026 at 09:05:52AM +0000, Loktionov, Aleksandr wrote:
> 
> 
> > -----Original Message-----
> > From: Tariq Toukan <tariqt@nvidia.com>
> > Sent: Sunday, May 17, 2026 1:27 PM
> > To: Eric Dumazet <edumazet@google.com>; Jakub Kicinski
> > <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Andrew Lunn
> > <andrew+netdev@lunn.ch>; David S. Miller <davem@davemloft.net>
> > Cc: Jiri Pirko <jiri@resnulli.us>; Simon Horman <horms@kernel.org>;
> > Jonathan Corbet <corbet@lwn.net>; Shuah Khan
> > <skhan@linuxfoundation.org>; Saeed Mahameed <saeedm@nvidia.com>; Leon
> > Romanovsky <leon@kernel.org>; Tariq Toukan <tariqt@nvidia.com>; Mark
> > Bloch <mbloch@nvidia.com>; Vlad Dumitrescu <vdumitrescu@nvidia.com>;
> > Loktionov, Aleksandr <aleksandr.loktionov@intel.com>; Daniel Zahka
> > <daniel.zahka@gmail.com>; David Ahern <dsahern@kernel.org>; Nikolay
> > Aleksandrov <razor@blackwall.org>; netdev@vger.kernel.org; linux-
> > doc@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> > rdma@vger.kernel.org; Gal Pressman <gal@nvidia.com>; Dragos Tatulea
> > <dtatulea@nvidia.com>; Jiri Pirko <jiri@nvidia.com>; Nikolay
> > Aleksandrov <nikolay@nvidia.com>
> > Subject: [PATCH net-next 2/2] net/mlx5: implement max_sfs parameter
> > 
> > From: Nikolay Aleksandrov <nikolay@nvidia.com>
> > 
> > Implement max_sfs generic parameter to allow users to control the
> > total light-weight NIC subfunctions that can be created using devlink
> > instead of external vendor tools. A value of 0 will effectively
> > disable creation of new subfunction devices. A warning is sent to
> > user-space via extack (returning extack without error code is
> > interpreted as a warning by user-space tools).
> > 
> > Signed-off-by: Nikolay Aleksandrov <nikolay@nvidia.com>
> > Reviewed-by: David Ahern <dsahern@kernel.org>
> > Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
> > ---
> >  Documentation/networking/devlink/mlx5.rst     |  7 +-
> >  .../mellanox/mlx5/core/lib/nv_param.c         | 83
> > ++++++++++++++++++-
> >  2 files changed, 86 insertions(+), 4 deletions(-)
> > 
> > diff --git a/Documentation/networking/devlink/mlx5.rst
> > b/Documentation/networking/devlink/mlx5.rst
> > index 4bba4d780a4a..283b93d16861 100644
> > --- a/Documentation/networking/devlink/mlx5.rst
> > +++ b/Documentation/networking/devlink/mlx5.rst
> > @@ -45,8 +45,13 @@ Parameters
> >       - The range is between 1 and a device-specific max.
> >       - Applies to each physical function (PF) independently, if the
> > device
> >         supports it. Otherwise, it applies symmetrically to all PFs.
> > +   * - ``max_sfs``
> > +     - permanent
> > +     - The range is between 0 and a device-specific max.
> > +     - Applies to each physical function (PF) independently.
> > 
> > -Note: permanent parameters such as ``enable_sriov`` and ``total_vfs``
> > require FW reset to take effect
> > +Note: permanent parameters such as ``enable_sriov``, ``total_vfs` and
> > ``max_sfs``
> I think one ` is missed after the ``total_vfs` ?
> 
> 
> ...
> 

ha, good catch! there's a missing ` indeed :)

> > 
> > 	DEVLINK_PARAM_DRIVER(MLX5_DEVLINK_PARAM_ID_CQE_COMPRESSION_TYPE
> > ,
> >  			     "cqe_compress_type",
> > DEVLINK_PARAM_TYPE_STRING,
> >  			     BIT(DEVLINK_PARAM_CMODE_PERMANENT),
> > --
> > 2.44.0
>