From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 152ED372066 for ; Tue, 19 May 2026 23:33:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779233637; cv=none; b=GWGd3WwgtKNUCvRIMoAbn2mm4+RTT22fnZ0qGSuWUfPd5Xxj/hTUzfnlNpa7HqrhOXPO0IlUgoa258Zk3DoK51LUL1O3t/+FWiAN88zetdA+5ffspqmX1fAS/GWgrK9SMenjGpatTwUECXQtheRNXHiQ9yKsPTWUlg6jD9ehvuU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779233637; c=relaxed/simple; bh=vWp1K7SkFtPXP8NpxuPbKqX8DiXUPCucssT7uxnbYHQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qYMwAILFZoiQooX2bn/1W2nWuUIVbDGYVLSFa4x6h+EdbHmAkoT+z9vv1/FXON2mdgYd50OCX2hlzIfHBJreNaZQ5fD4yhxFgck9XXUdwkB8ZDx8vuSHV1gXSxiYKvT0NxoOfnvDbHhpR4eDkR7R3P4rN32zrdPpm3EK3Ggykq8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Wwx4K0Lt; arc=none smtp.client-ip=209.85.214.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wwx4K0Lt" Received: by mail-pl1-f195.google.com with SMTP id d9443c01a7336-2b4583f0a1aso26822255ad.3 for ; Tue, 19 May 2026 16:33:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779233635; x=1779838435; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GhZ8XqsRht1If9UNrz6T/KJzsMWi9OQBMKb8F+sw0Zk=; b=Wwx4K0LtyCyr/gYTf6l0rfMzYzM6afgNClodmb/UwMaTZX9p/NsFyCwOAsa9kZxNgk eqRlaVYP5i1Wkc7u5BmnomkGWTbXWLqz4cXnuUCjafqMD8rrTXYHWxuMF+dWEyReJz9X ELiMPqygE3RstQHDXDWJokXQ4CugNve7UlUk54IOoE1Ba8F6hM/MLJoj2Q5vf8UpY8rz e0g3W8iQtAtPCG6Zt/Eol3FwiKleVT05n9bkqbiZCX19SmOZan6R5XlynJedxXJ06cpG 50rDSL+B3EOPNZF3C2CKbf4DyVzfBpK2mJf6Z+7cFThw0nm3VKmwgyUcj34i7QHhrOdl 8KRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779233635; x=1779838435; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GhZ8XqsRht1If9UNrz6T/KJzsMWi9OQBMKb8F+sw0Zk=; b=a7vYGEKQPue+c/q5jeukp7vbIl7wve4dqNirmlIYRUIKdcf8gwwNlPjABLy0h5S83n 5s8erXV8QgoMBG/3VHg3tfo7fazqxRROlBDyP2mPi207Ezwt2BaBnheYpcwkUK8ouqbd fGlvWv+ClJmKVFOLk09F6h1XUHdD4bgd6P9Di15KsWQ4YmYVAiRykDqf26V5lr4AcUQR 9xirD0BTF/OfCQJagw5+kHQg4UO+MiZrsZMOeRyAJADP3EOq6vCuQsr1nxJvUmxL4daO GXeTHD032Z3D9X8VAUDvYS+4VrOZXCbXw1KN6LruZUgtdqTArtCTb7+lTkCJDXj8QaPE c6PQ== X-Gm-Message-State: AOJu0YxG7yxID+pfdIfAggQ8/Zaqb7LU2vBtOCFvg/8UqM7ZwWnzqRKo ydIiWgjBt1W7H2CilpFewlOvlzEu/Rg2K02rtBMtfuQaCN6+zUoCkVQ9 X-Gm-Gg: Acq92OHkSRechUv40+prP7pxedkbqFWOie3xcHa9enkO/E3AdAP0x9DWmCzrwmK0piE PI/fxpR+Q/Jk1xJvXh1U4dWC+qgXY13/K1ISp6sJTLi3zKoM23MWcC5emF/M+l83uiFcgt7dhy+ iqoJvWuvdIpgb5llolZvSm/ujBfIsErp/fYVqR006+4iSJiZofUUDZKpudZ0TlCjzH6thbCCynf lg/XD0BJGCJJcoCCAw/A1J6bespsA/YjUXaKmZxXu/uSd0vSFev7R6Og2ZBQipFFeaTg8gNcqcl QCCn/pYYSdoFlhGi4YIg7TmYstzfnlCfQdL5tAsJIWpqfKoT/wbqOjr61p6EDOQTwZNqguMy0h+ xuw2nAOtOREQseWhYGv7iChuyRseMCmJIpDS1vf4XSb0bvHzTG0+LptlaEZgHvBkFYpWJ+rPZNm NK1EtFMKemnEu4+xoW9nCHnNRTYw== X-Received: by 2002:a17:903:3c6b:b0:2b9:fb9a:1103 with SMTP id d9443c01a7336-2bd7e90ebafmr222425135ad.38.1779233635347; Tue, 19 May 2026 16:33:55 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:2::]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5cfe8698sm189776065ad.40.2026.05.19.16.33.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 16:33:54 -0700 (PDT) Date: Tue, 19 May 2026 16:33:54 -0700 From: Stanislav Fomichev To: David Carlier Cc: netdev@vger.kernel.org, stable@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, sdf@fomichev.me, kaiyuanz@google.com, almasrymina@google.com, bobbyeshleman@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2] net: devmem: reject dma-buf bind with non-page-aligned size or SG length Message-ID: References: <20260519203530.66310-1-devnexen@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260519203530.66310-1-devnexen@gmail.com> On 05/19, David Carlier wrote: > net_devmem_bind_dmabuf() trusts dmabuf->size and sg_dma_len() to be > PAGE_SIZE multiples without checking: > > - tx_vec is sized dmabuf->size / PAGE_SIZE, and > net_devmem_get_niov_at() only bounds-checks virt_addr < dmabuf->size > before indexing tx_vec[virt_addr / PAGE_SIZE]. With size = > N*PAGE_SIZE + r (1 <= r < PAGE_SIZE), sendmsg() at iov_base = > N*PAGE_SIZE passes the bound check and reads tx_vec[N] -- one past. > > - owner->area.num_niovs = len / PAGE_SIZE while gen_pool_add_owner() > covers the full byte len, so a non-page-multiple non-final sg > desyncs num_niovs from the gen_pool region for every later sg, on > both RX and TX. > > dma-buf does not require page-aligned sizes, so the bind path has to > enforce what its own indexing assumes. Reject both with -EINVAL. > > The size check is TX-only (only tx_vec is sized off dmabuf->size); the > SG-length check covers both directions. > > Fixes: bd61848900bf ("net: devmem: Implement TX path") > Cc: stable@vger.kernel.org > Signed-off-by: David Carlier > --- > Changes in v2: > - Reframe commit message around the kernel-side OOB instead of > "real exporters already page-align", which read as the OOB being > unreachable and undercut Cc: stable (Stanislav Fomichev). > - Hoist the SG-length check out of the if (TX) branch so it covers > RX too; RX has the same num_niovs / gen_pool desync on a > contract-violating exporter, just without an OOB. Keep the > size-multiple check TX-only (Stanislav Fomichev). > - Drop bool todevice; compare direction == DMA_TO_DEVICE inline to > match the existing call site at the tx_vec[] assignment > (Bobby Eshleman). Acked-by: Stanislav Fomichev Thanks!