From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A19438F240 for ; Mon, 1 Jun 2026 09:16:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780305398; cv=none; b=shwOnt7Wkx0j3tDbLYRAO36RhtmVjbXLK/7tZfc74OI8hiGw/uKMsWpnTr0LbEsWuX6NTP2f33+7zVm3Lum9lAMNBp1pFFZ0lNCTgApEJutLzzYJdqMr/iBOkIe9SZz0jSFN33YvVmePyFo62Q37Bz3diIYjtJNvZt3egg+vkiI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780305398; c=relaxed/simple; bh=MAv2G3iNIINHmtBP17XT2WWmP/ezoDjjO/TPWJIsdX8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VyHVrijTmnByFPkCONzyPdRZaK0mWM3QRBPW66R11qpI0UIJZpft9+TYODh+67L/PAumIU7ecnDkZtTp7YPB0aloGb22iSZujc/mUqO7OXIac14f/7DgEq/88vYw0HrOT1xHvAvJXaVHdHxEkZMwt54oMbUo+2RIQc/wF56qNqM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TtgKpihU; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TtgKpihU" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-490af320e2aso575825e9.2 for ; Mon, 01 Jun 2026 02:16:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780305396; x=1780910196; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=yVfLkZhdjxtyOU1OcAKjYEFf7E85v5J9aWNUt/TDql4=; b=TtgKpihU+YKQ5DRtFlrIH9TP8b8ZFcqj0pYrTLdN8BXmdSGl9WEguhxSog3fjMky8b NJcMIUfUJKjOu0k9OO6cDiLyIzB1XLLaeS8J9RWnnzOECNDHyhFdJRhYIhuak7dekJrq +Ot5+vmjWgVqG/OpCupUnw7trEj+OmZgYGE7UTk6th9Dyg/Dy9YmCSZ61E6I9R/p0GLK U+Skcy5DWpDEAfZYwvmSftdjFNMB7ZOEKwwtO9uyaUGQ5hu9AkACRJ1QmpRpX8EIlvZD aJMRw1V0HCF4Cgx6LKj9NDdTdjSEvYcrrJu8+FzIwQTzvzLagS06LIi2Pe2BE0E4+h20 v4cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780305396; x=1780910196; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yVfLkZhdjxtyOU1OcAKjYEFf7E85v5J9aWNUt/TDql4=; b=Bx4nJA6qm82zyw7jIIri757MRX1gvDD9ly+j/BaVAMrbWIadYDqaA6EsNaKTOMVnDW Qobf/e0C6ZQT/hWytXqzvs5nIHPRd9MBAKYJmgguQWX28igZOnT7BbVIx6N5ortquRn7 c8dN1v4Habm3S+8lhuf8u6M7NkzRhh32RcEPrQtwlqb4/JVYKZCxHDknll4FBt6iCnas 7fkPSpG07hcISYFxBivWzKXsr7rWDJVA5NsyncP+VN2WUEYDovWHl3uGs4CwomqR0g5Q LXrQD7KiPkEC3WNysOdsRR02fWsKRDEbdfIEkO2hPdWQ9ejb0J03Ob7B4N2Y8fBO64S+ iiRw== X-Forwarded-Encrypted: i=1; AFNElJ9PW0lOY5oxNjmrCLBos2M0nzHs+KvQwyuu8DlrEou5TFsdcl8aX2I8Fi2MBn9UlgW50M64B60=@vger.kernel.org X-Gm-Message-State: AOJu0YxmbnF1zJZlh1V5gkGV5lvM7WCTl0IOKLVEay1HZsLNlSVkexU2 KN9ORU1IXU7A1zqReku445bHmXXG1fj94W8b5tz69x1EeyFdpvVbEiIC X-Gm-Gg: Acq92OF8SW5rw9Yt4IITOg9txYz1BAAawYO4pIZfibzCGdi+4TcKLFgLnQmufgWDcmF JQnildchEDrqTy9bpC5J7w+B2hFDHGrhJQNxdeuq2ubaEpaxNCxozfRuWmzrzfl9TKJMBtKkRch xuWNMgwNiNypKqQYX5PBnIiX41kGeJ/9dBAI7HP0oSTlZLEuS7lbZ2r/FO5MWdvjh8CkE+KzCUq aQWlWKyJPPJwPFfVaOyATsrYhpvgOHKS51kLg0Re3CUW+FVLErZUi5PavR8VUyn2z7eXcW2y9HT UaQaT90Qi+q64TOhKtDh5zMPj2XkhIAFHxJQSvI9dVHGu+rDtU0HLi9jP8GppHucU7r+WD0I18p R2OaQpz+ELtfop5dBeZFWHqyoaSsS7uLadcQI/tTbHHUvutjHJMUL1OA2d+8TwCijnrdgtXgI6P IYy4BjyQ92FOVN2Gf3JODVyGa9RNfW20oPBXx1 X-Received: by 2002:a05:600c:190b:b0:48f:f64c:c2fe with SMTP id 5b1f17b1804b1-490a298f29amr176335025e9.22.1780305395689; Mon, 01 Jun 2026 02:16:35 -0700 (PDT) Received: from nsa ([148.63.225.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909d6eb4acsm231582545e9.9.2026.06.01.02.16.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 02:16:35 -0700 (PDT) Date: Mon, 1 Jun 2026 10:17:33 +0100 From: Nuno =?utf-8?B?U8Oh?= To: Andrew Lunn Cc: ciprian.regus@analog.com, Parthiban Veerasooran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Shuah Khan , Heiner Kallweit , Russell King , Rob Herring , Krzysztof Kozlowski , Conor Dooley , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH net-next v2 10/10] net: ethernet: adi: Add a driver for the ADIN1140 MACPHY Message-ID: References: <20260527-adin1140-driver-v2-0-37e5c8d4e0a0@analog.com> <20260527-adin1140-driver-v2-10-37e5c8d4e0a0@analog.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, May 29, 2026 at 03:03:58PM +0200, Andrew Lunn wrote: > Hi Nuno > > > > +static void adin1140_stats_work(struct work_struct *work) > > > +{ > > > + struct delayed_work *dwork = to_delayed_work(work); > > > + u64 stat_buff[ADIN1140_STATS_CNT] = {}; > > > + struct adin1140_priv *priv; > > > + u32 reg_val; > > > + int ret; > > > + u32 i; > > > + > > > + priv = container_of(dwork, struct adin1140_priv, stats_work); > > > + > > > + for (i = 0; i < ARRAY_SIZE(adin1140_stat_regs); i++) { > > > + ret = oa_tc6_read_register(priv->tc6, adin1140_stat_regs[i], > > > + ®_val); > > > + if (ret) > > > + break; > > > + > > > + stat_buff[i] = reg_val; > > > + } > > > + > > > + spin_lock(&priv->stat_lock); > > > > Maybe consider using scoped_guard() and similar for other places? > > Marginal win though so up to you. > > Please trim the text when replying so just the needed context is > provided. It is easy to miss comments when you need to repeatedly page > down, page down, page down to find something. > Sorry, I trimmed a bit but I guess not enough. > > > + ret = register_netdev(netdev); > > > + if (ret) { > > > + dev_err(&spi->dev, "Failed to register netdev (%d)", ret); > > > > If we go to devm, this could be return dev_err_probe(). > > dev_err_probe() is not really about devm, but handling EPROBE_DEFFER, > and not issues an error message when it is not wanted. I don't think I know. I mixed a bit. I related it to devm because then we don't need the error handling and then we can just do `return dev_err_probe()`. > register_netdev() can return EPROBE_DEFFER, so it probably does not > apply here. > And the above is a bit why I still like dev_err_probe() even if EPROBE_DEFFER is not to be handled. I like that we can just return rather than: dev_err() return ret; Also it unifies error logs with the same style (for printing error codes). - Nuno Sá > Andrew