From: Len Bao <len.bao@gmx.us>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: Len Bao <len.bao@gmx.us>, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] eth: dpaa2: constify dpaa2_ethtool_stats and dpaa2_ethtool_extras
Date: Sat, 30 May 2026 10:48:53 +0000 [thread overview]
Message-ID: <ahrAlZSp3QnLU636@ubuntu> (raw)
In-Reply-To: <ct5fwlsotsgvfjazc3vp4djj7hyi5ix7kreyqf4hohi5537plb@ehqkkzl22vcf>
Hi Ioana,
On Mon, May 25, 2026 at 05:40:46PM +0300, Ioana Ciornei wrote:
> On Sat, May 23, 2026 at 03:07:35PM +0000, Len Bao wrote:
> > The 'dpaa2_ethtool_stats' and 'dpaa2_ethtool_extras' structures are
> > initialized in their declarations and never changed. So, constify them
> > to reduce the attack surface.
> >
> > Before the patch (size dpaa2-ethtool.o):
> >
> > text data bss dec hex
> > 33433 5992 0 39425 9a01
> >
> > After the patch (size dpaa2-ethtool.o):
> >
> > text data bss dec hex
> > 34937 4488 0 39425 9a01
> >
> > Signed-off-by: Len Bao <len.bao@gmx.us>
>
> Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Thanks for the review.
> Next time, please mention the target tree name in the subject prefix. In
> this case, it would have been net-next.
Ok, next time I will do what you suggest. Thank you for the guidance.
Regards,
Len
next prev parent reply other threads:[~2026-05-30 10:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-23 15:07 [PATCH] eth: dpaa2: constify dpaa2_ethtool_stats and dpaa2_ethtool_extras Len Bao
2026-05-25 14:40 ` Ioana Ciornei
2026-05-30 10:48 ` Len Bao [this message]
2026-05-25 21:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahrAlZSp3QnLU636@ubuntu \
--to=len.bao@gmx.us \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox