Netdev List
 help / color / mirror / Atom feed
From: Ratheesh Kannoth <rkannoth@marvell.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
	<netdev@vger.kernel.org>, <oss-drivers@corigine.com>,
	<akiyano@amazon.com>, <andrew+netdev@lunn.ch>,
	<anthony.l.nguyen@intel.com>, <arkadiusz.kubalewski@intel.com>,
	<brett.creeley@amd.com>, <darinzon@amazon.com>,
	<davem@davemloft.net>, <donald.hunter@gmail.com>,
	<edumazet@google.com>, <horms@kernel.org>, <idosch@nvidia.com>,
	<ivecera@redhat.com>, <jiri@resnulli.us>, <leon@kernel.org>,
	<mbloch@nvidia.com>, <michael.chan@broadcom.com>,
	<pabeni@redhat.com>, <pavan.chebbi@broadcom.com>,
	<petrm@nvidia.com>, <Prathosh.Satish@microchip.com>,
	<przemyslaw.kitszel@intel.com>, <saeedm@nvidia.com>,
	<sgoutham@marvell.com>, <tariqt@nvidia.com>,
	<vadim.fedorenko@linux.dev>
Subject: Re: [PATCH v16 net-next 1/9] octeontx2-af: npc: cn20k: debugfs enhancements
Date: Mon, 1 Jun 2026 07:54:34 +0530	[thread overview]
Message-ID: <ahztYkP52uiPK-Uw@rkannoth-OptiPlex-7090> (raw)
In-Reply-To: <20260525135944.63d57e95@kernel.org>

On 2026-05-26 at 02:29:44, Jakub Kicinski (kuba@kernel.org) wrote:
> On Thu, 21 May 2026 15:22:55 +0530 Ratheesh Kannoth wrote:
> > Improve MCAM visibility and field debugging for CN20K NPC.
> >
> > - Extend "mcam_layout" to show enabled (+) or disabled state per entry
> >   so status can be verified without parsing the full "mcam_entry" dump.
> > - Add "dstats" debugfs entry: reports recently hit MCAM indices with
> >   packet counts; stats are cleared on read so each read shows deltas.
> > - Add "mismatch" debugfs entry: lists MCAM entries that are enabled
> >   but not explicitly allocated, helping diagnose allocation/field issues.
>
> debugfs file which clears state seems quite odd.
> Does any user need this?
The clear-on-read behavior in dstats is implemented to provide incremental (delta)
hit-counts for live field debugging.

On each read operation, the driver compares current hardware hit counters against
a cached baseline array (in software). It reports only the entries that experienced an increment,
and then updates the baseline cache to the current hardware values. This allows developers
to easily isolate active traffic matching rules without looking at all  monotonically increasing hw counters.

I will update the commit message to reflect the same.

> This looks like a crutch for badly written tests TBH.

  reply	other threads:[~2026-06-01  2:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-21  9:52 [PATCH v16 net-next 0/9] octeontx2-af: npc: Enhancements Ratheesh Kannoth
2026-05-21  9:52 ` [PATCH v16 net-next 1/9] octeontx2-af: npc: cn20k: debugfs enhancements Ratheesh Kannoth
2026-05-22 11:38   ` Ratheesh Kannoth
2026-05-25 20:59   ` Jakub Kicinski
2026-06-01  2:24     ` Ratheesh Kannoth [this message]
2026-05-21  9:52 ` [PATCH v16 net-next 2/9] net/mlx5e: Reduce stack use reading PCIe congestion thresholds Ratheesh Kannoth
2026-05-21  9:52 ` [PATCH v16 net-next 3/9] devlink: pass param values by pointer Ratheesh Kannoth
2026-05-21  9:52 ` [PATCH v16 net-next 4/9] devlink: Implement devlink param multi attribute nested data values Ratheesh Kannoth
2026-05-25 21:09   ` Jakub Kicinski
2026-05-21  9:52 ` [PATCH v16 net-next 5/9] octeontx2-af: npc: cn20k: add subbank search order control Ratheesh Kannoth
2026-05-21  9:53 ` [PATCH v16 net-next 6/9] octeontx2: cn20k: Coordinate default rules with NIX LF lifecycle Ratheesh Kannoth
2026-05-21  9:53 ` [PATCH v16 net-next 7/9] octeontx2-af: npc: Support for custom KPU profile from filesystem Ratheesh Kannoth
2026-05-22 11:48   ` Ratheesh Kannoth
2026-05-21  9:53 ` [PATCH v16 net-next 8/9] octeontx2: cn20k: Respect NPC MCAM X2/X4 profile in flows and DFT alloc Ratheesh Kannoth
2026-05-22 11:51   ` Ratheesh Kannoth
2026-05-21  9:53 ` [PATCH v16 net-next 9/9] octeontx2-af: npc: cn20k: Allocate npc_priv and dstats dynamically Ratheesh Kannoth
2026-05-25 21:20 ` [PATCH v16 net-next 0/9] octeontx2-af: npc: Enhancements patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahztYkP52uiPK-Uw@rkannoth-OptiPlex-7090 \
    --to=rkannoth@marvell.com \
    --cc=Prathosh.Satish@microchip.com \
    --cc=akiyano@amazon.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=arkadiusz.kubalewski@intel.com \
    --cc=brett.creeley@amd.com \
    --cc=darinzon@amazon.com \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=ivecera@redhat.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mbloch@nvidia.com \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@corigine.com \
    --cc=pabeni@redhat.com \
    --cc=pavan.chebbi@broadcom.com \
    --cc=petrm@nvidia.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=saeedm@nvidia.com \
    --cc=sgoutham@marvell.com \
    --cc=tariqt@nvidia.com \
    --cc=vadim.fedorenko@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox