From: Ratheesh Kannoth <rkannoth@marvell.com>
To: Runyu Xiao <runyu.xiao@seu.edu.cn>
Cc: <netdev@vger.kernel.org>, <sgoutham@marvell.com>,
<gakula@marvell.com>, <sbhatta@marvell.com>, <hkelam@marvell.com>,
<bbhushan2@marvell.com>, <andrew+netdev@lunn.ch>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <amakarov@marvell.com>,
<tduszynski@marvell.com>, <linux-kernel@vger.kernel.org>,
<jianhao.xu@seu.edu.cn>
Subject: Re: [PATCH net 0/2] octeontx2: quiesce stale mailbox IRQ state before request_irq()
Date: Mon, 15 Jun 2026 12:01:10 +0530 [thread overview]
Message-ID: <ai-cLqrb5JDaxqng@rkannoth-OptiPlex-7090> (raw)
In-Reply-To: <20260611160014.3202224-1-runyu.xiao@seu.edu.cn>
On 2026-06-11 at 21:30:12, Runyu Xiao (runyu.xiao@seu.edu.cn) wrote:
> Both OTX2 mailbox registration paths currently install their IRQ
> handlers before clearing stale local mailbox interrupt state, even
> though the code comments already say that the clear is needed first to
> avoid spurious interrupts.
>
> This issue was found by our static analysis tool and manually audited on
> Linux v6.18.21. Directed QEMU no-device validation further showed that
> the real PF and VF mailbox handlers are already reachable in that
> pre-clear window and can touch the same mailbox and workqueue carrier
> before local quiesce has completed.
>
> This series keeps the change minimal:
>
> - clear stale mailbox interrupt state before request_irq()
> - keep interrupt enabling after the handler is installed
>
> That closes the early-IRQ window without introducing a new
> enable-before-handler window.
Reviewed-by: Ratheesh Kannoth <rkannoth@marvell.com>
next prev parent reply other threads:[~2026-06-15 6:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 16:00 [PATCH net 0/2] octeontx2: quiesce stale mailbox IRQ state before request_irq() Runyu Xiao
2026-06-11 16:00 ` [PATCH net 1/2] octeontx2-pf: clear " Runyu Xiao
2026-06-11 16:00 ` [PATCH net 2/2] octeontx2-vf: " Runyu Xiao
2026-06-13 7:20 ` [PATCH net 0/2] octeontx2: quiesce " Simon Horman
2026-06-13 22:13 ` Jakub Kicinski
2026-06-15 6:31 ` Ratheesh Kannoth [this message]
2026-06-15 19:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ai-cLqrb5JDaxqng@rkannoth-OptiPlex-7090 \
--to=rkannoth@marvell.com \
--cc=amakarov@marvell.com \
--cc=andrew+netdev@lunn.ch \
--cc=bbhushan2@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jianhao.xu@seu.edu.cn \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=runyu.xiao@seu.edu.cn \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=tduszynski@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox