From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 697BA3E4C7B for ; Wed, 3 Jun 2026 17:07:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780506441; cv=none; b=Tcpymn+XnDZvtaHyoPjP+w1AA9DmeQOUh/79aldVO9v2SkZV8uZ3wiSkAVCJi78C72ZT/yRfpncQPDSw0GvL0t+uPx+VVx2PjUogMYdReq6/bRbqNR78MMpKKh7lm3Ij4p2DXI2pYKHB0pILIYMX4RGsVnU/tHB0Dlw6jD9ObT0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780506441; c=relaxed/simple; bh=VI9XorPSlhfHmOeG230kpRBkPlDvZ777QxVLMeV1TIo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iVDGM9eTqHYoUuq6wiuKY+1TU0FFwTsof3MwA4Jn5Iqn2g25OExy9aWDU+yVMEwm68/7R8R3iJoSpwx4rSpxNLHLwJ7Psf89HDhxvjAe57qzmMU/xE/9+h8Pc7DNQBndtVoBIsznfqNW2vropyUaX8+yGWQ0bRxBJyKFkxg2pik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kuu8xEzP; arc=none smtp.client-ip=209.85.214.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kuu8xEzP" Received: by mail-pl1-f194.google.com with SMTP id d9443c01a7336-2bea7176c72so101575135ad.0 for ; Wed, 03 Jun 2026 10:07:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780506439; x=1781111239; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TihK8TLFQ7eWvBfrOf1I2w6CeTT78T3znP19Zg8cOL0=; b=kuu8xEzPGVtYcbUdgLVRDz7jEPpovEu29/xKnSf/GKM0yiEGM8UWbgNu7fsWLxbipW fj9xO0HR8WQ/fbGPJKNwofyZHhK2qetgHoooD57wE40x0Bkj1J8+OsYBbcJB3o4qt5QM 2iLcTnDF5R7qYKotQ2CqfwmPenDNmVaLQir8VlpEYBucx4M1TdSLyBOvwnpfV1iJ6UC3 UUan5QKGJd988cqop0i/LgFr/ENIC8e654sSJgJpZNXYBVQusgC4hWCLcgpOy8Gs0P+E UMAFqiIGO2P8YK6NsGNb//DD9V1atlGEtoVfr26L684pdzm23Yn/nuE4e1YxtKDW0daV K6uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780506439; x=1781111239; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TihK8TLFQ7eWvBfrOf1I2w6CeTT78T3znP19Zg8cOL0=; b=gG8M2b4Cjo8hITQ+myBxsyp1YvtXd5ye004eb53YkBbA0WwdJpfRc4MB1hxVvkrryA ztg2u0Xm2EOVjHydr0EO8DVgZzOSrN1MhvzeSSVlWd1tC6KjV5KqIwSlcdRrRcOH06fq svuE6fS265olrq1x8BIrqY+Hp+mTVWLTiJxwat/WvClnYcd2GfjRQYNtFTafe4qouqdO sh0kWtpGKdaHb20i0PV25rO16TxFy6OsZyC5jB1gSo9ek2/sXwpUHDc0N1IEG744MStj FkbIA8v4Ty0KUBeZ0mGHaIChopxd/OVeLYFoGDYpBaeTTHPeZ/WDll4XQgkDPQvCC+zT K2AA== X-Forwarded-Encrypted: i=1; AFNElJ+I2pDMgIyYMRIlMZR9e5v+1N9wKsmBG83Hv3d9gGLNdk8GbYoEdvuJJE1r1Lg4YIrhmsDkgKY=@vger.kernel.org X-Gm-Message-State: AOJu0Yyc6Fvy2V6CTBmYeJQAUwj9oIiK3UQEDftH0xr5YfmnKSidaHTS FhkK/P0ntE/P4SEiFXpOnpyQmO438GWFF50N9SGS8MK00lvWORvo+3Qw X-Gm-Gg: Acq92OETmbSCYS7hB/4618xjD0m0e31m1Tglk3aEmz4qC5espMoCzSlZ4Gjd/YopxYF XLhGaxyJjQ43yyM6/J60/D0eLTg+AsE/76Yb+FAHMlTrh2pP4tFTcfGU/62KOsumPHDYTKhCN+z QtUhcO+sdAxzKQziLxYkKacDCOR3rAWk47p/rqXysesL10BbfE/ZygpibE6t9jveXgZJYGGkLxn SlZTygLz9d11ii17oEZr/oT9UYlZLPzc1+riybXuZ7//swHf9S/phhddoiyOkXPt+vCVzglzOtD R7wAUlXnlRSL3FfSykHKn6/mukZ6r0uBscDbxZX2HmuSm/xNeqngAE8hwnM91eWjsbew1iTXyYX dad26/s0skXI6TsMYU+4getyG38wqwbBgJAOBknIIyWclxmws+pdyJ+0sX4V9iDjTHOUYpoPmhN hGwSVCO3YzMXxdHIWUbhSi1iEev24= X-Received: by 2002:a17:902:ef44:b0:2be:22cc:e227 with SMTP id d9443c01a7336-2c1639ee5b0mr42224385ad.4.1780506439527; Wed, 03 Jun 2026 10:07:19 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:58::]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c16609e234sm32078445ad.53.2026.06.03.10.07.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jun 2026 10:07:19 -0700 (PDT) Date: Wed, 3 Jun 2026 10:05:45 -0700 From: Stanislav Fomichev To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org, jakub@cloudflare.com, maxime.chevallier@bootlin.com, nb@tipi-net.de, lee@kernel.org, linux-leds@vger.kernel.org, pavel@kernel.org, jv@jvosburgh.net, michael.chan@broadcom.com, jhs@mojatatu.com, vinicius.gomes@intel.com, idosch@nvidia.com, razor@blackwall.org, hare@suse.de, jhasan@marvell.com, danieller@nvidia.com Subject: Re: [PATCH net-next v2 01/11] net: rename netdev_ops_assert_locked() Message-ID: References: <20260603012840.2254293-1-kuba@kernel.org> <20260603012840.2254293-2-kuba@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260603012840.2254293-2-kuba@kernel.org> On 06/02, Jakub Kicinski wrote: > Jakub suggests renaming the existing assert to match > the netdev_lock_ops_compat() semantics. > > We want netdev_assert_locked_ops() to mean - if the driver > is ops locked - check that it's holding the device lock. > > The existing helper check for either ops lock or rtnl_lock, > which is the locking behavior of netdev_lock_ops_compat(). > > The reason for naming divergence is likely that > netdev_ops_assert_locked() predated the _compat() helpers. > > Suggested-by: Jakub Sitnicki > Signed-off-by: Jakub Kicinski Acked-by: Stanislav Fomichev